Re: [OE-core] [PATCH] gcc-configure: Enable the use of different symbol versioning
Hey Khem, On Sun, Jan 19, 2020, 4:22 PM Khem Raj wrote: > On Sat, Jan 18, 2020 at 7:02 PM Alejandro Enedino Hernandez Samaniego > wrote: > > > > While the gnu style for symbol versioning is the most usual, > > --enable-symvers[=style] can be provided several values, > > gnu, gnu-versioned-namespace, darwin, darwin-export, and sun, > > depending on users needs. > > > > Introduce the SYMVERS_CONF variable to allow the user to > > configure the symbol versioning in shared libraries. > > > > Signed-off-by: Alejandro Enedino Hernandez Samaniego < > alejan...@enedino.org> > > --- > > meta/recipes-devtools/gcc/gcc-configure-common.inc | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc > b/meta/recipes-devtools/gcc/gcc-configure-common.inc > > index 24ba8ce..bb4f692 100644 > > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc > > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc > > @@ -17,6 +17,8 @@ GCCTHREADS ?= "posix" > > > > GCCPIE ??= "" > > > > +SYMVERS_CONF ?= "--enable-symvers=gnu" > > + > > just turn the RHS into variable not full option > I did think about that, and I can do it, but I think I would have to also create a PACKAGECONFIG and since AFAIC no one is changing the style I'm not sure it's worth the complication of the code, and this still allows us to remove the enablement entirely, not just changing the style. Alejandro > > EXTRA_OECONF = "\ > > ${@['--enable-clocale=generic', ''][d.getVar('USE_NLS') != 'no']} \ > > --with-gnu-ld \ > > @@ -27,7 +29,7 @@ EXTRA_OECONF = "\ > > ${GCCPIE} \ > > --enable-c99 \ > > --enable-long-long \ > > ---enable-symvers=gnu \ > > +${SYMVERS_CONF} \ > > --enable-libstdcxx-pch \ > > --program-prefix=${TARGET_PREFIX} \ > > --without-local-prefix \ > > -- > > 2.7.4 > > > > -- > > ___ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] gcc-configure: Enable the use of different symbol versioning
On Sat, Jan 18, 2020 at 7:02 PM Alejandro Enedino Hernandez Samaniego wrote: > > While the gnu style for symbol versioning is the most usual, > --enable-symvers[=style] can be provided several values, > gnu, gnu-versioned-namespace, darwin, darwin-export, and sun, > depending on users needs. > > Introduce the SYMVERS_CONF variable to allow the user to > configure the symbol versioning in shared libraries. > > Signed-off-by: Alejandro Enedino Hernandez Samaniego > --- > meta/recipes-devtools/gcc/gcc-configure-common.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc > b/meta/recipes-devtools/gcc/gcc-configure-common.inc > index 24ba8ce..bb4f692 100644 > --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc > +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc > @@ -17,6 +17,8 @@ GCCTHREADS ?= "posix" > > GCCPIE ??= "" > > +SYMVERS_CONF ?= "--enable-symvers=gnu" > + just turn the RHS into variable not full option > EXTRA_OECONF = "\ > ${@['--enable-clocale=generic', ''][d.getVar('USE_NLS') != 'no']} \ > --with-gnu-ld \ > @@ -27,7 +29,7 @@ EXTRA_OECONF = "\ > ${GCCPIE} \ > --enable-c99 \ > --enable-long-long \ > ---enable-symvers=gnu \ > +${SYMVERS_CONF} \ > --enable-libstdcxx-pch \ > --program-prefix=${TARGET_PREFIX} \ > --without-local-prefix \ > -- > 2.7.4 > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] gcc-configure: Enable the use of different symbol versioning
While the gnu style for symbol versioning is the most usual, --enable-symvers[=style] can be provided several values, gnu, gnu-versioned-namespace, darwin, darwin-export, and sun, depending on users needs. Introduce the SYMVERS_CONF variable to allow the user to configure the symbol versioning in shared libraries. Signed-off-by: Alejandro Enedino Hernandez Samaniego --- meta/recipes-devtools/gcc/gcc-configure-common.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc b/meta/recipes-devtools/gcc/gcc-configure-common.inc index 24ba8ce..bb4f692 100644 --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc @@ -17,6 +17,8 @@ GCCTHREADS ?= "posix" GCCPIE ??= "" +SYMVERS_CONF ?= "--enable-symvers=gnu" + EXTRA_OECONF = "\ ${@['--enable-clocale=generic', ''][d.getVar('USE_NLS') != 'no']} \ --with-gnu-ld \ @@ -27,7 +29,7 @@ EXTRA_OECONF = "\ ${GCCPIE} \ --enable-c99 \ --enable-long-long \ ---enable-symvers=gnu \ +${SYMVERS_CONF} \ --enable-libstdcxx-pch \ --program-prefix=${TARGET_PREFIX} \ --without-local-prefix \ -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core