Re: [OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends
Hi Richard and Andre, On Tue, Nov 24, 2020 at 4:52 PM Richard Purdie wrote: > On Mon, 2020-11-23 at 11:54 -0800, Andre McCurdy wrote: > > On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas > > wrote: > > > When building libsdl2 with PACKAGECONFIG[directfb] then directfb is > > > added to the DEPENDS. But the automatically generated runtime > > > dependencies do not add the directfb package to the runtime > > > dependencies. Most likely this happens because libsdl2 does not > > > link > > > against directfb but uses dlopen() or similar. Thus, the runtime > > > dependency to directfb needs to be declared explicitly. > > > > > > Here, a runtime recommendation is used to allow ignoring the > > > runtime > > > dependency using NO_RECOMMENDATIONS. > > > > Why would anyone want to ignore the runtime dependency? > > Agreed, that does seem strange. Whichever way this goes, the patch > shortlog needs to match the commit (it says rdepends right now). Thank you for the feedback. I'll send a V2 of the patch. Greetings, Mark -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144957): https://lists.openembedded.org/g/openembedded-core/message/144957 Mute This Topic: https://lists.openembedded.org/mt/78460941/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends
On Mon, 2020-11-23 at 11:54 -0800, Andre McCurdy wrote: > On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas > wrote: > > When building libsdl2 with PACKAGECONFIG[directfb] then directfb is > > added to the DEPENDS. But the automatically generated runtime > > dependencies do not add the directfb package to the runtime > > dependencies. Most likely this happens because libsdl2 does not > > link > > against directfb but uses dlopen() or similar. Thus, the runtime > > dependency to directfb needs to be declared explicitly. > > > > Here, a runtime recommendation is used to allow ignoring the > > runtime > > dependency using NO_RECOMMENDATIONS. > > Why would anyone want to ignore the runtime dependency? Agreed, that does seem strange. Whichever way this goes, the patch shortlog needs to match the commit (it says rdepends right now). Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144955): https://lists.openembedded.org/g/openembedded-core/message/144955 Mute This Topic: https://lists.openembedded.org/mt/78460941/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends
On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas wrote: > > When building libsdl2 with PACKAGECONFIG[directfb] then directfb is > added to the DEPENDS. But the automatically generated runtime > dependencies do not add the directfb package to the runtime > dependencies. Most likely this happens because libsdl2 does not link > against directfb but uses dlopen() or similar. Thus, the runtime > dependency to directfb needs to be declared explicitly. > > Here, a runtime recommendation is used to allow ignoring the runtime > dependency using NO_RECOMMENDATIONS. Why would anyone want to ignore the runtime dependency? > Signed-off-by: Mark Jonas > --- > meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb > b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb > index 2ef7d2e5ef..ae42db2610 100644 > --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb > +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb > @@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \ > " > PACKAGECONFIG[alsa] = "--enable-alsa > --disable-alsatest,--disable-alsa,alsa-lib," > PACKAGECONFIG[arm-neon] = "--enable-arm-neon,--disable-arm-neon" > -PACKAGECONFIG[directfb] = > "--enable-video-directfb,--disable-video-directfb,directfb" > +PACKAGECONFIG[directfb] = > "--enable-video-directfb,--disable-video-directfb,directfb,,directfb" > PACKAGECONFIG[gles2] = > "--enable-video-opengles,--disable-video-opengles,virtual/libgles2" > PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack" > PACKAGECONFIG[kmsdrm] = > "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm" > -- > 2.25.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144940): https://lists.openembedded.org/g/openembedded-core/message/144940 Mute This Topic: https://lists.openembedded.org/mt/78460941/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends
When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly. Here, a runtime recommendation is used to allow ignoring the runtime dependency using NO_RECOMMENDATIONS. Signed-off-by: Mark Jonas --- meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb index 2ef7d2e5ef..ae42db2610 100644 --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb @@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \ " PACKAGECONFIG[alsa] = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib," PACKAGECONFIG[arm-neon] = "--enable-arm-neon,--disable-arm-neon" -PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb" +PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb" PACKAGECONFIG[gles2] = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2" PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack" PACKAGECONFIG[kmsdrm] = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm" -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#144938): https://lists.openembedded.org/g/openembedded-core/message/144938 Mute This Topic: https://lists.openembedded.org/mt/78460941/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
