Re: [OE-core] [PATCH] lrzsz: Add implicit declaration fixes from Debian
On Wed, Jun 05, 2019 at 10:18:31AM +0200, Martin Jansa wrote: > On Mon, Jun 03, 2019 at 09:47:02AM +0300, Adrian Bunk wrote: > > Signed-off-by: Adrian Bunk > > -- > > You need one more dash here, now this v2 comment ended in final commit message > which I believe wasn't the intention. > > http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2 > > the same with tcp-wrappers change: > http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a >... Yes thanks, I already noticed my mistake. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] lrzsz: Add implicit declaration fixes from Debian
On Mon, Jun 03, 2019 at 09:47:02AM +0300, Adrian Bunk wrote: > Signed-off-by: Adrian Bunk > -- You need one more dash here, now this v2 comment ended in final commit message which I believe wasn't the intention. http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2 the same with tcp-wrappers change: http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a > v2: Add comment in the patch header. > --- > .../lrzsz/lrzsz-0.12.20/include.patch | 25 +++ > meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + > 2 files changed, 26 insertions(+) > create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > > diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > new file mode 100644 > index 00..5fcb3aa92b > --- /dev/null > +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > @@ -0,0 +1,25 @@ > +Implicit declaration compile warning fixes from Debian > + > +Signed-off-by: Adrian Bunk > +Upstream-Status: Inappropriate [upstream is dead] > + > +--- lrzsz-0.12.21.orig/lib/long-options.c > lrzsz-0.12.21/lib/long-options.c > +@@ -22,6 +22,7 @@ > + #endif > + > + #include > ++#include > + #include > + #include "long-options.h" > + > +--- lrzsz-0.12.21.orig/src/lsyslog.c > lrzsz-0.12.21/src/lsyslog.c > +@@ -22,6 +22,7 @@ > + #ifdef ENABLE_SYSLOG > + #include "zglobal.h" > + #include > ++#include > + #include > + #include > + #endif > diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > index 002c774c6d..34556b2c29 100644 > --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > @@ -20,6 +20,7 @@ SRC_URI = > "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \ > file://lrzsz_fix_for_automake-1.12.patch \ > file://lrzsz-check-locale.h.patch \ > file://cve-2018-10195.patch \ > + file://include.patch \ > " > > SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4" > -- > 2.17.1 > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] lrzsz: Add implicit declaration fixes from Debian
Signed-off-by: Adrian Bunk -- v2: Add comment in the patch header. --- .../lrzsz/lrzsz-0.12.20/include.patch | 25 +++ meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + 2 files changed, 26 insertions(+) create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch new file mode 100644 index 00..5fcb3aa92b --- /dev/null +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch @@ -0,0 +1,25 @@ +Implicit declaration compile warning fixes from Debian + +Signed-off-by: Adrian Bunk +Upstream-Status: Inappropriate [upstream is dead] + +--- lrzsz-0.12.21.orig/lib/long-options.c lrzsz-0.12.21/lib/long-options.c +@@ -22,6 +22,7 @@ + #endif + + #include ++#include + #include + #include "long-options.h" + +--- lrzsz-0.12.21.orig/src/lsyslog.c lrzsz-0.12.21/src/lsyslog.c +@@ -22,6 +22,7 @@ + #ifdef ENABLE_SYSLOG + #include "zglobal.h" + #include ++#include + #include + #include + #endif diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb index 002c774c6d..34556b2c29 100644 --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb @@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \ file://lrzsz_fix_for_automake-1.12.patch \ file://lrzsz-check-locale.h.patch \ file://cve-2018-10195.patch \ + file://include.patch \ " SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4" -- 2.17.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] lrzsz: Add implicit declaration fixes from Debian
On Sun, Jun 02, 2019 at 11:36:51AM +0100, Richard Purdie wrote: > > Could you put at least something in the patch header to say what the > patch does please? Added in v2. > Cheers, > > Richard cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] lrzsz: Add implicit declaration fixes from Debian
On Sun, 2019-06-02 at 00:58 +0300, Adrian Bunk wrote: > Signed-off-by: Adrian Bunk > --- > .../lrzsz/lrzsz-0.12.20/include.patch | 23 > +++ > meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + > 2 files changed, 24 insertions(+) > create mode 100644 meta/recipes-bsp/lrzsz/lrzsz- > 0.12.20/include.patch > > diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > new file mode 100644 > index 00..3925fc8c86 > --- /dev/null > +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch > @@ -0,0 +1,23 @@ > +Signed-off-by: Adrian Bunk > +Upstream-Status: Inappropriate [upstream is dead] Could you put at least something in the patch header to say what the patch does please? Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] lrzsz: Add implicit declaration fixes from Debian
Signed-off-by: Adrian Bunk --- .../lrzsz/lrzsz-0.12.20/include.patch | 23 +++ meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + 2 files changed, 24 insertions(+) create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch new file mode 100644 index 00..3925fc8c86 --- /dev/null +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch @@ -0,0 +1,23 @@ +Signed-off-by: Adrian Bunk +Upstream-Status: Inappropriate [upstream is dead] + +--- lrzsz-0.12.21.orig/lib/long-options.c lrzsz-0.12.21/lib/long-options.c +@@ -22,6 +22,7 @@ + #endif + + #include ++#include + #include + #include "long-options.h" + +--- lrzsz-0.12.21.orig/src/lsyslog.c lrzsz-0.12.21/src/lsyslog.c +@@ -22,6 +22,7 @@ + #ifdef ENABLE_SYSLOG + #include "zglobal.h" + #include ++#include + #include + #include + #endif diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb index 002c774c6d..34556b2c29 100644 --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb @@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \ file://lrzsz_fix_for_automake-1.12.patch \ file://lrzsz-check-locale.h.patch \ file://cve-2018-10195.patch \ + file://include.patch \ " SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4" -- 2.17.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core