Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-23 Thread richard . purdie
On Thu, 2018-08-23 at 12:40 -0400, Derek Straka wrote: > +1 for this being opt in. It's a substantial hit to build time > > On Thu, Aug 23, 2018 at 12:21 PM Christopher Larson m> wrote: > > IMO PGO should really stay opt-in, not opt-out, given the > > performance impact. I'm not arguing

Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-23 Thread Derek Straka
+1 for this being opt in. It's a substantial hit to build time On Thu, Aug 23, 2018 at 12:21 PM Christopher Larson wrote: > IMO PGO should really stay opt-in, not opt-out, given the performance > impact. > > On Thu, Aug 23, 2018 at 1:28 AM Richard Purdie < > richard.pur...@linuxfoundation.org>

Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-23 Thread Christopher Larson
IMO PGO should really stay opt-in, not opt-out, given the performance impact. On Thu, Aug 23, 2018 at 1:28 AM Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > On Wed, 2018-08-22 at 18:44 -0700, Andre McCurdy wrote: > > On Thu, Aug 16, 2018 at 9:48 PM, Anuj Mittal > > wrote: > > >

Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-23 Thread Richard Purdie
On Wed, 2018-08-22 at 18:44 -0700, Andre McCurdy wrote: > On Thu, Aug 16, 2018 at 9:48 PM, Anuj Mittal > wrote: > > On 08/17/2018 03:31 AM, Andre McCurdy wrote: > > > On Wed, Aug 15, 2018 at 11:26 PM, Anuj Mittal > > com> wrote: > > > Is it important to re-create the profile data during every

Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-22 Thread Andre McCurdy
On Thu, Aug 16, 2018 at 9:48 PM, Anuj Mittal wrote: > On 08/17/2018 03:31 AM, Andre McCurdy wrote: >> On Wed, Aug 15, 2018 at 11:26 PM, Anuj Mittal wrote: >>> Enable profile guided optimization (pgo) for python3. Enabling pgo in >>> python is generally as simple as invoking the target

Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-16 Thread Anuj Mittal
On 08/17/2018 03:31 AM, Andre McCurdy wrote: > On Wed, Aug 15, 2018 at 11:26 PM, Anuj Mittal wrote: >> Enable profile guided optimization (pgo) for python3. Enabling pgo in >> python is generally as simple as invoking the target profile-opt which: >> >> - builds python binaries with profile

Re: [OE-core] [PATCH] python3: enable profile optimized builds

2018-08-16 Thread Andre McCurdy
On Wed, Aug 15, 2018 at 11:26 PM, Anuj Mittal wrote: > Enable profile guided optimization (pgo) for python3. Enabling pgo in > python is generally as simple as invoking the target profile-opt which: > > - builds python binaries with profile instrumentation enabled, > - runs a specific profile

[OE-core] [PATCH] python3: enable profile optimized builds

2018-08-16 Thread Anuj Mittal
Enable profile guided optimization (pgo) for python3. Enabling pgo in python is generally as simple as invoking the target profile-opt which: - builds python binaries with profile instrumentation enabled, - runs a specific profile task using that python to get the profile data and, - feeds the