Re: [OE-core] [PATCH] rootfs.py: mask run-postinsts systemd service when unneeded

2021-03-22 Thread Alexander Kanavin
Right, I guess I was missing the context where the patch is applied: "if delayed_postinst is None" inside uninstall_unneeded(). Perhaps you could expand the commit message a bit, and say specifically what is the scenario when this is executed ("not needed" is somewhat vague). Then no separate

Re: [OE-core] [PATCH] rootfs.py: mask run-postinsts systemd service when unneeded

2021-03-22 Thread Awais Belal
Hi Alex, > > Why isn’t this seen in the tests? Can you add a test that shows the issue > please? (Fails without the patch, passes with) I'm not very well versed with the oe test infrastructure, I'd be happy to create a test for this scenario if you can point me to the material that I need to

Re: [OE-core] [PATCH] rootfs.py: mask run-postinsts systemd service when unneeded

2021-03-22 Thread Alexander Kanavin
Why isn’t this seen in the tests? Can you add a test that shows the issue please? (Fails without the patch, passes with) Alex On Mon 22. Mar 2021 at 10.07, Awais Belal wrote: > The service is unnecessarily run even when it is unneeded. > This was handled correctly for sysV systems however the

[OE-core] [PATCH] rootfs.py: mask run-postinsts systemd service when unneeded

2021-03-22 Thread Awais Belal
The service is unnecessarily run even when it is unneeded. This was handled correctly for sysV systems however the service still runs on the systemd systems as it is not disabled/masked when not needed. Signed-off-by: Awais Belal --- meta/lib/oe/rootfs.py | 4 1 file changed, 4