Re: [OE-core] [PATCH] testimage.bbclass: Add kernel provider and version to testresult
On Thu, 2019-10-03 at 07:35 +0800, Yeoh Ee Peng wrote: > In running QA testing, we sometime need to select custom provider > for > virtual/kernel and version. To track the selected virtual/kernel > provider > and version used during test, we need to add these information to > testresult. > > This patch add the virtual/kernel and version into the testresult > configuration section. > > Example of virtual/kernel and version added to testresult > configuration: >- "KERNEL_PROVIDER_VERSION": "linux-intel_4.19" > > Signed-off-by: Yeoh Ee Peng > --- > meta/classes/testimage.bbclass | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) My reply last time this was posted: http://lists.openembedded.org/pipermail/openembedded-core/2019-September/287138.html still applies. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] testimage.bbclass: Add kernel provider and version to testresult
In running QA testing, we sometime need to select custom provider for virtual/kernel and version. To track the selected virtual/kernel provider and version used during test, we need to add these information to testresult. This patch add the virtual/kernel and version into the testresult configuration section. Example of virtual/kernel and version added to testresult configuration: - "KERNEL_PROVIDER_VERSION": "linux-intel_4.19" Signed-off-by: Yeoh Ee Peng --- meta/classes/testimage.bbclass | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass index 525c5a6..194d549 100644 --- a/meta/classes/testimage.bbclass +++ b/meta/classes/testimage.bbclass @@ -129,14 +129,30 @@ def testimage_sanity(d): def get_testimage_configuration(d, test_type, machine): import platform from oeqa.utils.metadata import get_layers +distro = d.getVar("DISTRO") +distrooverride = d.getVar("DISTROOVERRIDES") + +kernel_provider = d.getVar("PREFERRED_PROVIDER_virtual/kernel") +for o in distrooverride.split(":"): +kernel_provider_override = d.getVar("PREFERRED_PROVIDER_virtual/kernel_%s" % o) +if kernel_provider_override: +kernel_provider = kernel_provider_override + +kernel_provider_version = d.getVar("PREFERRED_VERSION_%s" % kernel_provider).replace('%', '') +for o in distrooverride.split(":"): +kernel_provider_version_override = d.getVar("PREFERRED_VERSION_%s_%s" % (kernel_provider, o)) +if kernel_provider_version_override: +kernel_provider_version = kernel_provider_version_override.replace('%', '') + configuration = {'TEST_TYPE': test_type, 'MACHINE': machine, -'DISTRO': d.getVar("DISTRO"), +'DISTRO': distro, 'IMAGE_BASENAME': d.getVar("IMAGE_BASENAME"), 'IMAGE_PKGTYPE': d.getVar("IMAGE_PKGTYPE"), 'STARTTIME': d.getVar("DATETIME"), 'HOST_DISTRO': oe.lsb.distro_identifier().replace(' ', '-'), -'LAYERS': get_layers(d.getVar("BBLAYERS"))} +'LAYERS': get_layers(d.getVar("BBLAYERS")), +'KERNEL_PROVIDER_VERSION': '%s_%s' % (kernel_provider, kernel_provider_version)} return configuration get_testimage_configuration[vardepsexclude] = "DATETIME" -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] testimage.bbclass: Add kernel provider and version to testresult
On Tue, 2019-09-17 at 09:27 +0800, Yeoh Ee Peng wrote: > In running QA testing, we sometime need to select custom provider > for > virtual/kernel and version. To track the selected virtual/kernel > provider > and version used during test, we need to add these information to > testresult. > > This patch add the virtual/kernel and version into the testresult > configuration section. > > Example of virtual/kernel and version added to testresult > configuration: >- "KERNEL_PROVIDER_VERSION": "linux-intel_4.19" > > Signed-off-by: Yeoh Ee Peng > --- > meta/classes/testimage.bbclass | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) This fixes a very specific use case but we don't really want to add extra variables to this each time someone has a new use case. In other words this isn't going to scale. The idea originally is that "DISTRO" should give a pretty good idea of what was being tested. Another idea would be to allow the variables to be configurable but I'm not sure we want to support adding arbitrary variables... Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] testimage.bbclass: Add kernel provider and version to testresult
In running QA testing, we sometime need to select custom provider for virtual/kernel and version. To track the selected virtual/kernel provider and version used during test, we need to add these information to testresult. This patch add the virtual/kernel and version into the testresult configuration section. Example of virtual/kernel and version added to testresult configuration: - "KERNEL_PROVIDER_VERSION": "linux-intel_4.19" Signed-off-by: Yeoh Ee Peng --- meta/classes/testimage.bbclass | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass index 525c5a6..194d549 100644 --- a/meta/classes/testimage.bbclass +++ b/meta/classes/testimage.bbclass @@ -129,14 +129,30 @@ def testimage_sanity(d): def get_testimage_configuration(d, test_type, machine): import platform from oeqa.utils.metadata import get_layers +distro = d.getVar("DISTRO") +distrooverride = d.getVar("DISTROOVERRIDES") + +kernel_provider = d.getVar("PREFERRED_PROVIDER_virtual/kernel") +for o in distrooverride.split(":"): +kernel_provider_override = d.getVar("PREFERRED_PROVIDER_virtual/kernel_%s" % o) +if kernel_provider_override: +kernel_provider = kernel_provider_override + +kernel_provider_version = d.getVar("PREFERRED_VERSION_%s" % kernel_provider).replace('%', '') +for o in distrooverride.split(":"): +kernel_provider_version_override = d.getVar("PREFERRED_VERSION_%s_%s" % (kernel_provider, o)) +if kernel_provider_version_override: +kernel_provider_version = kernel_provider_version_override.replace('%', '') + configuration = {'TEST_TYPE': test_type, 'MACHINE': machine, -'DISTRO': d.getVar("DISTRO"), +'DISTRO': distro, 'IMAGE_BASENAME': d.getVar("IMAGE_BASENAME"), 'IMAGE_PKGTYPE': d.getVar("IMAGE_PKGTYPE"), 'STARTTIME': d.getVar("DATETIME"), 'HOST_DISTRO': oe.lsb.distro_identifier().replace(' ', '-'), -'LAYERS': get_layers(d.getVar("BBLAYERS"))} +'LAYERS': get_layers(d.getVar("BBLAYERS")), +'KERNEL_PROVIDER_VERSION': '%s_%s' % (kernel_provider, kernel_provider_version)} return configuration get_testimage_configuration[vardepsexclude] = "DATETIME" -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core