Re: [OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Gary Thomas]

On 2015-10-16 08:44, Martin Jansa wrote:

On Fri, Oct 16, 2015 at 08:40:10AM -0600, Gary Thomas wrote:

On 2015-10-16 08:25, Ioan-Adrian Ratiu wrote:

x11vnc can be configured with --use-system-libvncserver to use an
external libvncserver which will be added to meta-oe. Since oe-core
should not depend on meta-oe, we move x11vnc there.

Signed-off-by: Ioan-Adrian Ratiu 


Just curious why not the other way - move libvncserver to OE-core?
x11vnc seems like one of the very few [and useful] X based tools that
are present in OE-core that it seems like a huge step backwards to
move it out.


It was discussed in "[OE-core] [oe] [meta-oe][PATCH v2] meta-oe:
recipes-graphics: add libvncserver recipe" thread and I agree with
Otavio that x11vnc doesn't look so fundamental component used by most
embedded builds to deserver being in the core.


Well, I tend to disagree and I don't think there has really been a
discussion - only one "no" (Otavio) and one "I don't know" (Paul).

--

Gary Thomas |  Consulting for the
MLB Associates  |Embedded world

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Otavio Salvador]

On Fri, Oct 16, 2015 at 12:21 PM, Gary Thomas  wrote:
> On 2015-10-16 08:44, Martin Jansa wrote:
>>
>> On Fri, Oct 16, 2015 at 08:40:10AM -0600, Gary Thomas wrote:
>>>
>>> On 2015-10-16 08:25, Ioan-Adrian Ratiu wrote:

 x11vnc can be configured with --use-system-libvncserver to use an
 external libvncserver which will be added to meta-oe. Since oe-core
 should not depend on meta-oe, we move x11vnc there.

 Signed-off-by: Ioan-Adrian Ratiu 
>>>
>>>
>>> Just curious why not the other way - move libvncserver to OE-core?
>>> x11vnc seems like one of the very few [and useful] X based tools that
>>> are present in OE-core that it seems like a huge step backwards to
>>> move it out.
>>
>>
>> It was discussed in "[OE-core] [oe] [meta-oe][PATCH v2] meta-oe:
>> recipes-graphics: add libvncserver recipe" thread and I agree with
>> Otavio that x11vnc doesn't look so fundamental component used by most
>> embedded builds to deserver being in the core.
>
> Well, I tend to disagree and I don't think there has really been a
> discussion - only one "no" (Otavio) and one "I don't know" (Paul).

The recipe being in meta-oe, can be used anyway. It is just out of OE-Core.

Anyway, what x11vnc has to provide to a core system? it even requires
X11 which a lot of embedded systems are moving away from...

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Gary Thomas]

On 2015-10-16 09:29, Otavio Salvador wrote:

On Fri, Oct 16, 2015 at 12:21 PM, Gary Thomas  wrote:

On 2015-10-16 08:44, Martin Jansa wrote:


On Fri, Oct 16, 2015 at 08:40:10AM -0600, Gary Thomas wrote:


On 2015-10-16 08:25, Ioan-Adrian Ratiu wrote:


x11vnc can be configured with --use-system-libvncserver to use an
external libvncserver which will be added to meta-oe. Since oe-core
should not depend on meta-oe, we move x11vnc there.

Signed-off-by: Ioan-Adrian Ratiu 



Just curious why not the other way - move libvncserver to OE-core?
x11vnc seems like one of the very few [and useful] X based tools that
are present in OE-core that it seems like a huge step backwards to
move it out.



It was discussed in "[OE-core] [oe] [meta-oe][PATCH v2] meta-oe:
recipes-graphics: add libvncserver recipe" thread and I agree with
Otavio that x11vnc doesn't look so fundamental component used by most
embedded builds to deserver being in the core.


Well, I tend to disagree and I don't think there has really been a
discussion - only one "no" (Otavio) and one "I don't know" (Paul).


The recipe being in meta-oe, can be used anyway. It is just out of OE-Core.

Anyway, what x11vnc has to provide to a core system? it even requires
X11 which a lot of embedded systems are moving away from...



Maybe for you, but not my customers - most of them insist on it.

Yes, x11nvc in meta-oe is an answer, but I don't want to have to
drag in meta-oe (way too heavy for my tastes) just to be able to
use it (I use it all the time to debug customer systems that I only
have remote access to)...

Maybe we should abandon Python or GDB (server) from OE-core as they
aren't used by all systems either??

--

Gary Thomas |  Consulting for the
MLB Associates  |Embedded world

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Ioan-Adrian Ratiu]

x11vnc can be configured with --use-system-libvncserver to use an
external libvncserver which will be added to meta-oe. Since oe-core
should not depend on meta-oe, we move x11vnc there.

Signed-off-by: Ioan-Adrian Ratiu 
---
 .../recipes-graphics/x11vnc/files/endian-fix.patch | 24 -
 .../x11vnc/files/starting-fix.patch| 25 --
 meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb  | 25 --
 3 files changed, 74 deletions(-)
 delete mode 100644 meta/recipes-graphics/x11vnc/files/endian-fix.patch
 delete mode 100644 meta/recipes-graphics/x11vnc/files/starting-fix.patch
 delete mode 100644 meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb

diff --git a/meta/recipes-graphics/x11vnc/files/endian-fix.patch 
b/meta/recipes-graphics/x11vnc/files/endian-fix.patch
deleted file mode 100644
index f2a538b..000
--- a/meta/recipes-graphics/x11vnc/files/endian-fix.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-libvncserver: replace LIBVNCSERVER_WORDS_BIGENDIAN with WORDS_BIGENDIAN
-
-since macro AC_C_BIGENDIAN is used in autoconf and WORDS_BIGENDIAN is
-automatically set for different arch, it is better to use WORDS_BIGENDIAN
-instead of LIBVNCSERVER_WORDS_BIGENDIAN, which cuase issue in mips.
-
-Signed-off-by: Yu Ke 
-
-Upstream-Status: Pending
-
-diff --git a/libvncserver/main.c b/libvncserver/main.c
-index b6bd930..8bbb7bf 100644
 a/libvncserver/main.c
-+++ b/libvncserver/main.c
-@@ -47,7 +47,7 @@ static MUTEX(extMutex);
- 
- static int rfbEnableLogging=1;
- 
--#ifdef LIBVNCSERVER_WORDS_BIGENDIAN
-+#ifdef WORDS_BIGENDIAN
- char rfbEndianTest = (1==0);
- #else
- char rfbEndianTest = (1==1);
-
diff --git a/meta/recipes-graphics/x11vnc/files/starting-fix.patch 
b/meta/recipes-graphics/x11vnc/files/starting-fix.patch
deleted file mode 100644
index f62e405..000
--- a/meta/recipes-graphics/x11vnc/files/starting-fix.patch
+++ /dev/null
@@ -1,25 +0,0 @@
-"-gui" & "-rfbport" require "wish" installed, or else x11vnc fails to start.
-Removing these 2 parameters makes x11vnc works well on poky sato image.
-
-Add also -skip_lockkeys option to ignore all Caps_Lock, Shift_Lock, Num_Lock,
-Scroll_Lock keysyms received from viewers, in order to leave the lock state on
-the server side unchanged. Yet, the keys will appear correctly.
-
-Signed-off-by: Zhai Edwin 
-Signed-off-by: Laurentiu Palcu 
-
-Upstream-Status: Inappropriate [configuration]
-
-Index: x11vnc-0.9.12/x11vnc/x11vnc.desktop
-===
 x11vnc-0.9.12.orig/x11vnc/x11vnc.desktop   2011-03-03 10:33:18.0 
+0800
-+++ x11vnc-0.9.12/x11vnc/x11vnc.desktop2011-03-03 10:35:20.0 
+0800
-@@ -1,7 +1,7 @@
- [Desktop Entry]
- Name=X11VNC Server
- Comment=Share this desktop by VNC
--Exec=x11vnc -gui tray=setpass -rfbport PROMPT -bg -o 
%%HOME/.x11vnc.log.%%VNCDISPLAY
-+Exec=x11vnc -bg -rfbport 5900 -skip_lockkeys -o 
%%HOME/.x11vnc.log.%%VNCDISPLAY
- Icon=computer
- Terminal=false
- Type=Application
diff --git a/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb 
b/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb
deleted file mode 100644
index ec0241f..000
--- a/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb
+++ /dev/null
@@ -1,25 +0,0 @@
-SUMMARY = "Exports your X session on-the-fly via VNC"
-HOMEPAGE = "http://www.karlrunge.com/x11vnc/;
-
-SECTION = "x11/utils"
-AUTHOR = "Karl Runge"
-LICENSE = "GPLv2+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f \
-
file://x11vnc/x11vnc.h;endline=33;md5=6f95dc6535467d7ee1563fd434fb372e"
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/libvncserver/x11vnc/${PV}/x11vnc-${PV}.tar.gz\
-   file://starting-fix.patch \
-   file://endian-fix.patch "
-
-SRC_URI[md5sum] = "a372ec4fe8211221547b1c108cf56e4c"
-SRC_URI[sha256sum] = 
"f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b"
-
-DEPENDS = "openssl virtual/libx11 libxext jpeg zlib libxfixes libxrandr 
libxdamage libxtst"
-
-inherit autotools-brokensep distro_features_check
-# depends on virtual/libx11
-REQUIRED_DISTRO_FEATURES = "x11"
-
-PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'zeroconf', 
'avahi', '', d)}"
-PACKAGECONFIG[avahi] = "--with-avahi,--without-avahi,avahi"
-PACKAGECONFIG[xinerama] = "--with-xinerama,--without-xinerama,libxinerama"
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Martin Jansa]

On Fri, Oct 16, 2015 at 08:40:10AM -0600, Gary Thomas wrote:
> On 2015-10-16 08:25, Ioan-Adrian Ratiu wrote:
> > x11vnc can be configured with --use-system-libvncserver to use an
> > external libvncserver which will be added to meta-oe. Since oe-core
> > should not depend on meta-oe, we move x11vnc there.
> >
> > Signed-off-by: Ioan-Adrian Ratiu 
> 
> Just curious why not the other way - move libvncserver to OE-core?
> x11vnc seems like one of the very few [and useful] X based tools that
> are present in OE-core that it seems like a huge step backwards to
> move it out.

It was discussed in "[OE-core] [oe] [meta-oe][PATCH v2] meta-oe:
recipes-graphics: add libvncserver recipe" thread and I agree with
Otavio that x11vnc doesn't look so fundamental component used by most
embedded builds to deserver being in the core.

-- 
Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com


signature.asc
Description: Digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Gary Thomas]

On 2015-10-16 08:25, Ioan-Adrian Ratiu wrote:

x11vnc can be configured with --use-system-libvncserver to use an
external libvncserver which will be added to meta-oe. Since oe-core
should not depend on meta-oe, we move x11vnc there.

Signed-off-by: Ioan-Adrian Ratiu 


Just curious why not the other way - move libvncserver to OE-core?
x11vnc seems like one of the very few [and useful] X based tools that
are present in OE-core that it seems like a huge step backwards to
move it out.

--

Gary Thomas |  Consulting for the
MLB Associates  |Embedded world

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] x11vnc: move recipe to meta-oe

[Otavio Salvador]

On Fri, Oct 16, 2015 at 12:41 PM, Gary Thomas  wrote:
> On 2015-10-16 09:29, Otavio Salvador wrote:
>>
>> On Fri, Oct 16, 2015 at 12:21 PM, Gary Thomas  wrote:
>>>
>>> On 2015-10-16 08:44, Martin Jansa wrote:


 On Fri, Oct 16, 2015 at 08:40:10AM -0600, Gary Thomas wrote:
>
>
> On 2015-10-16 08:25, Ioan-Adrian Ratiu wrote:
>>
>>
>> x11vnc can be configured with --use-system-libvncserver to use an
>> external libvncserver which will be added to meta-oe. Since oe-core
>> should not depend on meta-oe, we move x11vnc there.
>>
>> Signed-off-by: Ioan-Adrian Ratiu 
>
>
>
> Just curious why not the other way - move libvncserver to OE-core?
> x11vnc seems like one of the very few [and useful] X based tools that
> are present in OE-core that it seems like a huge step backwards to
> move it out.



 It was discussed in "[OE-core] [oe] [meta-oe][PATCH v2] meta-oe:
 recipes-graphics: add libvncserver recipe" thread and I agree with
 Otavio that x11vnc doesn't look so fundamental component used by most
 embedded builds to deserver being in the core.
>>>
>>>
>>> Well, I tend to disagree and I don't think there has really been a
>>> discussion - only one "no" (Otavio) and one "I don't know" (Paul).
>>
>>
>> The recipe being in meta-oe, can be used anyway. It is just out of
>> OE-Core.
>>
>> Anyway, what x11vnc has to provide to a core system? it even requires
>> X11 which a lot of embedded systems are moving away from...
>>
>
> Maybe for you, but not my customers - most of them insist on it.
>
> Yes, x11nvc in meta-oe is an answer, but I don't want to have to
> drag in meta-oe (way too heavy for my tastes) just to be able to
> use it (I use it all the time to debug customer systems that I only
> have remote access to)...
>
> Maybe we should abandon Python or GDB (server) from OE-core as they
> aren't used by all systems either??

Gary, I understand you use it a lot. Great.

But OE-Core should be trimmed, not extended. The recipes in OE-Core
ought to be used by a a lot of people or to provide a validation for
something.

Sorry but x11vnc does not provide either. If you don't want to bring
meta-oe, you can copy the recipe. But the size of meta-oe is not a
justification to keep something on OE-Core. Instead, it would be
better if you could help to split meta-oe more and it ultimately would
be smaller ;-)

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core