Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, 23 Feb 2019 at 23:30, Adrian Bunk wrote: > > Probably this is the very first time virgl is built for mips :-) > >... > > Builds fine in Debian: > https://buildd.debian.org/status/package.php?p=virglrenderer They don't apply special patches either: https://sources.debian.org/patches/virglrenderer/ Anyway, building it for mips is an academic exercise. There is no use case. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Fri, Feb 22, 2019 at 08:11:27PM +0100, Alexander Kanavin wrote: > Probably this is the very first time virgl is built for mips :-) >... Builds fine in Debian: https://buildd.debian.org/status/package.php?p=virglrenderer > Alex cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, 2019-02-23 at 11:57 -0800, Khem Raj wrote: > On Sat, Feb 23, 2019 at 10:07 AM Richard Purdie > wrote: > > On Sat, 2019-02-23 at 09:56 -0800, Khem Raj wrote: > > > On Fri, Feb 22, 2019 at 11:11 AM Alexander Kanavin > > > wrote: > > > > Probably this is the very first time virgl is built for mips :- > > > > ) > > > > > > > > Note that it is useful only if you intend to run qemu on that > > > > platform, so I wonder if we could just blacklist it... > > > > > > > > > > I would have thought world build should have caught it on AB for > > > mips. > > > Which tells me it could be > > > musl+mips specific > > > > The AB does not run world builds for everything. It does them for > > musl+ > > qemux86, musl+qemux86-64, qemux86, qemux86-lsb and no-x11 if I > > recall > > correctly. > > Thats right, I meant to say mips/glibc world builds, I think they are > run regularly and should have caught it if it was mips specific and > musl builds should have caught it if it was musl specific, so its > probably a combination musl+mips which causes this My list above doesn't include mips world, I don't think we test that. We come close with some of our big images but I don't think we test world. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, Feb 23, 2019 at 10:07 AM Richard Purdie wrote: > > On Sat, 2019-02-23 at 09:56 -0800, Khem Raj wrote: > > On Fri, Feb 22, 2019 at 11:11 AM Alexander Kanavin > > wrote: > > > Probably this is the very first time virgl is built for mips :-) > > > > > > Note that it is useful only if you intend to run qemu on that > > > platform, so I wonder if we could just blacklist it... > > > > > > > I would have thought world build should have caught it on AB for > > mips. > > Which tells me it could be > > musl+mips specific > > The AB does not run world builds for everything. It does them for musl+ > qemux86, musl+qemux86-64, qemux86, qemux86-lsb and no-x11 if I recall > correctly. Thats right, I meant to say mips/glibc world builds, I think they are run regularly and should have caught it if it was mips specific and musl builds should have caught it if it was musl specific, so its probably a combination musl+mips which causes this > > Cheers, > > Richard > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, 2019-02-23 at 09:56 -0800, Khem Raj wrote: > On Fri, Feb 22, 2019 at 11:11 AM Alexander Kanavin > wrote: > > Probably this is the very first time virgl is built for mips :-) > > > > Note that it is useful only if you intend to run qemu on that > > platform, so I wonder if we could just blacklist it... > > > > I would have thought world build should have caught it on AB for > mips. > Which tells me it could be > musl+mips specific The AB does not run world builds for everything. It does them for musl+ qemux86, musl+qemux86-64, qemux86, qemux86-lsb and no-x11 if I recall correctly. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Fri, Feb 22, 2019 at 11:11 AM Alexander Kanavin wrote: > > Probably this is the very first time virgl is built for mips :-) > > Note that it is useful only if you intend to run qemu on that > platform, so I wonder if we could just blacklist it... > I would have thought world build should have caught it on AB for mips. Which tells me it could be musl+mips specific > Alex > > On Fri, 22 Feb 2019 at 19:54, Khem Raj wrote: > > > > https://errors.yoctoproject.org/Errors/Details/229902/ > > > > mips/glibc > > > > On Fri, Feb 22, 2019 at 6:34 AM Alexander Kanavin > > wrote: > > > > > > This component enables hardware-accelerated GL inside QEMU guests. > > > For more information, see here: > > > > > > https://lwn.net/Articles/767970/ > > > https://www.collabora.com/news-and-blog/blog/2018/02/12/virtualizing-gpu-access/ > > > https://www.collabora.com/news-and-blog/blog/2018/05/09/gpu-virtualization-update/ > > > > > > Signed-off-by: Alexander Kanavin > > > --- > > > meta/conf/distro/include/maintainers.inc | 1 + > > > ...efile.am-explicitly-link-with-libdrm.patch | 31 +++ > > > .../0001-vtest-add-missing-includes.patch | 38 +++ > > > .../virglrenderer/virglrenderer_0.7.0.bb | 19 ++ > > > 4 files changed, 89 insertions(+) > > > create mode 100644 > > > meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > > create mode 100644 > > > meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > > create mode 100644 > > > meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb > > > > > > diff --git a/meta/conf/distro/include/maintainers.inc > > > b/meta/conf/distro/include/maintainers.inc > > > index 4e3fc103afc..f5e6343904b 100644 > > > --- a/meta/conf/distro/include/maintainers.inc > > > +++ b/meta/conf/distro/include/maintainers.inc > > > @@ -700,6 +700,7 @@ RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster > > > " > > > RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin " > > > RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin " > > > RECIPE_MAINTAINER_pn-valgrind = "Alexander Kanavin > > > " > > > +RECIPE_MAINTAINER_pn-virglrenderer = "Alexander Kanavin > > > " > > > RECIPE_MAINTAINER_pn-volatile-binds = "Chen Qi " > > > RECIPE_MAINTAINER_pn-vte = "Anuj Mittal " > > > RECIPE_MAINTAINER_pn-vulkan = "Ross Burton " > > > diff --git > > > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > > > > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > > new file mode 100644 > > > index 000..aa8d814845e > > > --- /dev/null > > > +++ > > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > > @@ -0,0 +1,31 @@ > > > +From d61f7073b8ce159d21811b291c22b273b040c330 Mon Sep 17 00:00:00 2001 > > > +From: Alexander Kanavin > > > +Date: Tue, 12 Feb 2019 12:04:52 +0100 > > > +Subject: [PATCH] Makefile.am: explicitly link with libdrm > > > + > > > +Otherwise, a failure happens with gold linker: > > > + > > > +../src/.libs/libvirglrenderer.so: error: undefined reference to > > > 'drmPrimeHandleToFD' > > > + > > > +https://errors.yoctoproject.org/Errors/Details/222046/ > > > + > > > +Upstream-Status: Accepted > > > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/153] > > > +Signed-off-by: Alexander Kanavin > > > +--- > > > + src/Makefile.am | 1 + > > > + 1 file changed, 1 insertion(+) > > > + > > > +diff --git a/src/Makefile.am b/src/Makefile.am > > > +index 9a0a44e..9b668c8 100644 > > > +--- a/src/Makefile.am > > > b/src/Makefile.am > > > +@@ -1,5 +1,6 @@ > > > + SUBDIRS := gallium/auxiliary > > > + AM_LDFLAGS = -lm \ > > > ++ $(LIBDRM_LIBS) \ > > > + $(GBM_LIBS) \ > > > + $(EPOXY_LIBS) \ > > > + $(X11_LIBS) \ > > > +-- > > > +2.17.1 > > > + > > > diff --git > > > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > > > > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > > new file mode 100644 > > > index 000..2b4ffa932de > > > --- /dev/null > > > +++ > > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > > @@ -0,0 +1,38 @@ > > > +From 05c5c5f43fbffb3317bd9da27d414890d2ef493c Mon Sep 17 00:00:00 2001 > > > +From: Alexander Kanavin > > > +Date: Fri, 18 Jan 2019 13:47:23 +0100 > > > +Subject: [PATCH] vtest: add missing includes > > > + > > > +This fixes build failures with musl C library > > > + > > > +Upstream-Status: Accepted > > > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/125] > > > +Signed-off-by: Alexander Kanavin > > > +--- > > > + vtest/util.c | 1 + > > > + vtest/vtest_server.c | 1 + > > > + 2 files changed, 2 insertions(+) > > > + > > > +diff --git a/vtest/util.c
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
Probably this is the very first time virgl is built for mips :-) Note that it is useful only if you intend to run qemu on that platform, so I wonder if we could just blacklist it... Alex On Fri, 22 Feb 2019 at 19:54, Khem Raj wrote: > > https://errors.yoctoproject.org/Errors/Details/229902/ > > mips/glibc > > On Fri, Feb 22, 2019 at 6:34 AM Alexander Kanavin > wrote: > > > > This component enables hardware-accelerated GL inside QEMU guests. > > For more information, see here: > > > > https://lwn.net/Articles/767970/ > > https://www.collabora.com/news-and-blog/blog/2018/02/12/virtualizing-gpu-access/ > > https://www.collabora.com/news-and-blog/blog/2018/05/09/gpu-virtualization-update/ > > > > Signed-off-by: Alexander Kanavin > > --- > > meta/conf/distro/include/maintainers.inc | 1 + > > ...efile.am-explicitly-link-with-libdrm.patch | 31 +++ > > .../0001-vtest-add-missing-includes.patch | 38 +++ > > .../virglrenderer/virglrenderer_0.7.0.bb | 19 ++ > > 4 files changed, 89 insertions(+) > > create mode 100644 > > meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > create mode 100644 > > meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > create mode 100644 > > meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb > > > > diff --git a/meta/conf/distro/include/maintainers.inc > > b/meta/conf/distro/include/maintainers.inc > > index 4e3fc103afc..f5e6343904b 100644 > > --- a/meta/conf/distro/include/maintainers.inc > > +++ b/meta/conf/distro/include/maintainers.inc > > @@ -700,6 +700,7 @@ RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster > > " > > RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin " > > RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin " > > RECIPE_MAINTAINER_pn-valgrind = "Alexander Kanavin > > " > > +RECIPE_MAINTAINER_pn-virglrenderer = "Alexander Kanavin > > " > > RECIPE_MAINTAINER_pn-volatile-binds = "Chen Qi " > > RECIPE_MAINTAINER_pn-vte = "Anuj Mittal " > > RECIPE_MAINTAINER_pn-vulkan = "Ross Burton " > > diff --git > > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > new file mode 100644 > > index 000..aa8d814845e > > --- /dev/null > > +++ > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > @@ -0,0 +1,31 @@ > > +From d61f7073b8ce159d21811b291c22b273b040c330 Mon Sep 17 00:00:00 2001 > > +From: Alexander Kanavin > > +Date: Tue, 12 Feb 2019 12:04:52 +0100 > > +Subject: [PATCH] Makefile.am: explicitly link with libdrm > > + > > +Otherwise, a failure happens with gold linker: > > + > > +../src/.libs/libvirglrenderer.so: error: undefined reference to > > 'drmPrimeHandleToFD' > > + > > +https://errors.yoctoproject.org/Errors/Details/222046/ > > + > > +Upstream-Status: Accepted > > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/153] > > +Signed-off-by: Alexander Kanavin > > +--- > > + src/Makefile.am | 1 + > > + 1 file changed, 1 insertion(+) > > + > > +diff --git a/src/Makefile.am b/src/Makefile.am > > +index 9a0a44e..9b668c8 100644 > > +--- a/src/Makefile.am > > b/src/Makefile.am > > +@@ -1,5 +1,6 @@ > > + SUBDIRS := gallium/auxiliary > > + AM_LDFLAGS = -lm \ > > ++ $(LIBDRM_LIBS) \ > > + $(GBM_LIBS) \ > > + $(EPOXY_LIBS) \ > > + $(X11_LIBS) \ > > +-- > > +2.17.1 > > + > > diff --git > > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > new file mode 100644 > > index 000..2b4ffa932de > > --- /dev/null > > +++ > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > @@ -0,0 +1,38 @@ > > +From 05c5c5f43fbffb3317bd9da27d414890d2ef493c Mon Sep 17 00:00:00 2001 > > +From: Alexander Kanavin > > +Date: Fri, 18 Jan 2019 13:47:23 +0100 > > +Subject: [PATCH] vtest: add missing includes > > + > > +This fixes build failures with musl C library > > + > > +Upstream-Status: Accepted > > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/125] > > +Signed-off-by: Alexander Kanavin > > +--- > > + vtest/util.c | 1 + > > + vtest/vtest_server.c | 1 + > > + 2 files changed, 2 insertions(+) > > + > > +diff --git a/vtest/util.c b/vtest/util.c > > +index 0d3c78f..c605253 100644 > > +--- a/vtest/util.c > > b/vtest/util.c > > +@@ -26,6 +26,7 @@ > > + #include > > + #include > > + #include > > ++#include > > + > > + int vtest_wait_for_fd_read(int fd) > > + { > > +diff --git a/vtest/vtest_server.c b/vtest/vtest_server.c > > +index bc6c95f..010721f 100644 > > +--- a/vtest/vtest_server.c > > b/vtest/vtest_server.c > > +@@ -31,6 +31,7 @@ > >
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
https://errors.yoctoproject.org/Errors/Details/229902/ mips/glibc On Fri, Feb 22, 2019 at 6:34 AM Alexander Kanavin wrote: > > This component enables hardware-accelerated GL inside QEMU guests. > For more information, see here: > > https://lwn.net/Articles/767970/ > https://www.collabora.com/news-and-blog/blog/2018/02/12/virtualizing-gpu-access/ > https://www.collabora.com/news-and-blog/blog/2018/05/09/gpu-virtualization-update/ > > Signed-off-by: Alexander Kanavin > --- > meta/conf/distro/include/maintainers.inc | 1 + > ...efile.am-explicitly-link-with-libdrm.patch | 31 +++ > .../0001-vtest-add-missing-includes.patch | 38 +++ > .../virglrenderer/virglrenderer_0.7.0.bb | 19 ++ > 4 files changed, 89 insertions(+) > create mode 100644 > meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > create mode 100644 > meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb > > diff --git a/meta/conf/distro/include/maintainers.inc > b/meta/conf/distro/include/maintainers.inc > index 4e3fc103afc..f5e6343904b 100644 > --- a/meta/conf/distro/include/maintainers.inc > +++ b/meta/conf/distro/include/maintainers.inc > @@ -700,6 +700,7 @@ RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster > " > RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin " > RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin " > RECIPE_MAINTAINER_pn-valgrind = "Alexander Kanavin " > +RECIPE_MAINTAINER_pn-virglrenderer = "Alexander Kanavin > " > RECIPE_MAINTAINER_pn-volatile-binds = "Chen Qi " > RECIPE_MAINTAINER_pn-vte = "Anuj Mittal " > RECIPE_MAINTAINER_pn-vulkan = "Ross Burton " > diff --git > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > new file mode 100644 > index 000..aa8d814845e > --- /dev/null > +++ > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch > @@ -0,0 +1,31 @@ > +From d61f7073b8ce159d21811b291c22b273b040c330 Mon Sep 17 00:00:00 2001 > +From: Alexander Kanavin > +Date: Tue, 12 Feb 2019 12:04:52 +0100 > +Subject: [PATCH] Makefile.am: explicitly link with libdrm > + > +Otherwise, a failure happens with gold linker: > + > +../src/.libs/libvirglrenderer.so: error: undefined reference to > 'drmPrimeHandleToFD' > + > +https://errors.yoctoproject.org/Errors/Details/222046/ > + > +Upstream-Status: Accepted > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/153] > +Signed-off-by: Alexander Kanavin > +--- > + src/Makefile.am | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/src/Makefile.am b/src/Makefile.am > +index 9a0a44e..9b668c8 100644 > +--- a/src/Makefile.am > b/src/Makefile.am > +@@ -1,5 +1,6 @@ > + SUBDIRS := gallium/auxiliary > + AM_LDFLAGS = -lm \ > ++ $(LIBDRM_LIBS) \ > + $(GBM_LIBS) \ > + $(EPOXY_LIBS) \ > + $(X11_LIBS) \ > +-- > +2.17.1 > + > diff --git > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > new file mode 100644 > index 000..2b4ffa932de > --- /dev/null > +++ > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > @@ -0,0 +1,38 @@ > +From 05c5c5f43fbffb3317bd9da27d414890d2ef493c Mon Sep 17 00:00:00 2001 > +From: Alexander Kanavin > +Date: Fri, 18 Jan 2019 13:47:23 +0100 > +Subject: [PATCH] vtest: add missing includes > + > +This fixes build failures with musl C library > + > +Upstream-Status: Accepted > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/125] > +Signed-off-by: Alexander Kanavin > +--- > + vtest/util.c | 1 + > + vtest/vtest_server.c | 1 + > + 2 files changed, 2 insertions(+) > + > +diff --git a/vtest/util.c b/vtest/util.c > +index 0d3c78f..c605253 100644 > +--- a/vtest/util.c > b/vtest/util.c > +@@ -26,6 +26,7 @@ > + #include > + #include > + #include > ++#include > + > + int vtest_wait_for_fd_read(int fd) > + { > +diff --git a/vtest/vtest_server.c b/vtest/vtest_server.c > +index bc6c95f..010721f 100644 > +--- a/vtest/vtest_server.c > b/vtest/vtest_server.c > +@@ -31,6 +31,7 @@ > + #include > + #include > + #include > ++#include > + > + #include "util.h" > + #include "vtest.h" > diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb > b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb > new file mode 100644 > index 000..500ed4f2d8b > --- /dev/null > +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb > @@ -0,0 +1,19 @@ > +SUMMARY = "VirGL virtual OpenGL renderer" > +HOMEPAGE = "https://virgil3d.github.io/; > + > +LICENSE
[OE-core] [PATCH 01/12] virglrenderer: add a recipe
This component enables hardware-accelerated GL inside QEMU guests. For more information, see here: https://lwn.net/Articles/767970/ https://www.collabora.com/news-and-blog/blog/2018/02/12/virtualizing-gpu-access/ https://www.collabora.com/news-and-blog/blog/2018/05/09/gpu-virtualization-update/ Signed-off-by: Alexander Kanavin --- meta/conf/distro/include/maintainers.inc | 1 + ...efile.am-explicitly-link-with-libdrm.patch | 31 +++ .../0001-vtest-add-missing-includes.patch | 38 +++ .../virglrenderer/virglrenderer_0.7.0.bb | 19 ++ 4 files changed, 89 insertions(+) create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 4e3fc103afc..f5e6343904b 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -700,6 +700,7 @@ RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster " RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin " RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin " RECIPE_MAINTAINER_pn-valgrind = "Alexander Kanavin " +RECIPE_MAINTAINER_pn-virglrenderer = "Alexander Kanavin " RECIPE_MAINTAINER_pn-volatile-binds = "Chen Qi " RECIPE_MAINTAINER_pn-vte = "Anuj Mittal " RECIPE_MAINTAINER_pn-vulkan = "Ross Burton " diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch new file mode 100644 index 000..aa8d814845e --- /dev/null +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Makefile.am-explicitly-link-with-libdrm.patch @@ -0,0 +1,31 @@ +From d61f7073b8ce159d21811b291c22b273b040c330 Mon Sep 17 00:00:00 2001 +From: Alexander Kanavin +Date: Tue, 12 Feb 2019 12:04:52 +0100 +Subject: [PATCH] Makefile.am: explicitly link with libdrm + +Otherwise, a failure happens with gold linker: + +../src/.libs/libvirglrenderer.so: error: undefined reference to 'drmPrimeHandleToFD' + +https://errors.yoctoproject.org/Errors/Details/222046/ + +Upstream-Status: Accepted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/153] +Signed-off-by: Alexander Kanavin +--- + src/Makefile.am | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/src/Makefile.am b/src/Makefile.am +index 9a0a44e..9b668c8 100644 +--- a/src/Makefile.am b/src/Makefile.am +@@ -1,5 +1,6 @@ + SUBDIRS := gallium/auxiliary + AM_LDFLAGS = -lm \ ++ $(LIBDRM_LIBS) \ + $(GBM_LIBS) \ + $(EPOXY_LIBS) \ + $(X11_LIBS) \ +-- +2.17.1 + diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch new file mode 100644 index 000..2b4ffa932de --- /dev/null +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch @@ -0,0 +1,38 @@ +From 05c5c5f43fbffb3317bd9da27d414890d2ef493c Mon Sep 17 00:00:00 2001 +From: Alexander Kanavin +Date: Fri, 18 Jan 2019 13:47:23 +0100 +Subject: [PATCH] vtest: add missing includes + +This fixes build failures with musl C library + +Upstream-Status: Accepted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/125] +Signed-off-by: Alexander Kanavin +--- + vtest/util.c | 1 + + vtest/vtest_server.c | 1 + + 2 files changed, 2 insertions(+) + +diff --git a/vtest/util.c b/vtest/util.c +index 0d3c78f..c605253 100644 +--- a/vtest/util.c b/vtest/util.c +@@ -26,6 +26,7 @@ + #include + #include + #include ++#include + + int vtest_wait_for_fd_read(int fd) + { +diff --git a/vtest/vtest_server.c b/vtest/vtest_server.c +index bc6c95f..010721f 100644 +--- a/vtest/vtest_server.c b/vtest/vtest_server.c +@@ -31,6 +31,7 @@ + #include + #include + #include ++#include + + #include "util.h" + #include "vtest.h" diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb new file mode 100644 index 000..500ed4f2d8b --- /dev/null +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb @@ -0,0 +1,19 @@ +SUMMARY = "VirGL virtual OpenGL renderer" +HOMEPAGE = "https://virgil3d.github.io/; + +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://COPYING;md5=c81c08eeefd9418fca8f88309a76db10" + +DEPENDS = "libdrm mesa libepoxy" +SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c" +SRC_URI = "git://anongit.freedesktop.org/virglrenderer \ + file://0001-vtest-add-missing-includes.patch \ + file://0001-Makefile.am-explicitly-link-with-libdrm.patch \ + " + +S = "${WORKDIR}/git"
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
Anyway, I sent it upstream: https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/153 and added to my branch on poky-contrib. http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=akanavin/virgl-gtk Alex On Mon, 11 Feb 2019 at 16:24, Khem Raj wrote: > > here is a build failure with -fuse-ld=gold > > https://errors.yoctoproject.org/Errors/Details/222046/ > > On Sat, Feb 9, 2019 at 9:23 AM Khem Raj wrote: > > > > dump ld.bfd generated .so and see if this symbol is present > > > > On Sat, Feb 9, 2019 at 5:20 AM Martin Jansa wrote: > > > > > > On Sat, Feb 09, 2019 at 11:06:47AM +0100, Alexander Kanavin wrote: > > > > On Sat, 9 Feb 2019 at 10:44, Martin Jansa > > > > wrote: > > > > > Does it need to depend on mesa directly instead of one of virtual/* > > > > > providers? > > > > > > > > > > It fails to build for targets which use different mesa, e.g. mesa-gl: > > > > > > > > > > ERROR: Nothing PROVIDES 'mesa' (but > > > > > /OE/build/luneos-master/webos-ports/openembedded-core/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > > > > > DEPENDS on or otherwise requires it) > > > > > mesa was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa-gl, > > > > > not mesa > > > > > ERROR: Required build target 'virglrenderer' has no buildable > > > > > providers. > > > > > Missing or unbuildable dependency chain was: ['virglrenderer', 'mesa'] > > > > > > > > Yes, mesa-gl isn't going to work. Virgl needs the following bits (set > > > > in mesa recipe): > > > > PACKAGECONFIG_class-native ?= "gbm dri-native egl" > > > > > > > > dri-native is same as dri, but without drivers to save build time. > > > > > > OK, then with mesa used in qemux86* it still fails with: > > > > > > | Making all in vtest > > > | make[2]: Entering directory > > > '/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/build/vtest' > > > | i586-webos-linux-gcc -m32 -march=i586 > > > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > > > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > > > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > > > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > > > -I../../git/include -I../../git/src > > > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > > > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > > > -feliminate-unused-debug-types > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586- webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o util.o ../../git/vtest/util.c > > > | i586-webos-linux-gcc -m32 -march=i586 > > > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > > > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > > > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > > > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > > > -I../../git/include -I../../git/src > > > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > > > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > > > -feliminate-unused-debug-types > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586- webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o vtest_server.o ../../git/vtest/vtest_server.c > > > | i586-webos-linux-gcc -m32 -march=i586 > > > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > > > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > > > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > > > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > > > -I../../git/include -I../../git/src > > >
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
here is a build failure with -fuse-ld=gold https://errors.yoctoproject.org/Errors/Details/222046/ On Sat, Feb 9, 2019 at 9:23 AM Khem Raj wrote: > > dump ld.bfd generated .so and see if this symbol is present > > On Sat, Feb 9, 2019 at 5:20 AM Martin Jansa wrote: > > > > On Sat, Feb 09, 2019 at 11:06:47AM +0100, Alexander Kanavin wrote: > > > On Sat, 9 Feb 2019 at 10:44, Martin Jansa wrote: > > > > Does it need to depend on mesa directly instead of one of virtual/* > > > > providers? > > > > > > > > It fails to build for targets which use different mesa, e.g. mesa-gl: > > > > > > > > ERROR: Nothing PROVIDES 'mesa' (but > > > > /OE/build/luneos-master/webos-ports/openembedded-core/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > > > > DEPENDS on or otherwise requires it) > > > > mesa was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa-gl, not > > > > mesa > > > > ERROR: Required build target 'virglrenderer' has no buildable providers. > > > > Missing or unbuildable dependency chain was: ['virglrenderer', 'mesa'] > > > > > > Yes, mesa-gl isn't going to work. Virgl needs the following bits (set > > > in mesa recipe): > > > PACKAGECONFIG_class-native ?= "gbm dri-native egl" > > > > > > dri-native is same as dri, but without drivers to save build time. > > > > OK, then with mesa used in qemux86* it still fails with: > > > > | Making all in vtest > > | make[2]: Entering directory > > '/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/build/vtest' > > | i586-webos-linux-gcc -m32 -march=i586 > > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > > -I../../git/include -I../../git/src > > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > > -feliminate-unused-debug-types > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-we bos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o util.o ../../git/vtest/util.c > > | i586-webos-linux-gcc -m32 -march=i586 > > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > > -I../../git/include -I../../git/src > > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > > -feliminate-unused-debug-types > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-we bos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o vtest_server.o ../../git/vtest/vtest_server.c > > | i586-webos-linux-gcc -m32 -march=i586 > > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > > -I../../git/include -I../../git/src > > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > > -feliminate-unused-debug-types > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > > >
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
dump ld.bfd generated .so and see if this symbol is present On Sat, Feb 9, 2019 at 5:20 AM Martin Jansa wrote: > > On Sat, Feb 09, 2019 at 11:06:47AM +0100, Alexander Kanavin wrote: > > On Sat, 9 Feb 2019 at 10:44, Martin Jansa wrote: > > > Does it need to depend on mesa directly instead of one of virtual/* > > > providers? > > > > > > It fails to build for targets which use different mesa, e.g. mesa-gl: > > > > > > ERROR: Nothing PROVIDES 'mesa' (but > > > /OE/build/luneos-master/webos-ports/openembedded-core/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > > > DEPENDS on or otherwise requires it) > > > mesa was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa-gl, not > > > mesa > > > ERROR: Required build target 'virglrenderer' has no buildable providers. > > > Missing or unbuildable dependency chain was: ['virglrenderer', 'mesa'] > > > > Yes, mesa-gl isn't going to work. Virgl needs the following bits (set > > in mesa recipe): > > PACKAGECONFIG_class-native ?= "gbm dri-native egl" > > > > dri-native is same as dri, but without drivers to save build time. > > OK, then with mesa used in qemux86* it still fails with: > > | Making all in vtest > | make[2]: Entering directory > '/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/build/vtest' > | i586-webos-linux-gcc -m32 -march=i586 > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > -I../../git/include -I../../git/src > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > -feliminate-unused-debug-types > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webo s-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o util.o ../../git/vtest/util.c > | i586-webos-linux-gcc -m32 -march=i586 > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > -I../../git/include -I../../git/src > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > -feliminate-unused-debug-types > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webo s-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o vtest_server.o ../../git/vtest/vtest_server.c > | i586-webos-linux-gcc -m32 -march=i586 > --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot > -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. > -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include > -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers > -I../../git/include -I../../git/src > -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm > -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g > -feliminate-unused-debug-types > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= > > -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webo s-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, 9 Feb 2019 at 18:10, Martin Jansa wrote: > > It was sent to upstream (somewhere) by the original author, I haven't found > it on gitlab, so I've asked original author in: > https://bugs.gentoo.org/571124#c5 Maybe a new merge request is the quickest way to sort this. The patch was probably sent to the virgl mailing list or privately to airlied years ago and fell through. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
It was sent to upstream (somewhere) by the original author, I haven't found it on gitlab, so I've asked original author in: https://bugs.gentoo.org/571124#c5 Plain poky probably doesn't use gold, that's why you're not seeing it there. On Sat, Feb 9, 2019 at 5:43 PM Alexander Kanavin wrote: > On Sat, 9 Feb 2019 at 14:19, Martin Jansa wrote: > > The fix from > > > http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/qemu=c29d4ccfe0a5f53c49883e55c2c2bb444997b1cf > > is still applicable and fixes this. > > Somehow the issue does not show up in plain poky, but the fix seems > right. Can you send it upstream via > https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests > please? > > Alex > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, 9 Feb 2019 at 14:19, Martin Jansa wrote: > The fix from > http://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/qemu=c29d4ccfe0a5f53c49883e55c2c2bb444997b1cf > is still applicable and fixes this. Somehow the issue does not show up in plain poky, but the fix seems right. Can you send it upstream via https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests please? Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, Feb 09, 2019 at 11:06:47AM +0100, Alexander Kanavin wrote: > On Sat, 9 Feb 2019 at 10:44, Martin Jansa wrote: > > Does it need to depend on mesa directly instead of one of virtual/* > > providers? > > > > It fails to build for targets which use different mesa, e.g. mesa-gl: > > > > ERROR: Nothing PROVIDES 'mesa' (but > > /OE/build/luneos-master/webos-ports/openembedded-core/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > > DEPENDS on or otherwise requires it) > > mesa was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa-gl, not mesa > > ERROR: Required build target 'virglrenderer' has no buildable providers. > > Missing or unbuildable dependency chain was: ['virglrenderer', 'mesa'] > > Yes, mesa-gl isn't going to work. Virgl needs the following bits (set > in mesa recipe): > PACKAGECONFIG_class-native ?= "gbm dri-native egl" > > dri-native is same as dri, but without drivers to save build time. OK, then with mesa used in qemux86* it still fails with: | Making all in vtest | make[2]: Entering directory '/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/build/vtest' | i586-webos-linux-gcc -m32 -march=i586 --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers -I../../git/include -I../../git/src -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g -feliminate-unused-debug-types -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o util.o ../../git/vtest/util.c | i586-webos-linux-gcc -m32 -march=i586 --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers -I../../git/include -I../../git/src -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g -feliminate-unused-debug-types -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o vtest_server.o ../../git/vtest/vtest_server.c | i586-webos-linux-gcc -m32 -march=i586 --sysroot=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot -DHAVE_CONFIG_H -I. -I../../git/vtest -I.. -I../../git/src/gallium/drivers/virgl -I../../git/src/gallium/include -I../../git/src/gallium/auxiliary -I../../git/src/gallium/drivers -I../../git/include -I../../git/src -I/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot/usr/include/libdrm -DMESA_EGL_NO_X11_HEADERS -O -fno-omit-frame-pointer -g -feliminate-unused-debug-types -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0=/usr/src/debug/virglrenderer/0.7.0-r0 -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot= -fdebug-prefix-map=/OE/build/luneos-master/webos-ports/tmp-glibc/work/i586-webos-linux/virglrenderer/0.7.0-r0/recipe-sysroot-native= -pipe -Wall -Wextra -Werror=implicit-function-declaration -Werror=missing-prototypes -Wmissing-prototypes -Werror=int-to-pointer-cast -c -o vtest_renderer.o ../../git/vtest/vtest_renderer.c | ../i586-webos-linux-libtool --tag=CC --mode=link i586-webos-linux-gcc -m32 -march=i586
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Sat, 9 Feb 2019 at 10:44, Martin Jansa wrote: > Does it need to depend on mesa directly instead of one of virtual/* > providers? > > It fails to build for targets which use different mesa, e.g. mesa-gl: > > ERROR: Nothing PROVIDES 'mesa' (but > /OE/build/luneos-master/webos-ports/openembedded-core/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > DEPENDS on or otherwise requires it) > mesa was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa-gl, not mesa > ERROR: Required build target 'virglrenderer' has no buildable providers. > Missing or unbuildable dependency chain was: ['virglrenderer', 'mesa'] Yes, mesa-gl isn't going to work. Virgl needs the following bits (set in mesa recipe): PACKAGECONFIG_class-native ?= "gbm dri-native egl" dri-native is same as dri, but without drivers to save build time. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 01/12] virglrenderer: add a recipe
On Fri, Feb 08, 2019 at 03:45:42PM +0100, Alexander Kanavin wrote: > This component enables hardware-accelerated GL inside QEMU guests. > For more information, see here: > > https://lwn.net/Articles/767970/ > https://www.collabora.com/news-and-blog/blog/2018/02/12/virtualizing-gpu-access/ > https://www.collabora.com/news-and-blog/blog/2018/05/09/gpu-virtualization-update/ > > Signed-off-by: Alexander Kanavin > --- > meta/conf/distro/include/maintainers.inc | 1 + > .../0001-vtest-add-missing-includes.patch | 38 +++ > .../virglrenderer/virglrenderer_git.bb| 19 ++ > 3 files changed, 58 insertions(+) > create mode 100644 > meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > > diff --git a/meta/conf/distro/include/maintainers.inc > b/meta/conf/distro/include/maintainers.inc > index 122fdbcff4b..f7d43d20b7f 100644 > --- a/meta/conf/distro/include/maintainers.inc > +++ b/meta/conf/distro/include/maintainers.inc > @@ -700,6 +700,7 @@ RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster > " > RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin " > RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin " > RECIPE_MAINTAINER_pn-valgrind = "Alexander Kanavin " > +RECIPE_MAINTAINER_pn-virglrenderer = "Alexander Kanavin > " > RECIPE_MAINTAINER_pn-volatile-binds = "Chen Qi " > RECIPE_MAINTAINER_pn-vte = "Anuj Mittal " > RECIPE_MAINTAINER_pn-vulkan = "Ross Burton " > diff --git > a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > new file mode 100644 > index 000..b565c48ee66 > --- /dev/null > +++ > b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch > @@ -0,0 +1,38 @@ > +From 05c5c5f43fbffb3317bd9da27d414890d2ef493c Mon Sep 17 00:00:00 2001 > +From: Alexander Kanavin > +Date: Fri, 18 Jan 2019 13:47:23 +0100 > +Subject: [PATCH] vtest: add missing includes > + > +This fixes build failures with musl C library > + > +Upstream-Status: Submitted > [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/125] > +Signed-off-by: Alexander Kanavin > +--- > + vtest/util.c | 1 + > + vtest/vtest_server.c | 1 + > + 2 files changed, 2 insertions(+) > + > +diff --git a/vtest/util.c b/vtest/util.c > +index 0d3c78f..c605253 100644 > +--- a/vtest/util.c > b/vtest/util.c > +@@ -26,6 +26,7 @@ > + #include > + #include > + #include > ++#include > + > + int vtest_wait_for_fd_read(int fd) > + { > +diff --git a/vtest/vtest_server.c b/vtest/vtest_server.c > +index bc6c95f..010721f 100644 > +--- a/vtest/vtest_server.c > b/vtest/vtest_server.c > +@@ -31,6 +31,7 @@ > + #include > + #include > + #include > ++#include > + > + #include "util.h" > + #include "vtest.h" > diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > b/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > new file mode 100644 > index 000..93fc35feb8d > --- /dev/null > +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb > @@ -0,0 +1,19 @@ > +SUMMARY = "VirGL virtual OpenGL renderer" > +HOMEPAGE = "https://virgil3d.github.io/; > + > +LICENSE = "MIT" > +LIC_FILES_CHKSUM = "file://COPYING;md5=c81c08eeefd9418fca8f88309a76db10" > + > +DEPENDS = "libdrm mesa libepoxy" Does it need to depend on mesa directly instead of one of virtual/* providers? It fails to build for targets which use different mesa, e.g. mesa-gl: ERROR: Nothing PROVIDES 'mesa' (but /OE/build/luneos-master/webos-ports/openembedded-core/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb DEPENDS on or otherwise requires it) mesa was skipped: PREFERRED_PROVIDER_virtual/libgl set to mesa-gl, not mesa ERROR: Required build target 'virglrenderer' has no buildable providers. Missing or unbuildable dependency chain was: ['virglrenderer', 'mesa'] Regards, > +PV = "0.7.0" > +SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c" > +SRC_URI = "git://anongit.freedesktop.org/virglrenderer \ > + file://0001-vtest-add-missing-includes.patch \ > + " > + > +S = "${WORKDIR}/git" > + > +inherit autotools pkgconfig > + > +BBCLASSEXTEND = "native nativesdk" > + > -- > 2.17.1 > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 01/12] virglrenderer: add a recipe
This component enables hardware-accelerated GL inside QEMU guests. For more information, see here: https://lwn.net/Articles/767970/ https://www.collabora.com/news-and-blog/blog/2018/02/12/virtualizing-gpu-access/ https://www.collabora.com/news-and-blog/blog/2018/05/09/gpu-virtualization-update/ Signed-off-by: Alexander Kanavin --- meta/conf/distro/include/maintainers.inc | 1 + .../0001-vtest-add-missing-includes.patch | 38 +++ .../virglrenderer/virglrenderer_git.bb| 19 ++ 3 files changed, 58 insertions(+) create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer_git.bb diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc index 122fdbcff4b..f7d43d20b7f 100644 --- a/meta/conf/distro/include/maintainers.inc +++ b/meta/conf/distro/include/maintainers.inc @@ -700,6 +700,7 @@ RECIPE_MAINTAINER_pn-util-macros = "Armin Kuster " RECIPE_MAINTAINER_pn-v86d = "Alexander Kanavin " RECIPE_MAINTAINER_pn-vala = "Alexander Kanavin " RECIPE_MAINTAINER_pn-valgrind = "Alexander Kanavin " +RECIPE_MAINTAINER_pn-virglrenderer = "Alexander Kanavin " RECIPE_MAINTAINER_pn-volatile-binds = "Chen Qi " RECIPE_MAINTAINER_pn-vte = "Anuj Mittal " RECIPE_MAINTAINER_pn-vulkan = "Ross Burton " diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch new file mode 100644 index 000..b565c48ee66 --- /dev/null +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-vtest-add-missing-includes.patch @@ -0,0 +1,38 @@ +From 05c5c5f43fbffb3317bd9da27d414890d2ef493c Mon Sep 17 00:00:00 2001 +From: Alexander Kanavin +Date: Fri, 18 Jan 2019 13:47:23 +0100 +Subject: [PATCH] vtest: add missing includes + +This fixes build failures with musl C library + +Upstream-Status: Submitted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/125] +Signed-off-by: Alexander Kanavin +--- + vtest/util.c | 1 + + vtest/vtest_server.c | 1 + + 2 files changed, 2 insertions(+) + +diff --git a/vtest/util.c b/vtest/util.c +index 0d3c78f..c605253 100644 +--- a/vtest/util.c b/vtest/util.c +@@ -26,6 +26,7 @@ + #include + #include + #include ++#include + + int vtest_wait_for_fd_read(int fd) + { +diff --git a/vtest/vtest_server.c b/vtest/vtest_server.c +index bc6c95f..010721f 100644 +--- a/vtest/vtest_server.c b/vtest/vtest_server.c +@@ -31,6 +31,7 @@ + #include + #include + #include ++#include + + #include "util.h" + #include "vtest.h" diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb new file mode 100644 index 000..93fc35feb8d --- /dev/null +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_git.bb @@ -0,0 +1,19 @@ +SUMMARY = "VirGL virtual OpenGL renderer" +HOMEPAGE = "https://virgil3d.github.io/; + +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://COPYING;md5=c81c08eeefd9418fca8f88309a76db10" + +DEPENDS = "libdrm mesa libepoxy" +PV = "0.7.0" +SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c" +SRC_URI = "git://anongit.freedesktop.org/virglrenderer \ + file://0001-vtest-add-missing-includes.patch \ + " + +S = "${WORKDIR}/git" + +inherit autotools pkgconfig + +BBCLASSEXTEND = "native nativesdk" + -- 2.17.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core