Re: [OE-core] [PATCH 1/1] assimp: Remove it
On Wed, Sep 8, 2021 at 3:08 AM Ross Burton wrote: > > On Tue, 7 Sept 2021 at 13:50, Alexander Kanavin > wrote: > > I'm not sure why layerindex says otherewise, but neither vulkan nor > > anything in meta-qt5 actually depend on assimp. > > qt5/6 has an option, off by default, to use external assimp, vulkan has no > > dependency at all. > > > > This leaves basically meta-ros, so carrying assimp for the benefit of a > > single layer is dubious at best. > > I thought Vulkan needed assimp so dug into the history. vulkan-demos > used to need it, but that was replaced with vulkan-samples which does > not. > > So, I say we drop assimp from core and move it to meta-oe. just drop it, there is nothing in meta-openembedded repos that need it so I am not that interested to maintain it in meta-oe either. > > Ross > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155841): https://lists.openembedded.org/g/openembedded-core/message/155841 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
On Wed, 2021-09-08 at 11:08 +0100, Ross Burton wrote: > On Tue, 7 Sept 2021 at 13:50, Alexander Kanavin > wrote: > > I'm not sure why layerindex says otherewise, but neither vulkan nor > > anything in meta-qt5 actually depend on assimp. > > qt5/6 has an option, off by default, to use external assimp, vulkan has no > > dependency at all. > > > > This leaves basically meta-ros, so carrying assimp for the benefit of a > > single layer is dubious at best. > > I thought Vulkan needed assimp so dug into the history. vulkan-demos > used to need it, but that was replaced with vulkan-samples which does > not. > > So, I say we drop assimp from core and move it to meta-oe. FWIW I agree, its looking like a pain from a few angles and it isn't worth that in core. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155788): https://lists.openembedded.org/g/openembedded-core/message/155788 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
On Tue, 7 Sept 2021 at 13:50, Alexander Kanavin wrote: > I'm not sure why layerindex says otherewise, but neither vulkan nor anything > in meta-qt5 actually depend on assimp. > qt5/6 has an option, off by default, to use external assimp, vulkan has no > dependency at all. > > This leaves basically meta-ros, so carrying assimp for the benefit of a > single layer is dubious at best. I thought Vulkan needed assimp so dug into the history. vulkan-demos used to need it, but that was replaced with vulkan-samples which does not. So, I say we drop assimp from core and move it to meta-oe. Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155787): https://lists.openembedded.org/g/openembedded-core/message/155787 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
On 9/8/21 5:33 PM, mikko.rap...@bmw.de wrote: Hi, On Wed, Sep 08, 2021 at 04:55:35PM +0800, Robert Yang wrote: On 9/7/21 8:10 PM, Ross Burton wrote: On Tue, 7 Sept 2021 at 13:04, Randy MacLeod wrote: I'll look at the sections that you have pointed out later today. Debian is always worth looking at when there's license issues. https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source Specifically: https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source#L81 They strip non-free components from the tarball before importing into their git repository. We can delete the same files during the build so they don't get redistributed. According to the license, those non-free files can't be saved anywhere such as the mirrors, I think that we need a special do_fetch command for assimp to make those files won't be saved to DL_DIR or the mirror? Maybe just use the Debian original tarball, and possible patches to fix issues in assimp? That should be ok for all mirrors. Yes, that's a good idea, thanks Debian. // Robert Cheers, -Mikko -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155786): https://lists.openembedded.org/g/openembedded-core/message/155786 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
Hi, On Wed, Sep 08, 2021 at 04:55:35PM +0800, Robert Yang wrote: > On 9/7/21 8:10 PM, Ross Burton wrote: > > On Tue, 7 Sept 2021 at 13:04, Randy MacLeod > > wrote: > > > I'll look at the sections that you have pointed out later today. > > > > Debian is always worth looking at when there's license issues. > > > > https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source > > > > Specifically: > > > > https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source#L81 > > > > They strip non-free components from the tarball before importing into > > their git repository. We can delete the same files during the build > > so they don't get redistributed. > > According to the license, those non-free files can't be saved anywhere such > as the mirrors, I think that we need a special do_fetch command for assimp to > make those files won't be saved to DL_DIR or the mirror? Maybe just use the Debian original tarball, and possible patches to fix issues in assimp? That should be ok for all mirrors. Cheers, -Mikko -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155785): https://lists.openembedded.org/g/openembedded-core/message/155785 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
Hi Ross, On 9/7/21 8:10 PM, Ross Burton wrote: On Tue, 7 Sept 2021 at 13:04, Randy MacLeod wrote: I'll look at the sections that you have pointed out later today. Debian is always worth looking at when there's license issues. https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source Specifically: https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source#L81 They strip non-free components from the tarball before importing into their git repository. We can delete the same files during the build so they don't get redistributed. According to the license, those non-free files can't be saved anywhere such as the mirrors, I think that we need a special do_fetch command for assimp to make those files won't be saved to DL_DIR or the mirror? // Robert Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155783): https://lists.openembedded.org/g/openembedded-core/message/155783 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
On Tue, Sep 7, 2021 at 5:10 AM Ross Burton wrote: > > On Tue, 7 Sept 2021 at 13:04, Randy MacLeod > wrote: > > I'll look at the sections that you have pointed out later today. > > Debian is always worth looking at when there's license issues. > > https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source > > Specifically: > > https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source#L81 > > They strip non-free components from the tarball before importing into > their git repository. We can delete the same files during the build > so they don't get redistributed. yeah that seems a sensible approach to me. > > Ross > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155768): https://lists.openembedded.org/g/openembedded-core/message/155768 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
On Tue, 7 Sept 2021 at 13:04, Randy MacLeod wrote: > I'll look at the sections that you have pointed out later today. Debian is always worth looking at when there's license issues. https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source Specifically: https://salsa.debian.org/debian/assimp/-/blob/master/debian/README.source#L81 They strip non-free components from the tarball before importing into their git repository. We can delete the same files during the build so they don't get redistributed. Ross -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#155757): https://lists.openembedded.org/g/openembedded-core/message/155757 Mute This Topic: https://lists.openembedded.org/mt/85431030/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/1] assimp: Remove it
On 2021-09-07 5:17 a.m., Robert Yang wrote:
Remove it since it has license issues:
* scripts/StepImporter/schema_ifc2x3.exp
Copyright by: International Alliance for Interoperability, 1996-2005 All rights
reserved. No part of this documentation may be reproduced, stored in a
retrieval system, or transmitted in any form or by any means, without the prior
written permission of the owner
* test/models-nonbsd/X/dwarf-Read-Me.txt
RESTRICTIONS: This model pack is available for use in freeware, shareware,
commercial games/software with the following restrictions:- **You may not
sell/re-sell this model pack or claim it as your own. ***You may not
redistribute this pack in some other model pack through a website or on a
compilation CD of any kind, without my written consent. Psi
http://www.psionic3d.co.uk
* test/models-nonbsd/B3D/turtle.source.txt
Copyright 2004, Psionic Design e-mail: psio...@blueyonder.co.uk Used with
permission. RESTRICTIONS: This model pack is available for use in freeware,
shareware, commercial games/software with the following restrictions:- **You
may not sell/re-sell this model pack or claim it as your own. ***You may not
redistribute this pack in some other model pack through a website or on a
compilation CD of any kind, without my written consent.
And no recipes depend on it, so remove it.
In master, it seems that vulkan* depends on assimp:
https://layers.openembedded.org/layerindex/branch/master/recipes/?q=depends%3Aassimp
and lots of recipes in meta-qt5 and meta-ros* so removing it here
would just push the problem around.
I'll look at the sections that you have pointed out later today.
../Randy
Signed-off-by: Robert Yang
---
meta/conf/distro/include/maintainers.inc |1 -
...hared-lib-from-_IMPORT_CHECK_TARGETS.patch | 32 -
...hub.com-assimp-assimp-issues-2733-up.patch | 1664 -
.../use-GNUInstallDirs-where-possible.patch | 257 ---
meta/recipes-graphics/vulkan/assimp_5.0.1.bb | 26 -
5 files changed, 1980 deletions(-)
delete mode 100644
meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
delete mode 100644
meta/recipes-graphics/vulkan/assimp/0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch
delete mode 100644
meta/recipes-graphics/vulkan/assimp/use-GNUInstallDirs-where-possible.patch
delete mode 100644 meta/recipes-graphics/vulkan/assimp_5.0.1.bb
diff --git a/meta/conf/distro/include/maintainers.inc
b/meta/conf/distro/include/maintainers.inc
index 0e8185f4e3..e560ba39dd 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -46,7 +46,6 @@ RECIPE_MAINTAINER:pn-apt = "Aníbal Limón
"
RECIPE_MAINTAINER:pn-argp-standalone = "Khem Raj "
RECIPE_MAINTAINER:pn-asciidoc = "Yi Zhao "
RECIPE_MAINTAINER:pn-aspell = "Anuj Mittal "
-RECIPE_MAINTAINER:pn-assimp = "Anuj Mittal "
RECIPE_MAINTAINER:pn-at = "Chen Qi "
RECIPE_MAINTAINER:pn-at-spi2-atk = "Tim Orling "
RECIPE_MAINTAINER:pn-at-spi2-core = "Tim Orling "
diff --git
a/meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
b/meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
deleted file mode 100644
index 1078148d6b..00
---
a/meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From: Ranjitsinh Rathod
-Date: Fri, 13 Aug 2021 16:42:48 +0530
-Subject: [PATCH] assimp: remove shared lib from _IMPORT_CHECK_TARGETS
-
-In the target assimp::assimp shared library verification removed
-as it is giving configuration error when used by 3rd part component to
-configure itself using assimp::assimp target
-
-Upstream-Status: Inappropriate [oe specific]
-
-Signed-off-by: Ranjitsinh Rathod
- assimpTargets-release.cmake.in | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/assimpTargets-release.cmake.in b/assimpTargets-release.cmake.in
-index cd2fac7e0..52edc7990 100644
a/assimpTargets-release.cmake.in
-+++ b/assimpTargets-release.cmake.in
-@@ -72,8 +72,8 @@ else()
- IMPORTED_SONAME_RELEASE "${sharedLibraryName}"
- IMPORTED_LOCATION_RELEASE
"@CMAKE_INSTALL_FULL_LIBDIR@/${sharedLibraryName}"
- )
--list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp )
--list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp
"@CMAKE_INSTALL_FULL_LIBDIR@/${sharedLibraryName}" )
-+#list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp )
-+#list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp
"@CMAKE_INSTALL_FULL_LIBDIR@/${sharedLibraryName}" )
- else()
- set(staticLibraryName
"libassimp${ASSIMP_LIBRARY_SUFFIX}@CMAKE_STATIC_LIBRARY_SUFFIX@")
- set_target_properties(assimp::assimp PROPERTIES
---
-2.17.1
diff --git
a/meta/recipes-graphics/vulkan/assimp/0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch
[OE-core] [PATCH 1/1] assimp: Remove it
Remove it since it has license issues:
* scripts/StepImporter/schema_ifc2x3.exp
Copyright by: International Alliance for Interoperability, 1996-2005 All rights
reserved. No part of this documentation may be reproduced, stored in a
retrieval system, or transmitted in any form or by any means, without the prior
written permission of the owner
* test/models-nonbsd/X/dwarf-Read-Me.txt
RESTRICTIONS: This model pack is available for use in freeware, shareware,
commercial games/software with the following restrictions:- **You may not
sell/re-sell this model pack or claim it as your own. ***You may not
redistribute this pack in some other model pack through a website or on a
compilation CD of any kind, without my written consent. Psi
http://www.psionic3d.co.uk
* test/models-nonbsd/B3D/turtle.source.txt
Copyright 2004, Psionic Design e-mail: psio...@blueyonder.co.uk Used with
permission. RESTRICTIONS: This model pack is available for use in freeware,
shareware, commercial games/software with the following restrictions:- **You
may not sell/re-sell this model pack or claim it as your own. ***You may not
redistribute this pack in some other model pack through a website or on a
compilation CD of any kind, without my written consent.
And no recipes depend on it, so remove it.
Signed-off-by: Robert Yang
---
meta/conf/distro/include/maintainers.inc |1 -
...hared-lib-from-_IMPORT_CHECK_TARGETS.patch | 32 -
...hub.com-assimp-assimp-issues-2733-up.patch | 1664 -
.../use-GNUInstallDirs-where-possible.patch | 257 ---
meta/recipes-graphics/vulkan/assimp_5.0.1.bb | 26 -
5 files changed, 1980 deletions(-)
delete mode 100644
meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
delete mode 100644
meta/recipes-graphics/vulkan/assimp/0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch
delete mode 100644
meta/recipes-graphics/vulkan/assimp/use-GNUInstallDirs-where-possible.patch
delete mode 100644 meta/recipes-graphics/vulkan/assimp_5.0.1.bb
diff --git a/meta/conf/distro/include/maintainers.inc
b/meta/conf/distro/include/maintainers.inc
index 0e8185f4e3..e560ba39dd 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -46,7 +46,6 @@ RECIPE_MAINTAINER:pn-apt = "Aníbal Limón
"
RECIPE_MAINTAINER:pn-argp-standalone = "Khem Raj "
RECIPE_MAINTAINER:pn-asciidoc = "Yi Zhao "
RECIPE_MAINTAINER:pn-aspell = "Anuj Mittal "
-RECIPE_MAINTAINER:pn-assimp = "Anuj Mittal "
RECIPE_MAINTAINER:pn-at = "Chen Qi "
RECIPE_MAINTAINER:pn-at-spi2-atk = "Tim Orling "
RECIPE_MAINTAINER:pn-at-spi2-core = "Tim Orling "
diff --git
a/meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
b/meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
deleted file mode 100644
index 1078148d6b..00
---
a/meta/recipes-graphics/vulkan/assimp/0001-assimp-remove-shared-lib-from-_IMPORT_CHECK_TARGETS.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From: Ranjitsinh Rathod
-Date: Fri, 13 Aug 2021 16:42:48 +0530
-Subject: [PATCH] assimp: remove shared lib from _IMPORT_CHECK_TARGETS
-
-In the target assimp::assimp shared library verification removed
-as it is giving configuration error when used by 3rd part component to
-configure itself using assimp::assimp target
-
-Upstream-Status: Inappropriate [oe specific]
-
-Signed-off-by: Ranjitsinh Rathod
- assimpTargets-release.cmake.in | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/assimpTargets-release.cmake.in b/assimpTargets-release.cmake.in
-index cd2fac7e0..52edc7990 100644
a/assimpTargets-release.cmake.in
-+++ b/assimpTargets-release.cmake.in
-@@ -72,8 +72,8 @@ else()
- IMPORTED_SONAME_RELEASE "${sharedLibraryName}"
- IMPORTED_LOCATION_RELEASE
"@CMAKE_INSTALL_FULL_LIBDIR@/${sharedLibraryName}"
- )
--list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp )
--list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp
"@CMAKE_INSTALL_FULL_LIBDIR@/${sharedLibraryName}" )
-+#list(APPEND _IMPORT_CHECK_TARGETS assimp::assimp )
-+#list(APPEND _IMPORT_CHECK_FILES_FOR_assimp::assimp
"@CMAKE_INSTALL_FULL_LIBDIR@/${sharedLibraryName}" )
- else()
- set(staticLibraryName
"libassimp${ASSIMP_LIBRARY_SUFFIX}@CMAKE_STATIC_LIBRARY_SUFFIX@")
- set_target_properties(assimp::assimp PROPERTIES
---
-2.17.1
diff --git
a/meta/recipes-graphics/vulkan/assimp/0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch
b/meta/recipes-graphics/vulkan/assimp/0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch
deleted file mode 100644
index 87a1658710..00
---
a/meta/recipes-graphics/vulkan/assimp/0001-closes-https-github.com-assimp-assimp-issues-2733-up.patch
+++ /dev/null
@@ -1,1664 +0,0 @@
-From 7fc220b2350d78942fb3935cad0b1564418ebe8f Mon Sep 17 00:00:00 2001
-From: Kim Kulling
-Date: Tue, 19 Nov 2019 20:30:40
