Re: [OE-core] [PATCH 1/2] busybox: enable unicode support
On Wed, Jul 17, 2019 at 5:24 AM wrote: > > On Wed, Jul 17, 2019 at 12:44:54PM +0100, Richard Purdie wrote: > > On Wed, 2019-07-17 at 12:08 +0300, Mikko Rapeli wrote: > > > While creating and deleting files with unicode or other > > > encodings works, it's annoying when ls and other core utils > > > show questionmarks instead of the unicode characters. > > > In 2019, it's quite common that users of embedded devices > > > based on yocto need unicode support. Debugging a box with > > > unicode encoded file names is a bit annoying when core utils > > > from busybox don't support them. > > > > > > The unicode config fragment has the same config as Debian in their > > > deb and udeb builds of version 1:1.30.1-4. > > > > > > If developers do not want this or other default yocto features in > > > busybox, > > > or optimize the configuration for size, then they likely run a > > > completely > > > custom configuration. Thus I think it's safe to enable unicode > > > support > > > by default. > > > > > > Signed-off-by: Mikko Rapeli > > > --- > > > meta/recipes-core/busybox/busybox/unicode.cfg | 10 ++ > > > meta/recipes-core/busybox/busybox_1.31.0.bb | 1 + > > > 2 files changed, 11 insertions(+) > > > create mode 100644 meta/recipes-core/busybox/busybox/unicode.cfg > > > > Can you give an idea of the size implications of this change? > > buildhistory isn't working for me, or maybe it is since the size difference > is zero bytes for busybox binaries and package. tmp has this patch, > tmp_master doesn't: > > $ ls -l tmp*/deploy/images/qemux86/tmp/bin/busybox.* > -rwxr-xr-x 1 mcfrisk mcfrisk 612024 Jul 17 10:45 > tmp/deploy/images/qemux86/tmp/bin/busybox.nosuid > -rwxr-xr-x 1 mcfrisk mcfrisk 54656 Jul 17 10:45 > tmp/deploy/images/qemux86/tmp/bin/busybox.suid > -rwxr-xr-x 1 mcfrisk mcfrisk 612024 Jul 17 13:56 > tmp_master/deploy/images/qemux86/tmp/bin/busybox.nosuid > -rwxr-xr-x 1 mcfrisk mcfrisk 54656 Jul 17 13:56 > tmp_master/deploy/images/qemux86/tmp/bin/busybox.suid > > Just to be sure, the files differ: > > $ sha1sum tmp*/deploy/images/qemux86/tmp/bin/busybox.* > 8866ced8ad8aa335bb5dfc8b229851b6e09397d7 > tmp/deploy/images/qemux86/tmp/bin/busybox.nosuid > 01cb28f1254f4200b005122ce03114b034b3aaec > tmp/deploy/images/qemux86/tmp/bin/busybox.suid > 91ed5b26083c9b6f944344036b04ebf2aa5af6ff > tmp_master/deploy/images/qemux86/tmp/bin/busybox.nosuid > d4a3ee35246c0f42ba4f0a8a34cd96269b89e906 > tmp_master/deploy/images/qemux86/tmp/bin/busybox.suid > > buildhistory shows that busybox-dbg PKGSIZE increases from 4523596 to 4546396, > busybox-ptest PKGSIZE decreases from 458949 to 458908 even when > /usr/lib/busybox/ptest/testsuite/tar.utf8.tar.bz2 is added, busybox-src > PKGSIZE increases from 4130952 to 4163274. > > I found that hard to believe so I didn't trust buildhistory anymore. > I think its fine to enable it, but we need to understand the size implications maybe rename busybox build dir to something and with without so you have two dirs to compare. > -Mikko > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/2] busybox: enable unicode support
On Wed, 17 Jul 2019 at 13:25, wrote: > buildhistory shows that busybox-dbg PKGSIZE increases from 4523596 to 4546396, > busybox-ptest PKGSIZE decreases from 458949 to 458908 even when > /usr/lib/busybox/ptest/testsuite/tar.utf8.tar.bz2 is added, busybox-src > PKGSIZE increases from 4130952 to 4163274. For me: busybox-dbg: -PKGSIZE = 5212120 +PKGSIZE = 5239440 busybox-ptest: -PKGSIZE = 458881 +PKGSIZE = 458840 busybox-src: -PKGSIZE = 4130692 +PKGSIZE = 4163014 busybox: -PKGSIZE = 687247 +PKGSIZE = 691343 Oddly files-in-package doesn't appear to have been touched in the repo. I wonder if my sysroot changes broke that part of buildhistory... Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/2] busybox: enable unicode support
On Wed, Jul 17, 2019 at 12:44:54PM +0100, Richard Purdie wrote: > On Wed, 2019-07-17 at 12:08 +0300, Mikko Rapeli wrote: > > While creating and deleting files with unicode or other > > encodings works, it's annoying when ls and other core utils > > show questionmarks instead of the unicode characters. > > In 2019, it's quite common that users of embedded devices > > based on yocto need unicode support. Debugging a box with > > unicode encoded file names is a bit annoying when core utils > > from busybox don't support them. > > > > The unicode config fragment has the same config as Debian in their > > deb and udeb builds of version 1:1.30.1-4. > > > > If developers do not want this or other default yocto features in > > busybox, > > or optimize the configuration for size, then they likely run a > > completely > > custom configuration. Thus I think it's safe to enable unicode > > support > > by default. > > > > Signed-off-by: Mikko Rapeli > > --- > > meta/recipes-core/busybox/busybox/unicode.cfg | 10 ++ > > meta/recipes-core/busybox/busybox_1.31.0.bb | 1 + > > 2 files changed, 11 insertions(+) > > create mode 100644 meta/recipes-core/busybox/busybox/unicode.cfg > > Can you give an idea of the size implications of this change? buildhistory isn't working for me, or maybe it is since the size difference is zero bytes for busybox binaries and package. tmp has this patch, tmp_master doesn't: $ ls -l tmp*/deploy/images/qemux86/tmp/bin/busybox.* -rwxr-xr-x 1 mcfrisk mcfrisk 612024 Jul 17 10:45 tmp/deploy/images/qemux86/tmp/bin/busybox.nosuid -rwxr-xr-x 1 mcfrisk mcfrisk 54656 Jul 17 10:45 tmp/deploy/images/qemux86/tmp/bin/busybox.suid -rwxr-xr-x 1 mcfrisk mcfrisk 612024 Jul 17 13:56 tmp_master/deploy/images/qemux86/tmp/bin/busybox.nosuid -rwxr-xr-x 1 mcfrisk mcfrisk 54656 Jul 17 13:56 tmp_master/deploy/images/qemux86/tmp/bin/busybox.suid Just to be sure, the files differ: $ sha1sum tmp*/deploy/images/qemux86/tmp/bin/busybox.* 8866ced8ad8aa335bb5dfc8b229851b6e09397d7 tmp/deploy/images/qemux86/tmp/bin/busybox.nosuid 01cb28f1254f4200b005122ce03114b034b3aaec tmp/deploy/images/qemux86/tmp/bin/busybox.suid 91ed5b26083c9b6f944344036b04ebf2aa5af6ff tmp_master/deploy/images/qemux86/tmp/bin/busybox.nosuid d4a3ee35246c0f42ba4f0a8a34cd96269b89e906 tmp_master/deploy/images/qemux86/tmp/bin/busybox.suid buildhistory shows that busybox-dbg PKGSIZE increases from 4523596 to 4546396, busybox-ptest PKGSIZE decreases from 458949 to 458908 even when /usr/lib/busybox/ptest/testsuite/tar.utf8.tar.bz2 is added, busybox-src PKGSIZE increases from 4130952 to 4163274. I found that hard to believe so I didn't trust buildhistory anymore. -Mikko -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/2] busybox: enable unicode support
On Wed, 2019-07-17 at 12:08 +0300, Mikko Rapeli wrote: > While creating and deleting files with unicode or other > encodings works, it's annoying when ls and other core utils > show questionmarks instead of the unicode characters. > In 2019, it's quite common that users of embedded devices > based on yocto need unicode support. Debugging a box with > unicode encoded file names is a bit annoying when core utils > from busybox don't support them. > > The unicode config fragment has the same config as Debian in their > deb and udeb builds of version 1:1.30.1-4. > > If developers do not want this or other default yocto features in > busybox, > or optimize the configuration for size, then they likely run a > completely > custom configuration. Thus I think it's safe to enable unicode > support > by default. > > Signed-off-by: Mikko Rapeli > --- > meta/recipes-core/busybox/busybox/unicode.cfg | 10 ++ > meta/recipes-core/busybox/busybox_1.31.0.bb | 1 + > 2 files changed, 11 insertions(+) > create mode 100644 meta/recipes-core/busybox/busybox/unicode.cfg Can you give an idea of the size implications of this change? Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 1/2] busybox: enable unicode support
While creating and deleting files with unicode or other
encodings works, it's annoying when ls and other core utils
show questionmarks instead of the unicode characters.
In 2019, it's quite common that users of embedded devices
based on yocto need unicode support. Debugging a box with
unicode encoded file names is a bit annoying when core utils
from busybox don't support them.
The unicode config fragment has the same config as Debian in their
deb and udeb builds of version 1:1.30.1-4.
If developers do not want this or other default yocto features in busybox,
or optimize the configuration for size, then they likely run a completely
custom configuration. Thus I think it's safe to enable unicode support
by default.
Signed-off-by: Mikko Rapeli
---
meta/recipes-core/busybox/busybox/unicode.cfg | 10 ++
meta/recipes-core/busybox/busybox_1.31.0.bb | 1 +
2 files changed, 11 insertions(+)
create mode 100644 meta/recipes-core/busybox/busybox/unicode.cfg
diff --git a/meta/recipes-core/busybox/busybox/unicode.cfg
b/meta/recipes-core/busybox/busybox/unicode.cfg
new file mode 100644
index 000..ecb5a64
--- /dev/null
+++ b/meta/recipes-core/busybox/busybox/unicode.cfg
@@ -0,0 +1,10 @@
+CONFIG_UNICODE_SUPPORT=y
+# CONFIG_UNICODE_USING_LOCALE is not set
+CONFIG_FEATURE_CHECK_UNICODE_IN_ENV=y
+CONFIG_SUBST_WCHAR=63
+CONFIG_LAST_SUPPORTED_WCHAR=767
+CONFIG_UNICODE_COMBINING_WCHARS=y
+CONFIG_UNICODE_WIDE_WCHARS=y
+# CONFIG_UNICODE_BIDI_SUPPORT is not set
+# CONFIG_UNICODE_NEUTRAL_TABLE is not set
+# CONFIG_UNICODE_PRESERVE_BROKEN is not set
diff --git a/meta/recipes-core/busybox/busybox_1.31.0.bb
b/meta/recipes-core/busybox/busybox_1.31.0.bb
index f018543..c1da372 100644
--- a/meta/recipes-core/busybox/busybox_1.31.0.bb
+++ b/meta/recipes-core/busybox/busybox_1.31.0.bb
@@ -37,6 +37,7 @@ SRC_URI =
"http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
${@["",
"file://init.cfg"][(d.getVar('VIRTUAL-RUNTIME_init_manager') == 'busybox')]} \
${@["", "file://mdev.cfg"][(d.getVar('VIRTUAL-RUNTIME_dev_manager')
== 'busybox-mdev')]} \
file://syslog.cfg \
+ file://unicode.cfg \
file://inittab \
file://rcS \
file://rcK \
--
1.9.1
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
