Re: [OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-23 Thread Piotr Łobacz
Dnia piątek, 23 lutego 2024 10:36:27 CET Chen Qi via lists.openembedded.org pisze: > 1. I can see what this patch mainly does is ensuring groups first, then > user, then groupmems. But the current useradd_preinst, which is called > by useradd_sysroot has already ensured this. Is that not working?

Re: [OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-23 Thread Chen Qi via lists.openembedded.org
1. I can see what this patch mainly does is ensuring groups first, then user, then groupmems. But the current useradd_preinst, which is called by useradd_sysroot has already ensured this. Is that not working? 2. You're using bb.warn as a method of outputting debugging information, which I

Re: [OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-23 Thread Jermain Horsman
Although I did notice the rest of the file uses this syntax, and I do not believe there are any guidelines specific to this (that I am aware of), I did want to comment on this. > + if test "x$1" = "xgroup"; then > + if test "x$1" = "xuser"; then > + if test "x$1" = "xgroupmems";

Re: [OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-22 Thread Piotr Łobacz
Dnia czwartek, 22 lutego 2024 16:02:47 CET Richard Purdie pisze: > On Thu, 2024-02-22 at 14:53 +, Eilís 'pidge' Ní Fhlannagáin wrote: > > From: Piotr Łobacz > > > > postinst-useradd-* haven't been running in order of dependency. > > > > This patch is reworked from Piotr Łobacz's patch and

Re: [OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-22 Thread Richard Purdie
On Thu, 2024-02-22 at 14:53 +, Eilís 'pidge' Ní Fhlannagáin wrote: > From: Piotr Łobacz > > postinst-useradd-* haven't been running in order of dependency. > > This patch is reworked from Piotr Łobacz's patch and fixes: > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=15084 >

[OE-core] [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

2024-02-22 Thread Eilís 'pidge' Ní Fhlannagáin
From: Piotr Łobacz postinst-useradd-* haven't been running in order of dependency. This patch is reworked from Piotr Łobacz's patch and fixes: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15084 https://bugzilla.yoctoproject.org/show_bug.cgi?id=13904 It ensures that groups, users and