Re: [OE-core] [PATCH 13/25] pseudo: adjust for attr 2.4.48
On Wed, 18 Dec 2019 17:24:21 +0100 Alexander Kanavin wrote: > You can also supply your own definition of ENOATTR, as it doesn't > change. That way lies EVEN MORE madness. I don't have any guarantee that it won't be changed at some point, and... I mean, silly though it sounds to talk about "defined" or "undefined" when working on pseudo, it's *really* not okay for non-implementation code to be defining a symbol starting with a capital E like that. I am not sure why the attr people hate compatibility with existing code, but probably because they're monsters who are motivated only by a desire to crush the hopes and dreams of others. That's usually why people make backwards-incompatible header changes. -s -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 13/25] pseudo: adjust for attr 2.4.48
On Wed, 18 Dec 2019 at 17:22, Seebs wrote: > > It won't, as attr upstream moved the definition of ENOATTR from one > > header file to another. > > > > attr is supplied by oe-core though, so we have control over which > > version is used. > > So basically, if I want to maintain support in pseudo for older xattr, > I need to figure out a way to try both. Thanks, attr devs. :P (Pseudo > is still sometimes used outside of oe-core.) > You can also supply your own definition of ENOATTR, as it doesn't change. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 13/25] pseudo: adjust for attr 2.4.48
On Wed, 18 Dec 2019 17:15:34 +0100 Alexander Kanavin wrote: > On Wed, 18 Dec 2019 at 16:27, Seebs wrote: > > > On Wed, 18 Dec 2019 15:37:46 +0100 > > Alexander Kanavin wrote: > > > > > +Latest versions of attr have removed the xattr.h header, > > > +with the rationale that libc is providing the same wrappers. > > > > I'm a bit concerned about this -- will this still work with *older* > > versions of xattr? > > > > It won't, as attr upstream moved the definition of ENOATTR from one > header file to another. > > attr is supplied by oe-core though, so we have control over which > version is used. So basically, if I want to maintain support in pseudo for older xattr, I need to figure out a way to try both. Thanks, attr devs. :P (Pseudo is still sometimes used outside of oe-core.) -s -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 13/25] pseudo: adjust for attr 2.4.48
On Wed, 18 Dec 2019 at 16:27, Seebs wrote: > On Wed, 18 Dec 2019 15:37:46 +0100 > Alexander Kanavin wrote: > > > +Latest versions of attr have removed the xattr.h header, > > +with the rationale that libc is providing the same wrappers. > > I'm a bit concerned about this -- will this still work with *older* > versions of xattr? > It won't, as attr upstream moved the definition of ENOATTR from one header file to another. attr is supplied by oe-core though, so we have control over which version is used. Alex -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 13/25] pseudo: adjust for attr 2.4.48
On Wed, 18 Dec 2019 15:37:46 +0100 Alexander Kanavin wrote: > +Latest versions of attr have removed the xattr.h header, > +with the rationale that libc is providing the same wrappers. I'm a bit concerned about this -- will this still work with *older* versions of xattr? -s -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 13/25] pseudo: adjust for attr 2.4.48
Signed-off-by: Alexander Kanavin
---
...xattr-adjust-for-attr-2.4.48-release.patch | 48 +++
meta/recipes-devtools/pseudo/pseudo_git.bb| 1 +
2 files changed, 49 insertions(+)
create mode 100644
meta/recipes-devtools/pseudo/files/0006-xattr-adjust-for-attr-2.4.48-release.patch
diff --git
a/meta/recipes-devtools/pseudo/files/0006-xattr-adjust-for-attr-2.4.48-release.patch
b/meta/recipes-devtools/pseudo/files/0006-xattr-adjust-for-attr-2.4.48-release.patch
new file mode 100644
index 000..161357d5530
--- /dev/null
+++
b/meta/recipes-devtools/pseudo/files/0006-xattr-adjust-for-attr-2.4.48-release.patch
@@ -0,0 +1,48 @@
+From 93d95ed2eaedcca110c214e1fe3f8896b1f6f853 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin
+Date: Tue, 17 Dec 2019 20:24:27 +0100
+Subject: [PATCH] xattr: adjust for attr 2.4.48 release
+
+Latest versions of attr have removed the xattr.h header,
+with the rationale that libc is providing the same wrappers.
+
+attr/attributes.h is providing the ENOATTR definition.
+
+Upstream-Status: Pending
+Signed-off-by: Alexander Kanavin
+---
+ ports/linux/subports | 5 +++--
+ ports/linux/xattr/portdefs.h | 3 ++-
+ 2 files changed, 5 insertions(+), 3 deletions(-)
+
+diff --git a/ports/linux/subports b/ports/linux/subports
+index 2c43ac9..740ec83 100755
+--- a/ports/linux/subports
b/ports/linux/subports
+@@ -29,11 +29,12 @@ fi
+ if$port_xattr; then
+ cat > dummy.c <
+-#include
++#include
++#include
+ int i;
+ EOF
+ if ! ${CC} -c -o dummy.o dummy.c >/dev/null 2>&1; then
+- echo >&2 "Warning: Can't compile trivial program using
".
++ echo >&2 "Warning: Can't compile trivial program using
".
+ echo >&2 " xattr support will require that header."
+ fi
+ echo "linux/xattr"
+diff --git a/ports/linux/xattr/portdefs.h b/ports/linux/xattr/portdefs.h
+index 56cd3ca..068d39a 100644
+--- a/ports/linux/xattr/portdefs.h
b/ports/linux/xattr/portdefs.h
+@@ -2,5 +2,6 @@
+ * SPDX-License-Identifier: LGPL-2.1-only
+ *
+ */
+-#include
++#include
++#include
+ #include
diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb
b/meta/recipes-devtools/pseudo/pseudo_git.bb
index 1f2df4a427e..6da111232c4 100644
--- a/meta/recipes-devtools/pseudo/pseudo_git.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
@@ -8,6 +8,7 @@ SRC_URI = "git://git.yoctoproject.org/pseudo \
file://toomanyfiles.patch \
file://0001-maketables-wrappers-use-Python-3.patch \
file://0001-Add-statx.patch \
+ file://0006-xattr-adjust-for-attr-2.4.48-release.patch \
"
SRCREV = "060058bb29f70b244e685b3c704eb0641b736f73"
--
2.17.1
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
