Re: [OE-core] [PATCH 19/20] gcc-cross-testing: Fix evaluation of user and target name

2012-02-07 Thread Saul Wold
On 02/05/2012 10:40 PM, Khem Raj wrote: Dont use -q to grep we pipe to /dev/null anyway all we care is the return status of grep Signed-off-by: Khem Rajraj.k...@gmail.com xxx Signed-off-by: Khem Rajraj.k...@gmail.com The patch seem valid, but the commit message needs to be cleaned up.

Re: [OE-core] [PATCH 19/20] gcc-cross-testing: Fix evaluation of user and target name

2012-02-07 Thread Otavio Salvador
On Mon, Feb 6, 2012 at 04:40, Khem Raj raj.k...@gmail.com wrote: Dont use -q to grep we pipe to /dev/null anyway all we care is the return status of grep There're any reason to not use grep -q and drop the pipe? -- Otavio Salvador O.S. Systems E-mail:

Re: [OE-core] [PATCH 19/20] gcc-cross-testing: Fix evaluation of user and target name

2012-02-07 Thread Khem Raj
On Tue, Feb 7, 2012 at 9:21 AM, Saul Wold s...@linux.intel.com wrote: On 02/05/2012 10:40 PM, Khem Raj wrote: Dont use -q to grep we pipe to /dev/null anyway all we care is the return status of grep Signed-off-by: Khem Rajraj.k...@gmail.com xxx Signed-off-by: Khem Rajraj.k...@gmail.com

Re: [OE-core] [PATCH 19/20] gcc-cross-testing: Fix evaluation of user and target name

2012-02-07 Thread Khem Raj
On Tue, Feb 7, 2012 at 9:49 AM, Otavio Salvador ota...@ossystems.com.br wrote: There're any reason to not use grep -q and drop the pipe? yes. I dont need to know stderr along with stdio just return value is enough ___ Openembedded-core mailing list

[OE-core] [PATCH 19/20] gcc-cross-testing: Fix evaluation of user and target name

2012-02-05 Thread Khem Raj
Dont use -q to grep we pipe to /dev/null anyway all we care is the return status of grep Signed-off-by: Khem Raj raj.k...@gmail.com xxx Signed-off-by: Khem Raj raj.k...@gmail.com --- meta/recipes-devtools/gcc/gcc-cross.inc |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff