Re: [OE-core] [PATCH 2/2] Fix grep pattern when mklibs collects executables in rootfs

2013-11-22 Thread Nicolas Dechesne 
hi,

On Wed, Nov 13, 2013 at 4:05 AM, Lei Liu lay...@gmail.com wrote:

 On 2013年11月12日 18:23, Richard Purdie wrote:
  On Mon, 2013-11-11 at 17:27 +0800, Lei Liu wrote:
  From: Lei Liu lei.l...@windriver.com
 
  File command in some version could print extra space between
  LSB and executable - it causes mklibs can't find any executables
  using grep LSB executable.  Fix the grep pattern to catch
  multiple spaces.
 
  Signed-off-by: Lei Liu lei.l...@windriver.com
  ---
   meta/classes/image-mklibs.bbclass |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
  I've queued this but please put the area name in the short line of the
  commit in future (image-mklibs:  in this case).
 

 Okay.  Thanks.


First of all, this patch is needed on dora branch too , and it applies
cleanly, can that be merged?

Now, the real question... i am not able to get mklibs to work at all (even
with this patch). What i am seeing is that mklibs 0.1.38 doesn't support
anymore the use of 'sysroot'. I think this is because of this upstream
change

http://anonscm.debian.org/gitweb/?p=d-i/mklibs.git;a=commit;h=60bda7e2132d197e1c88afb5012f9677b6967db2

If I revert to 0.1.34 (that we had on dylan branch), i can build my image
just fine (note that I am building an arm soft-float image), so are you
able to use image-mklibs with dora or master which have 0.1.38?
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] Fix grep pattern when mklibs collects executables in rootfs

2013-11-12 Thread Richard Purdie 
On Mon, 2013-11-11 at 17:27 +0800, Lei Liu wrote:
 From: Lei Liu lei.l...@windriver.com
 
 File command in some version could print extra space between
 LSB and executable - it causes mklibs can't find any executables
 using grep LSB executable.  Fix the grep pattern to catch
 multiple spaces.
 
 Signed-off-by: Lei Liu lei.l...@windriver.com
 ---
  meta/classes/image-mklibs.bbclass |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

I've queued this but please put the area name in the short line of the
commit in future (image-mklibs:  in this case).

Cheers,

Richard

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] Fix grep pattern when mklibs collects executables in rootfs

2013-11-12 Thread Lei Liu 
On 2013年11月12日 18:23, Richard Purdie wrote:
 On Mon, 2013-11-11 at 17:27 +0800, Lei Liu wrote:
 From: Lei Liu lei.l...@windriver.com

 File command in some version could print extra space between
 LSB and executable - it causes mklibs can't find any executables
 using grep LSB executable.  Fix the grep pattern to catch
 multiple spaces.

 Signed-off-by: Lei Liu lei.l...@windriver.com
 ---
  meta/classes/image-mklibs.bbclass |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 I've queued this but please put the area name in the short line of the
 commit in future (image-mklibs:  in this case).


Okay.  Thanks.

Lei
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/2] Fix grep pattern when mklibs collects executables in rootfs

2013-11-11 Thread Lei Liu 
From: Lei Liu lei.l...@windriver.com

File command in some version could print extra space between
LSB and executable - it causes mklibs can't find any executables
using grep LSB executable.  Fix the grep pattern to catch
multiple spaces.

Signed-off-by: Lei Liu lei.l...@windriver.com
---
 meta/classes/image-mklibs.bbclass |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/image-mklibs.bbclass 
b/meta/classes/image-mklibs.bbclass
index 66b0f52..e975f5d 100644
--- a/meta/classes/image-mklibs.bbclass
+++ b/meta/classes/image-mklibs.bbclass
@@ -9,7 +9,7 @@ mklibs_optimize_image_doit() {
du -bs  ${WORKDIR}/mklibs/du.before.mklibs.txt
for i in `find .`; do file $i; done \
| grep ELF \
-   | grep LSB executable \
+   | grep LSB *executable \
| grep dynamically linked \
| sed s/:.*// \
| sed s+^\./++ \
-- 
1.7.0.4

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core