[OE-core] [PATCH 2/2] dbus: add user sessions support

[Andrew Shadura]

Enable the user-sessions support with a PACKAGECONFIG flag.

Signed-off-by: Andrew Shadura 
Signed-off-by: Joshua Lock 
---
 meta/recipes-core/dbus/dbus_1.10.6.bb | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/dbus/dbus_1.10.6.bb 
b/meta/recipes-core/dbus/dbus_1.10.6.bb
index fec68a4..245798a 100644
--- a/meta/recipes-core/dbus/dbus_1.10.6.bb
+++ b/meta/recipes-core/dbus/dbus_1.10.6.bb
@@ -69,7 +69,9 @@ FILES_${PN} = "${bindir}/dbus-daemon* \
${datadir}/dbus-1/session.conf \
${datadir}/dbus-1/system.d \
${datadir}/dbus-1/system.conf \
-   ${systemd_system_unitdir}"
+   ${systemd_system_unitdir} \
+   ${systemd_user_unitdir} \
+"
 FILES_${PN}-lib = "${libdir}/lib*.so.*"
 RRECOMMENDS_${PN}-lib = "${PN}"
 FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-test-tool"
@@ -105,6 +107,7 @@ PACKAGECONFIG_class-nativesdk = ""
 PACKAGECONFIG[systemd] = "--enable-systemd 
--with-systemdsystemunitdir=${systemd_system_unitdir},--disable-systemd 
--without-systemdsystemunitdir,systemd"
 PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x 
--disable-x11-autolaunch, virtual/libx11 libsm"
 PACKAGECONFIG[largefile] = "--enable-largefile,--disable-largefile,,"
+PACKAGECONFIG[user-session] = "--enable-user-session 
--with-systemduserunitdir=${systemd_user_unitdir},--disable-user-session"
 
 do_install() {
autotools_do_install
-- 
2.5.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] dbus: add user sessions support

[Patrick Ohly]

On Fri, 2015-11-20 at 15:38 +0100, Andrew Shadura wrote:
> Enable the user-sessions support with a PACKAGECONFIG flag.

I've tried this out in combination with the D-Bus 1.10 update patches.
It's perhaps worth pointing out that user sessions only work in
combination with pam.

I also found that one minor fix was needed in
meta/recipes-core/dbus/dbus_1.10.2.bb. Andrew, Ross, feel free to just
squash that into the pending patch.

But overall it looked good, so I'd love to have this in OE-core.

https://github.com/pohly/poky/commit/5b32e63f9e37492cef8de7aabfae562ab072b510

commit 5b32e63f9e37492cef8de7aabfae562ab072b510
Author: Patrick Ohly 
Date:   Fri Jan 8 15:34:50 2016 +0100

dbus_1.10.2.bb: fix path to systemctl

When compiling with systemd, pam and user sessions, the resulting
/usr/lib/systemd/user/dbus.socket ensures that the right
DBUS_SESSION_BUS_ADDRESS gets put into the environment when logging
into the system.

The default configure behavior is to look in the PATH, which picks up
the tool from the host sysroot. We need to override that so that the
final location on the target is used instead. This is only relevant at
the moment when enabling user sessions, but it makes sense to fix the
value in all cases.

Signed-off-by: Patrick Ohly 

diff --git a/meta/recipes-core/dbus/dbus_1.10.2.bb 
b/meta/recipes-core/dbus/dbus_1.10.2.bb
index ffb428b..a6cb649 100644
--- a/meta/recipes-core/dbus/dbus_1.10.2.bb
+++ b/meta/recipes-core/dbus/dbus_1.10.2.bb
@@ -96,6 +96,10 @@ EXTRA_OECONF = "--disable-tests \
 
 EXTRA_OECONF_append_class-native = " --disable-selinux"
 
+# Automatic detection in the configure script picks up the path to
+# the native tool, therefore we must override the automatism.
+EXTRA_OECONF_append_class-target = " SYSTEMCTL=${base_bindir}/systemctl"
+
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 
'systemd', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', 
d)}"
 PACKAGECONFIG_class-native = ""

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.



-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] dbus: add user sessions support

[Andrew Shadura]

On 24/11/15 15:03, Burton, Ross wrote:
> On 20 November 2015 at 14:38, Andrew Shadura
>  wrote:
> 
>>Enable the user-sessions support with a PACKAGECONFIG flag.
> 
> What is the impact on this if someone is using systemd but doesn't want
> user sessions?  Should we enable it if the DISTRO_FEATURES contains
> systemd by default?

It is okay to use systemd and not use user sessions. Possibly, we want
to enable it by default in the future, but it should be okay to have it
disabled for now unless it's switched on from elsewhere.

-- 
Cheers,
  Andrew



signature.asc
Description: OpenPGP digital signature
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] dbus: add user sessions support

[Burton, Ross]

On 20 November 2015 at 14:38, Andrew Shadura  wrote:

> Enable the user-sessions support with a PACKAGECONFIG flag.
>

What is the impact on this if someone is using systemd but doesn't want
user sessions?  Should we enable it if the DISTRO_FEATURES contains systemd
by default?

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 2/2] dbus: add user sessions support

[Andrew Shadura]

Enable the user-sessions support with a PACKAGECONFIG flag.

Signed-off-by: Andrew Shadura 
Signed-off-by: Joshua Lock 
---
 meta/recipes-core/dbus/dbus_1.10.2.bb | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/dbus/dbus_1.10.2.bb 
b/meta/recipes-core/dbus/dbus_1.10.2.bb
index f7ab39b..445f7ef 100644
--- a/meta/recipes-core/dbus/dbus_1.10.2.bb
+++ b/meta/recipes-core/dbus/dbus_1.10.2.bb
@@ -68,7 +68,9 @@ FILES_${PN} = "${bindir}/dbus-daemon* \
${datadir}/dbus-1/session.conf \
${datadir}/dbus-1/system.d \
${datadir}/dbus-1/system.conf \
-   ${systemd_system_unitdir}"
+   ${systemd_system_unitdir} \
+   ${systemd_user_unitdir} \
+"
 FILES_${PN}-lib = "${libdir}/lib*.so.*"
 RRECOMMENDS_${PN}-lib = "${PN}"
 FILES_${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-glib-tool 
${bindir}/dbus-test-tool"
@@ -99,9 +101,10 @@ PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 
'systemd', 'systemd',
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
 
-PACKAGECONFIG[systemd] = "--enable-systemd 
--with-systemdsystemunitdir=${systemd_system_unitdir},--disable-systemd 
--without-systemdsystemunitdir,systemd"
+PACKAGECONFIG[systemd] = "--enable-systemd 
--with-systemdsystemunitdir=${systemd_system_unitdir} 
--with-systemduserunitdir=${systemd_user_unitdir},--disable-systemd 
--without-systemdsystemunitdir --without-systemduserunitdir,systemd"
 PACKAGECONFIG[x11] = "--with-x --enable-x11-autolaunch,--without-x 
--disable-x11-autolaunch, virtual/libx11 libsm"
 PACKAGECONFIG[apparmor] = "--enable-apparmor,--disable-apparmor,libapparmor"
+PACKAGECONFIG[user-session] = "--enable-user-session,--disable-user-session"
 
 do_install() {
autotools_do_install
-- 
2.5.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core