Re: [OE-core] [PATCH 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS
On Sat, 2017-08-26 at 14:26 +0300, Jose Alarcon wrote: > The do_rootfs log contains a number of unsatisfied package > recommendations. At the moment those are only visible when > reviewing the rootfs log. > > This patch adds an extra check to surface any unsatisfied > recommendation as WARNINGS to the build output when > "debug-tweaks" is enabled. > > Signed-off-by: Jose Alarcon> --- > meta/classes/rootfs-postcommands.bbclass | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/meta/classes/rootfs-postcommands.bbclass > b/meta/classes/rootfs-postcommands.bbclass > index fb36bad..e7ef382 100644 > --- a/meta/classes/rootfs-postcommands.bbclass > +++ b/meta/classes/rootfs-postcommands.bbclass > @@ -50,6 +50,9 @@ python () { > d.appendVar('ROOTFS_POSTPROCESS_COMMAND', > '${SORT_PASSWD_POSTPROCESS_COMMAND}') > } > > +# Enable QA check for unsatisfied recommendations if debug-tweaks is > enabled > +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATU > RES", "debug-tweaks", "rootfs_log_check_recommends; ", "",d)}' > + > systemd_create_users () { > for conffile in > ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd.conf > ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd-remote.conf; do > [ -e $conffile ] || continue Can we just drop the above piece please? I think its fine for the user to enable this with: ROOTFS_POSTPROCESS_COMMAND += "rootfs_log_check_recommends" We're trying to kill off debug-tweaks as nobody can tell what it does from the name. Cheers, Richard > @@ -307,3 +310,15 @@ python write_image_test_data() { > os.remove(testdata_link) > os.symlink(os.path.basename(testdata), testdata_link) > } > + > +# Check for unsatisfied recommendations (RRECOMMENDS) > +python rootfs_log_check_recommends() { > +log_path = d.expand("${T}/log.do_rootfs") > +with open(log_path, 'r') as log: > +for line in log: > +if 'log_check' in line: > +continue > + > +if 'unsatisfied recommendation for' in line: > +bb.warn('[log_check] %s: %s' % (d.getVar('PN', > True), line)) > +} > -- > 2.10.1 > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS
On 26 August 2017 at 12:26, Jose Alarconwrote: > The do_rootfs log contains a number of unsatisfied package > recommendations. At the moment those are only visible when > reviewing the rootfs log. > > This patch adds an extra check to surface any unsatisfied > recommendation as WARNINGS to the build output when > "debug-tweaks" is enabled. > But isn't that the point of recommends? If the user uses BAD_RECOMMENDATIONS to explicitly stop specific recommendations being installed, or the package just isn't available, that's fine. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS
On 26.08.2017 14:26, Jose Alarcon wrote: > The do_rootfs log contains a number of unsatisfied package > recommendations. At the moment those are only visible when > reviewing the rootfs log. > > This patch adds an extra check to surface any unsatisfied > recommendation as WARNINGS to the build output when > "debug-tweaks" is enabled. > > Signed-off-by: Jose AlarconHello, Gentle reminder, has anyone have a chance to review this patch? Thanks, -- Jose Alarcon > --- > meta/classes/rootfs-postcommands.bbclass | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/meta/classes/rootfs-postcommands.bbclass > b/meta/classes/rootfs-postcommands.bbclass > index fb36bad..e7ef382 100644 > --- a/meta/classes/rootfs-postcommands.bbclass > +++ b/meta/classes/rootfs-postcommands.bbclass > @@ -50,6 +50,9 @@ python () { > d.appendVar('ROOTFS_POSTPROCESS_COMMAND', > '${SORT_PASSWD_POSTPROCESS_COMMAND}') > } > > +# Enable QA check for unsatisfied recommendations if debug-tweaks is enabled > +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", > "debug-tweaks", "rootfs_log_check_recommends; ", "",d)}' > + > systemd_create_users () { > for conffile in ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd.conf > ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd-remote.conf; do > [ -e $conffile ] || continue > @@ -307,3 +310,15 @@ python write_image_test_data() { > os.remove(testdata_link) > os.symlink(os.path.basename(testdata), testdata_link) > } > + > +# Check for unsatisfied recommendations (RRECOMMENDS) > +python rootfs_log_check_recommends() { > +log_path = d.expand("${T}/log.do_rootfs") > +with open(log_path, 'r') as log: > +for line in log: > +if 'log_check' in line: > +continue > + > +if 'unsatisfied recommendation for' in line: > +bb.warn('[log_check] %s: %s' % (d.getVar('PN', True), line)) > +} -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 2/2] rootfs-postcommands: add test for unsatisfied RRECOMMENDS
The do_rootfs log contains a number of unsatisfied package recommendations. At the moment those are only visible when reviewing the rootfs log. This patch adds an extra check to surface any unsatisfied recommendation as WARNINGS to the build output when "debug-tweaks" is enabled. Signed-off-by: Jose Alarcon--- meta/classes/rootfs-postcommands.bbclass | 15 +++ 1 file changed, 15 insertions(+) diff --git a/meta/classes/rootfs-postcommands.bbclass b/meta/classes/rootfs-postcommands.bbclass index fb36bad..e7ef382 100644 --- a/meta/classes/rootfs-postcommands.bbclass +++ b/meta/classes/rootfs-postcommands.bbclass @@ -50,6 +50,9 @@ python () { d.appendVar('ROOTFS_POSTPROCESS_COMMAND', '${SORT_PASSWD_POSTPROCESS_COMMAND}') } +# Enable QA check for unsatisfied recommendations if debug-tweaks is enabled +ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains_any("IMAGE_FEATURES", "debug-tweaks", "rootfs_log_check_recommends; ", "",d)}' + systemd_create_users () { for conffile in ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd.conf ${IMAGE_ROOTFS}/usr/lib/sysusers.d/systemd-remote.conf; do [ -e $conffile ] || continue @@ -307,3 +310,15 @@ python write_image_test_data() { os.remove(testdata_link) os.symlink(os.path.basename(testdata), testdata_link) } + +# Check for unsatisfied recommendations (RRECOMMENDS) +python rootfs_log_check_recommends() { +log_path = d.expand("${T}/log.do_rootfs") +with open(log_path, 'r') as log: +for line in log: +if 'log_check' in line: +continue + +if 'unsatisfied recommendation for' in line: +bb.warn('[log_check] %s: %s' % (d.getVar('PN', True), line)) +} -- 2.10.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core