Re: [OE-core] [PATCH 3/4] gtk+3: Set depends to the virtual needed not explicitly on Mesa

2019-09-16 Thread Andrew F. Davis via Openembedded-core 
On 9/16/19 6:27 PM, Richard Purdie wrote:
> On Fri, 2019-09-13 at 15:36 -0400, Andrew F. Davis via Openembedded-core 
> wrote:
>> The dependency is for EGL and GLES2 libraries. On some systems these
>> are not provided by Mesa, list what is actually needed so the system
>> can choose the correct provider.
>>
>> Signed-off-by: Andrew F. Davis 
>> ---
>>  meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc 
>> b/meta/recipes-gnome/gtk+/gtk+3.inc
>> index 77b6c31536..7ec40dcbf5 100644
>> --- a/meta/recipes-gnome/gtk+/gtk+3.inc
>> +++ b/meta/recipes-gnome/gtk+/gtk+3.inc
>> @@ -52,7 +52,7 @@ PACKAGECONFIG[x11] = 
>> "--enable-x11-backend,--disable-x11-backend,at-spi2-atk fon
>>  # this is provided by oe-core patch that removes epoxy/gl dependency from a 
>> X11 build
>>  PACKAGECONFIG[opengl] = "--enable-opengl,--disable-opengl,libepoxy"
>>  PACKAGECONFIG[glx] = "--enable-glx,--disable-glx,,libgl"
>> -PACKAGECONFIG[wayland] = 
>> "--enable-wayland-backend,--disable-wayland-backend,wayland 
>> wayland-protocols libxkbcommon virtual/mesa wayland-native"
>> +PACKAGECONFIG[wayland] = 
>> "--enable-wayland-backend,--disable-wayland-backend,wayland 
>> wayland-protocols libxkbcommon virtual/egl virtual/gles2 wayland-native"
>>  PACKAGECONFIG[cups] = "--enable-cups,--disable-cups,cups"
>>  
>>  prepare_gtk_scripts() {
> 
> This breaks things:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/57/builds/1037
> 
> step1b: ERROR: Nothing PROVIDES 'virtual/gles2' (but 
> /home/pokybuild/yocto-worker/qemux86-64-x32/build/meta/recipes-gnome/gtk+/gtk+3_3.24.8.bb
>  DEPENDS on or otherwise requires it). Close matches:
> 

Thanks for the heads up. Copy/merge error on my part, the correct target
is "virtual/libgles2", same typo on patch 4/4, will re-send updated v2.

Thanks,
Andrew

> Cheers,
> 
> Richard
> 
> 
> 
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/4] gtk+3: Set depends to the virtual needed not explicitly on Mesa

2019-09-16 Thread Richard Purdie 
On Fri, 2019-09-13 at 15:36 -0400, Andrew F. Davis via Openembedded-core wrote:
> The dependency is for EGL and GLES2 libraries. On some systems these
> are not provided by Mesa, list what is actually needed so the system
> can choose the correct provider.
> 
> Signed-off-by: Andrew F. Davis 
> ---
>  meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc 
> b/meta/recipes-gnome/gtk+/gtk+3.inc
> index 77b6c31536..7ec40dcbf5 100644
> --- a/meta/recipes-gnome/gtk+/gtk+3.inc
> +++ b/meta/recipes-gnome/gtk+/gtk+3.inc
> @@ -52,7 +52,7 @@ PACKAGECONFIG[x11] = 
> "--enable-x11-backend,--disable-x11-backend,at-spi2-atk fon
>  # this is provided by oe-core patch that removes epoxy/gl dependency from a 
> X11 build
>  PACKAGECONFIG[opengl] = "--enable-opengl,--disable-opengl,libepoxy"
>  PACKAGECONFIG[glx] = "--enable-glx,--disable-glx,,libgl"
> -PACKAGECONFIG[wayland] = 
> "--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols 
> libxkbcommon virtual/mesa wayland-native"
> +PACKAGECONFIG[wayland] = 
> "--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols 
> libxkbcommon virtual/egl virtual/gles2 wayland-native"
>  PACKAGECONFIG[cups] = "--enable-cups,--disable-cups,cups"
>  
>  prepare_gtk_scripts() {

This breaks things:

https://autobuilder.yoctoproject.org/typhoon/#/builders/57/builds/1037

step1b: ERROR: Nothing PROVIDES 'virtual/gles2' (but 
/home/pokybuild/yocto-worker/qemux86-64-x32/build/meta/recipes-gnome/gtk+/gtk+3_3.24.8.bb
 DEPENDS on or otherwise requires it). Close matches:

Cheers,

Richard



-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 3/4] gtk+3: Set depends to the virtual needed not explicitly on Mesa

2019-09-13 Thread Andrew F. Davis via Openembedded-core 
The dependency is for EGL and GLES2 libraries. On some systems these
are not provided by Mesa, list what is actually needed so the system
can choose the correct provider.

Signed-off-by: Andrew F. Davis 
---
 meta/recipes-gnome/gtk+/gtk+3.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc 
b/meta/recipes-gnome/gtk+/gtk+3.inc
index 77b6c31536..7ec40dcbf5 100644
--- a/meta/recipes-gnome/gtk+/gtk+3.inc
+++ b/meta/recipes-gnome/gtk+/gtk+3.inc
@@ -52,7 +52,7 @@ PACKAGECONFIG[x11] = 
"--enable-x11-backend,--disable-x11-backend,at-spi2-atk fon
 # this is provided by oe-core patch that removes epoxy/gl dependency from a 
X11 build
 PACKAGECONFIG[opengl] = "--enable-opengl,--disable-opengl,libepoxy"
 PACKAGECONFIG[glx] = "--enable-glx,--disable-glx,,libgl"
-PACKAGECONFIG[wayland] = 
"--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols 
libxkbcommon virtual/mesa wayland-native"
+PACKAGECONFIG[wayland] = 
"--enable-wayland-backend,--disable-wayland-backend,wayland wayland-protocols 
libxkbcommon virtual/egl virtual/gles2 wayland-native"
 PACKAGECONFIG[cups] = "--enable-cups,--disable-cups,cups"
 
 prepare_gtk_scripts() {
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core