[OE-core] [PATCH 4/4] insane.bbclass: quiet package errors not in *_QA

2013-06-10 Thread Christopher Larson
From: Christopher Larson chris_lar...@mentor.com

Currently, if a package QA type from package.bbclass is not listed in
ERROR_QA, it gets shown, regardless of whether it's in WARN_QA. This differs
from the behavior of the rest of the QA handling (which doesn't call
package_qa_handle_error at all if it's in neither _QA variable), and is
nonintuitive. Change this to use bb.note() if it's listed neither in ERROR_QA
nor WARN_QA, so it ends up in the task logs, but doesn't clutter up the user's
output.

Signed-off-by: Christopher Larson chris_lar...@mentor.com
---
 meta/classes/insane.bbclass | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index c091005..2b30538 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -143,9 +143,11 @@ def package_qa_handle_error(error_class, error_msg, d):
 bb.error(QA Issue: %s % error_msg)
 d.setVar(QA_SANE, False)
 return False
-else:
+elif error_class in (d.getVar(WARN_QA, True) or ).split():
 bb.warn(QA Issue: %s % error_msg)
-return True
+else:
+bb.note(QA Issue: %s % error_msg)
+return True
 
 QAPATHTEST[libexec] = package_qa_check_libexec
 def package_qa_check_libexec(path,name, d, elf, messages):
-- 
1.8.3

___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 4/4] insane.bbclass: quiet package errors not in *_QA

2013-06-10 Thread Otavio Salvador
On Mon, Jun 10, 2013 at 5:47 PM, Christopher Larson kerg...@gmail.comwrote:

 From: Christopher Larson chris_lar...@mentor.com

 Currently, if a package QA type from package.bbclass is not listed in
 ERROR_QA, it gets shown, regardless of whether it's in WARN_QA. This
 differs
 from the behavior of the rest of the QA handling (which doesn't call
 package_qa_handle_error at all if it's in neither _QA variable), and is
 nonintuitive. Change this to use bb.note() if it's listed neither in
 ERROR_QA
 nor WARN_QA, so it ends up in the task logs, but doesn't clutter up the
 user's
 output.

 Signed-off-by: Christopher Larson chris_lar...@mentor.com



Reviewed-by: Otavio Salvador ota...@ossystems.com.br

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core