Re: [OE-core] [PATCH 7/8] populate_sdk_ext.bbclass: remove the try...finally

2018-03-13 Thread Robert Yang
On 03/13/2018 10:57 PM, Richard Purdie wrote: On Tue, 2018-03-13 at 11:24 +0800, Robert Yang wrote: The "sdkbasepath + '/conf/local.conf.bak" doesn't exist when "oe.copy_buildsystem.check_sstate_task_list()" fails, then os.replace() would raise FileNotFoundError, which overcomes the real

Re: [OE-core] [PATCH 7/8] populate_sdk_ext.bbclass: remove the try...finally

2018-03-13 Thread Richard Purdie
On Tue, 2018-03-13 at 11:24 +0800, Robert Yang wrote: > The "sdkbasepath + '/conf/local.conf.bak" doesn't exist when > "oe.copy_buildsystem.check_sstate_task_list()" fails, then > os.replace() would > raise FileNotFoundError, which overcomes the real error. Keep the > error status > makes debug

[OE-core] [PATCH 7/8] populate_sdk_ext.bbclass: remove the try...finally

2018-03-12 Thread Robert Yang
The "sdkbasepath + '/conf/local.conf.bak" doesn't exist when "oe.copy_buildsystem.check_sstate_task_list()" fails, then os.replace() would raise FileNotFoundError, which overcomes the real error. Keep the error status makes debug easier, so remove the try..finally. Signed-off-by: Robert Yang