Re: [OE-core] [PATCH v2] Systemd: Add pattern matching support to PACKAGECONFIG

2019-03-27 Thread Vincent Prince
Hi Pierre-Jean,

Thanks for your review, I'll rework commit log in V3 tomorrow,

Regards,
Vincent

Le mer. 27 mars 2019 à 16:57, TEXIER Pierre-Jean  a
écrit :

> Hi Vincent,
>
> Le mer. 27 mars 2019 à 16:45, Vincent Prince 
> a écrit :
>
>> libpcre2 is needed to enable grep option to journalctl.
>>
>> Changes in v2:
>> - Fix false case option
>>
>> Signed-off-by: Vincent Prince 
>> ---
>>  meta/recipes-core/systemd/systemd_241.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>
> The changelog should be added below the "---" line in the patch,
> this allows to not get included into the actual commit log.
>
> Pierre-Jean
>
>
>> diff --git a/meta/recipes-core/systemd/systemd_241.bb
>> b/meta/recipes-core/systemd/systemd_241.bb
>> index a12b9ab..bfbfc81 100644
>> --- a/meta/recipes-core/systemd/systemd_241.bb
>> +++ b/meta/recipes-core/systemd/systemd_241.bb
>> @@ -151,6 +151,7 @@ PACKAGECONFIG[nss-mymachines] =
>> "-Dnss-mymachines=true,-Dnss-mymachines=false"
>>  PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=true,-Dnss-resolve=false"
>>  PACKAGECONFIG[openssl] = "-Dopenssl=true,-Dopenssl=false,openssl"
>>  PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam,${PAM_PLUGINS}"
>> +PACKAGECONFIG[pcre2] = "-Dpcre2=true,-Dpcre2=false,libpcre2"
>>  PACKAGECONFIG[polkit] = "-Dpolkit=true,-Dpolkit=false"
>>  PACKAGECONFIG[portabled] = "-Dportabled=true,-Dportabled=false"
>>  PACKAGECONFIG[qrencode] = "-Dqrencode=true,-Dqrencode=false,qrencode"
>> --
>> 2.7.4
>>
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v2] Systemd: Add pattern matching support to PACKAGECONFIG

2019-03-27 Thread TEXIER Pierre-Jean
Hi Vincent,

Le mer. 27 mars 2019 à 16:45, Vincent Prince 
a écrit :

> libpcre2 is needed to enable grep option to journalctl.
>
> Changes in v2:
> - Fix false case option
>
> Signed-off-by: Vincent Prince 
> ---
>  meta/recipes-core/systemd/systemd_241.bb | 1 +
>  1 file changed, 1 insertion(+)
>

The changelog should be added below the "---" line in the patch,
this allows to not get included into the actual commit log.

Pierre-Jean


> diff --git a/meta/recipes-core/systemd/systemd_241.bb
> b/meta/recipes-core/systemd/systemd_241.bb
> index a12b9ab..bfbfc81 100644
> --- a/meta/recipes-core/systemd/systemd_241.bb
> +++ b/meta/recipes-core/systemd/systemd_241.bb
> @@ -151,6 +151,7 @@ PACKAGECONFIG[nss-mymachines] =
> "-Dnss-mymachines=true,-Dnss-mymachines=false"
>  PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=true,-Dnss-resolve=false"
>  PACKAGECONFIG[openssl] = "-Dopenssl=true,-Dopenssl=false,openssl"
>  PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam,${PAM_PLUGINS}"
> +PACKAGECONFIG[pcre2] = "-Dpcre2=true,-Dpcre2=false,libpcre2"
>  PACKAGECONFIG[polkit] = "-Dpolkit=true,-Dpolkit=false"
>  PACKAGECONFIG[portabled] = "-Dportabled=true,-Dportabled=false"
>  PACKAGECONFIG[qrencode] = "-Dqrencode=true,-Dqrencode=false,qrencode"
> --
> 2.7.4
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v2] Systemd: Add pattern matching support to PACKAGECONFIG

2019-03-27 Thread Vincent Prince
libpcre2 is needed to enable grep option to journalctl.

Changes in v2:
- Fix false case option

Signed-off-by: Vincent Prince 
---
 meta/recipes-core/systemd/systemd_241.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/systemd/systemd_241.bb 
b/meta/recipes-core/systemd/systemd_241.bb
index a12b9ab..bfbfc81 100644
--- a/meta/recipes-core/systemd/systemd_241.bb
+++ b/meta/recipes-core/systemd/systemd_241.bb
@@ -151,6 +151,7 @@ PACKAGECONFIG[nss-mymachines] = 
"-Dnss-mymachines=true,-Dnss-mymachines=false"
 PACKAGECONFIG[nss-resolve] = "-Dnss-resolve=true,-Dnss-resolve=false"
 PACKAGECONFIG[openssl] = "-Dopenssl=true,-Dopenssl=false,openssl"
 PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam,${PAM_PLUGINS}"
+PACKAGECONFIG[pcre2] = "-Dpcre2=true,-Dpcre2=false,libpcre2"
 PACKAGECONFIG[polkit] = "-Dpolkit=true,-Dpolkit=false"
 PACKAGECONFIG[portabled] = "-Dportabled=true,-Dportabled=false"
 PACKAGECONFIG[qrencode] = "-Dqrencode=true,-Dqrencode=false,qrencode"
-- 
2.7.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core