Re: [OE-core] [PATCH v2] buildhistory.bbclass: create the buildhistory directory when needed
Great, thanks!
Steve Sakoman escreveu no dia quinta, 3/03/2022 à(s)
14:49:
> On Wed, Mar 2, 2022 at 2:07 PM Jose Quaresma
> wrote:
> >
> > Can this patch be backported to dunfell?
>
> I've added it to my test queue.
>
> Steve
>
> >
> > Jose
> >
> > Jose Quaresma via lists.openembedded.org gmail@lists.openembedded.org> escreveu no dia quarta, 2/03/2022 à(s)
> 00:47:
> >>
> >> When the BUILDHISTORY_RESET is enabled we need to move the
> >> content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but
> >> when we start a clean build in the first run we don't have the
> >> BUILDHISTORY_DIR so the move of files will fail.
> >>
> >> | ERROR: Command execution failed: Traceback (most recent call last):
> >> | File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in
> runAsyncCommand
> >> |commandmethod(self.cmds_async, self, options)
> >> | File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
> >> |command.cooker.buildTargets(pkgs_to_build, task)
> >> | File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
> >> |bb.event.fire(bb.event.BuildStarted(buildname, ntargets),
> self.databuilder.mcdata[mc])
> >> | File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line
> 214, in fire
> >> |fire_class_handlers(event, d)
> >> | File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in
> fire_class_handlers
> >> |execute_handler(name, handler, event, d)
> >> | File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
> >> |ret = handler(event)
> >> | File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in
> buildhistory_eventhandler
> >> |entries = [ x for x in os.listdir(rootdir) if not
> x.startswith('.') ]
> >> | FileNotFoundError: [Errno 2] No such file or directory:
> '/xxx/buildhistory'
> >>
> >> Signed-off-by: Jose Quaresma
> >> ---
> >> V2: remove the check to see if the directory exists
> >>
> >> meta/classes/buildhistory.bbclass | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/classes/buildhistory.bbclass
> b/meta/classes/buildhistory.bbclass
> >> index 49797a6701..8db79a4829 100644
> >> --- a/meta/classes/buildhistory.bbclass
> >> +++ b/meta/classes/buildhistory.bbclass
> >> @@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
> >> if os.path.isdir(olddir):
> >> shutil.rmtree(olddir)
> >> rootdir = e.data.getVar("BUILDHISTORY_DIR")
> >> +bb.utils.mkdirhier(rootdir)
> >> entries = [ x for x in os.listdir(rootdir) if not
> x.startswith('.') ]
> >> bb.utils.mkdirhier(olddir)
> >> for entry in entries:
> >> --
> >> 2.35.1
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Best regards,
> >
> > José Quaresma
>
--
Best regards,
José Quaresma
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162660):
https://lists.openembedded.org/g/openembedded-core/message/162660
Mute This Topic: https://lists.openembedded.org/mt/89491842/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] buildhistory.bbclass: create the buildhistory directory when needed
On Wed, Mar 2, 2022 at 2:07 PM Jose Quaresma wrote:
>
> Can this patch be backported to dunfell?
I've added it to my test queue.
Steve
>
> Jose
>
> Jose Quaresma via lists.openembedded.org
> escreveu no dia quarta,
> 2/03/2022 à(s) 00:47:
>>
>> When the BUILDHISTORY_RESET is enabled we need to move the
>> content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but
>> when we start a clean build in the first run we don't have the
>> BUILDHISTORY_DIR so the move of files will fail.
>>
>> | ERROR: Command execution failed: Traceback (most recent call last):
>> | File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in runAsyncCommand
>> |commandmethod(self.cmds_async, self, options)
>> | File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
>> |command.cooker.buildTargets(pkgs_to_build, task)
>> | File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
>> |bb.event.fire(bb.event.BuildStarted(buildname, ntargets),
>> self.databuilder.mcdata[mc])
>> | File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line 214,
>> in fire
>> |fire_class_handlers(event, d)
>> | File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in fire_class_handlers
>> |execute_handler(name, handler, event, d)
>> | File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
>> |ret = handler(event)
>> | File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in
>> buildhistory_eventhandler
>> |entries = [ x for x in os.listdir(rootdir) if not x.startswith('.') ]
>> | FileNotFoundError: [Errno 2] No such file or directory: '/xxx/buildhistory'
>>
>> Signed-off-by: Jose Quaresma
>> ---
>> V2: remove the check to see if the directory exists
>>
>> meta/classes/buildhistory.bbclass | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/buildhistory.bbclass
>> b/meta/classes/buildhistory.bbclass
>> index 49797a6701..8db79a4829 100644
>> --- a/meta/classes/buildhistory.bbclass
>> +++ b/meta/classes/buildhistory.bbclass
>> @@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
>> if os.path.isdir(olddir):
>> shutil.rmtree(olddir)
>> rootdir = e.data.getVar("BUILDHISTORY_DIR")
>> +bb.utils.mkdirhier(rootdir)
>> entries = [ x for x in os.listdir(rootdir) if not
>> x.startswith('.') ]
>> bb.utils.mkdirhier(olddir)
>> for entry in entries:
>> --
>> 2.35.1
>>
>>
>>
>>
>
>
> --
> Best regards,
>
> José Quaresma
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162657):
https://lists.openembedded.org/g/openembedded-core/message/162657
Mute This Topic: https://lists.openembedded.org/mt/89491842/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] buildhistory.bbclass: create the buildhistory directory when needed
Can this patch be backported to dunfell?
Jose
Jose Quaresma via lists.openembedded.org escreveu no dia quarta, 2/03/2022 à(s)
00:47:
> When the BUILDHISTORY_RESET is enabled we need to move the
> content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but
> when we start a clean build in the first run we don't have the
> BUILDHISTORY_DIR so the move of files will fail.
>
> | ERROR: Command execution failed: Traceback (most recent call last):
> | File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in runAsyncCommand
> |commandmethod(self.cmds_async, self, options)
> | File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
> |command.cooker.buildTargets(pkgs_to_build, task)
> | File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
> |bb.event.fire(bb.event.BuildStarted(buildname, ntargets),
> self.databuilder.mcdata[mc])
> | File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line
> 214, in fire
> |fire_class_handlers(event, d)
> | File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in
> fire_class_handlers
> |execute_handler(name, handler, event, d)
> | File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
> |ret = handler(event)
> | File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in
> buildhistory_eventhandler
> |entries = [ x for x in os.listdir(rootdir) if not x.startswith('.') ]
> | FileNotFoundError: [Errno 2] No such file or directory:
> '/xxx/buildhistory'
>
> Signed-off-by: Jose Quaresma
> ---
> V2: remove the check to see if the directory exists
>
> meta/classes/buildhistory.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/buildhistory.bbclass
> b/meta/classes/buildhistory.bbclass
> index 49797a6701..8db79a4829 100644
> --- a/meta/classes/buildhistory.bbclass
> +++ b/meta/classes/buildhistory.bbclass
> @@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
> if os.path.isdir(olddir):
> shutil.rmtree(olddir)
> rootdir = e.data.getVar("BUILDHISTORY_DIR")
> +bb.utils.mkdirhier(rootdir)
> entries = [ x for x in os.listdir(rootdir) if not
> x.startswith('.') ]
> bb.utils.mkdirhier(olddir)
> for entry in entries:
> --
> 2.35.1
>
>
>
>
>
--
Best regards,
José Quaresma
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162631):
https://lists.openembedded.org/g/openembedded-core/message/162631
Mute This Topic: https://lists.openembedded.org/mt/89491842/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v2] buildhistory.bbclass: create the buildhistory directory when needed
When the BUILDHISTORY_RESET is enabled we need to move the
content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but
when we start a clean build in the first run we don't have the
BUILDHISTORY_DIR so the move of files will fail.
| ERROR: Command execution failed: Traceback (most recent call last):
| File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in runAsyncCommand
|commandmethod(self.cmds_async, self, options)
| File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
|command.cooker.buildTargets(pkgs_to_build, task)
| File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
|bb.event.fire(bb.event.BuildStarted(buildname, ntargets),
self.databuilder.mcdata[mc])
| File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line 214, in
fire
|fire_class_handlers(event, d)
| File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in fire_class_handlers
|execute_handler(name, handler, event, d)
| File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
|ret = handler(event)
| File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in
buildhistory_eventhandler
|entries = [ x for x in os.listdir(rootdir) if not x.startswith('.') ]
| FileNotFoundError: [Errno 2] No such file or directory: '/xxx/buildhistory'
Signed-off-by: Jose Quaresma
---
V2: remove the check to see if the directory exists
meta/classes/buildhistory.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/buildhistory.bbclass
b/meta/classes/buildhistory.bbclass
index 49797a6701..8db79a4829 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
if os.path.isdir(olddir):
shutil.rmtree(olddir)
rootdir = e.data.getVar("BUILDHISTORY_DIR")
+bb.utils.mkdirhier(rootdir)
entries = [ x for x in os.listdir(rootdir) if not
x.startswith('.') ]
bb.utils.mkdirhier(olddir)
for entry in entries:
--
2.35.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162587):
https://lists.openembedded.org/g/openembedded-core/message/162587
Mute This Topic: https://lists.openembedded.org/mt/89491842/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
