Re: [OE-core] [PATCH v2] insane: add sanity checks to SRC_URI

2019-05-23 Thread Alexander Kanavin
On Thu, 23 May 2019 at 00:24, Richard Purdie wrote: > Ultimately I'd say that all these checks should work with INSANE_SKIP. > I was just wondering about this issue myself for the chkconfig > autobuilder warnings... chkconfig can be easily addressed by switching to git:// I think. Patch coming.

Re: [OE-core] [PATCH v2] insane: add sanity checks to SRC_URI

2019-05-22 Thread Richard Purdie
On Wed, 2019-05-22 at 17:48 +0200, Martin Jansa wrote: > Can we add an option to skip this with INSANE_SKIP? > > It looks like QARECIPETEST doesn't use INSANE_SKIP or I don't see > how. > > Removing src-uri-bad from ERROR_QA/WARN_QA for some recipes works as > well, is it worth adding

Re: [OE-core] [PATCH v2] insane: add sanity checks to SRC_URI

2019-05-22 Thread Martin Jansa
Can we add an option to skip this with INSANE_SKIP? It looks like QARECIPETEST doesn't use INSANE_SKIP or I don't see how. Removing src-uri-bad from ERROR_QA/WARN_QA for some recipes works as well, is it worth adding INSANE_SKIP for consistency with other checks or not? On Sat, May 18, 2019 at

Re: [OE-core] [PATCH v2] insane: add sanity checks to SRC_URI

2019-05-18 Thread Adrian Bunk
On Fri, May 17, 2019 at 04:37:43PM -0700, Ross Burton wrote: > The SRC_URI almost definitely shouldn't be using ${PN}, and GitHub */archive/* > tarballs are dynamically generated so the checksums will change over time. >... It might be worth mentioning that this is for archive, not releases.

[OE-core] [PATCH v2] insane: add sanity checks to SRC_URI

2019-05-17 Thread Ross Burton
The SRC_URI almost definitely shouldn't be using ${PN}, and GitHub */archive/* tarballs are dynamically generated so the checksums will change over time. Detect both of these, and emit a QA warning if found. Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 13 - 1 file