Re: [OE-core] [PATCH v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error

2019-06-10 Thread Douglas Royds via Openembedded-core
Please disregard this one, I've sent a recipe update to pick up the new --disable-werror configure option. -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error

2019-06-09 Thread Burton, Ross
FWIW, this just landed in json-c master: https://github.com/json-c/json-c/commit/07ea04e65193c3e5c902c5b79421d5fa48ff67c7 "build: add option --disable-werror to configure" Ross On Fri, 7 Jun 2019 at 12:20, Burton, Ross wrote: > > FWIW I still believe that just patching out -Werror is the

Re: [OE-core] [PATCH v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error

2019-06-07 Thread Burton, Ross
FWIW I still believe that just patching out -Werror is the correct fix here. To be honest I'm really close to writing a QA check that -Werror and friends isn't being used at all... Filed https://github.com/json-c/json-c/issues/489 in the hope that upstream will handle it. Ross On Fri, 7 Jun

[OE-core] [PATCH v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error

2019-06-06 Thread Douglas Royds via Openembedded-core
icecc preprocesses source files locally before shipping them off to be compiled on remote hosts. This preprocessing removes comments, including /* fallthrough */ comments in switch statements that normally prevent the implicit-fallthrough warning. Rather than turning off -Werror by patching