Re: [OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-16 Thread Ola x Nilsson

Seems I have my work cut out for me.  Thanks for the feedback.

/Ola

On Mon, Jan 15 2024, Alexander Kanavin wrote:

> I guess the patch needs to be adjusted to suppress the warnings from here?
> https://git.yoctoproject.org/poky/tree/meta/conf/distro/include/time64.inc
> Any suppressions should come with upstream ticket links.
>
> Better yet, make patches to address the issues. Seems like there's not
> a lot of them.
>
> Alex
>
> On Mon, 15 Jan 2024 at 17:55, Alexandre Belloni via
> lists.openembedded.org
>  wrote:
>>
>> This causes a bunch of warnings on the autobuilders:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/8306/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/5587/steps/11/logs/warnings
>>
>> stdio: WARNING: lib32-openssh-9.5p1-r0 do_package_qa: QA Issue: 
>> /usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
>> stdio: WARNING: lib32-python3-numpy-1.26.2-r0 do_package_qa: QA Issue: 
>> /usr/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-i386-linux-gnu.so
>>  uses 32-bit api 'fallocate'
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/8499/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/5675/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/8382/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/8363/steps/13/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/7305/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/160/builds/295/steps/12/logs/warnings
>>
>> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: /usr/sbin/sshd 
>> uses 32-bit api 'mkstemp'
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/7404/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/7327/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/107/builds/5743/steps/13/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/7174/steps/13/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/2749/steps/21/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/8386/steps/13/logs/warnings
>>
>> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
>> /usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/8436/steps/12/logs/warnings
>>
>> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
>> /usr/lib/openssh/ptest/regress/unittests/hostkeys/test_hostkeys uses 32-bit 
>> api 'mkstemp'
>>
>>
>> On 12/01/2024 16:14:02+0100, Ola x Nilsson wrote:
>> > Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check
>> > for functions redirected only based on _FILE_OFFSET_BITS and
>> > __USE_FILE_OFFSET64.
>> >
>> > Signed-off-by: Ola x Nilsson 
>> > ---
>> >  meta/classes-global/insane.bbclass | 31 ++
>> >  1 file changed, 31 insertions(+)
>> >
>> > diff --git a/meta/classes-global/insane.bbclass 
>> > b/meta/classes-global/insane.bbclass
>> > index 69741a6a79..1ff6a319c4 100644
>> > --- a/meta/classes-global/insane.bbclass
>> > +++ b/meta/classes-global/insane.bbclass
>> > @@ -598,6 +598,37 @@ def check_32bit_symbols(path, packagename, d, elf, 
>> > messages):
>> >  "fts_set",
>> >  # /usr/include/netdb.h
>> >  "gai_suspend",
>> > +
>> > +# Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64,
>> > +# also check for functions redirected only based on 
>> > _FILE_OFFSET_BITS
>> > +# and __USE_FILE_OFFSET64
>> > +# /usr/include/bits/fcntl-linux.h
>> > +"fallocate",
>> > +# /usr/include/bits/resource.h
>> > +"prlimit",
>> > +# /usr/include/sys/statfs.h
>> > +"statfs", "fstatfs", "statvfs", "fstatvfs",
>> > +# /usr/include/sys/sendfile.h
>> > +"sendfile",
>> > +# /usr/include/sys/resource.h
>> > +"getrlimit", "setrlimit",
>> > +# /usr/include/sys/uio.h
>> > +"preadv", "pwritev", "preadv2", "pwritev2",
>> > +# /usr/include/sys/mman.h
>> > +"mmap",
>> > +# /usr/include/stdlib.h
>> > +"mkstemp", "mkstemps", "mkostemp", "mkostemps",
>> > +# /usr/include/stdio.h
>> > +"fopen", "tmpfile", "freopen", "fseeko", "ftello", "fgetpos",
>> > +"fsetpos",
>> > +# /usr/include/dirent.h
>> > +"readdir",
>> > +"readdir_r", "scandir", "scandirat", "alphasort", "getdirentries",
>> > +"versionsort",
>> > +# /usr/include/unistd.h
>> > +"lseek", "pread", "pwrite", "truncate", "ftruncate", "lockf",
>> > +# /usr/include/fcntl.h
>> > +"open", "openat", "creat", "posix_fadvise", "posix_fallocate",
>> >  

Re: [OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-15 Thread Alexander Kanavin
I guess the patch needs to be adjusted to suppress the warnings from here?
https://git.yoctoproject.org/poky/tree/meta/conf/distro/include/time64.inc
Any suppressions should come with upstream ticket links.

Better yet, make patches to address the issues. Seems like there's not
a lot of them.

Alex

On Mon, 15 Jan 2024 at 17:55, Alexandre Belloni via
lists.openembedded.org
 wrote:
>
> This causes a bunch of warnings on the autobuilders:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/8306/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/5587/steps/11/logs/warnings
>
> stdio: WARNING: lib32-openssh-9.5p1-r0 do_package_qa: QA Issue: 
> /usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
> stdio: WARNING: lib32-python3-numpy-1.26.2-r0 do_package_qa: QA Issue: 
> /usr/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-i386-linux-gnu.so
>  uses 32-bit api 'fallocate'
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/8499/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/5675/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/8382/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/8363/steps/13/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/7305/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/160/builds/295/steps/12/logs/warnings
>
> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: /usr/sbin/sshd uses 
> 32-bit api 'mkstemp'
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/7404/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/7327/steps/12/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/107/builds/5743/steps/13/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/7174/steps/13/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/2749/steps/21/logs/warnings
> https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/8386/steps/13/logs/warnings
>
> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
> /usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/8436/steps/12/logs/warnings
>
> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
> /usr/lib/openssh/ptest/regress/unittests/hostkeys/test_hostkeys uses 32-bit 
> api 'mkstemp'
>
>
> On 12/01/2024 16:14:02+0100, Ola x Nilsson wrote:
> > Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check
> > for functions redirected only based on _FILE_OFFSET_BITS and
> > __USE_FILE_OFFSET64.
> >
> > Signed-off-by: Ola x Nilsson 
> > ---
> >  meta/classes-global/insane.bbclass | 31 ++
> >  1 file changed, 31 insertions(+)
> >
> > diff --git a/meta/classes-global/insane.bbclass 
> > b/meta/classes-global/insane.bbclass
> > index 69741a6a79..1ff6a319c4 100644
> > --- a/meta/classes-global/insane.bbclass
> > +++ b/meta/classes-global/insane.bbclass
> > @@ -598,6 +598,37 @@ def check_32bit_symbols(path, packagename, d, elf, 
> > messages):
> >  "fts_set",
> >  # /usr/include/netdb.h
> >  "gai_suspend",
> > +
> > +# Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64,
> > +# also check for functions redirected only based on 
> > _FILE_OFFSET_BITS
> > +# and __USE_FILE_OFFSET64
> > +# /usr/include/bits/fcntl-linux.h
> > +"fallocate",
> > +# /usr/include/bits/resource.h
> > +"prlimit",
> > +# /usr/include/sys/statfs.h
> > +"statfs", "fstatfs", "statvfs", "fstatvfs",
> > +# /usr/include/sys/sendfile.h
> > +"sendfile",
> > +# /usr/include/sys/resource.h
> > +"getrlimit", "setrlimit",
> > +# /usr/include/sys/uio.h
> > +"preadv", "pwritev", "preadv2", "pwritev2",
> > +# /usr/include/sys/mman.h
> > +"mmap",
> > +# /usr/include/stdlib.h
> > +"mkstemp", "mkstemps", "mkostemp", "mkostemps",
> > +# /usr/include/stdio.h
> > +"fopen", "tmpfile", "freopen", "fseeko", "ftello", "fgetpos",
> > +"fsetpos",
> > +# /usr/include/dirent.h
> > +"readdir",
> > +"readdir_r", "scandir", "scandirat", "alphasort", "getdirentries",
> > +"versionsort",
> > +# /usr/include/unistd.h
> > +"lseek", "pread", "pwrite", "truncate", "ftruncate", "lockf",
> > +# /usr/include/fcntl.h
> > +"open", "openat", "creat", "posix_fadvise", "posix_fallocate",
> >  }
> >
> >  ptrn = re.compile(
> > --
> > 2.39.2
> >
>
> >
> >
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You 

Re: [OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-15 Thread Alexandre Belloni via lists.openembedded.org
This causes a bunch of warnings on the autobuilders:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/8306/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/5587/steps/11/logs/warnings

stdio: WARNING: lib32-openssh-9.5p1-r0 do_package_qa: QA Issue: 
/usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
stdio: WARNING: lib32-python3-numpy-1.26.2-r0 do_package_qa: QA Issue: 
/usr/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-i386-linux-gnu.so
 uses 32-bit api 'fallocate'

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/8499/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/5675/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/8382/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/8363/steps/13/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/7305/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/160/builds/295/steps/12/logs/warnings

stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: /usr/sbin/sshd uses 
32-bit api 'mkstemp'

https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/7404/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/7327/steps/12/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/107/builds/5743/steps/13/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/7174/steps/13/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/2749/steps/21/logs/warnings
https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/8386/steps/13/logs/warnings

stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: /usr/bin/ssh-keyscan 
uses 32-bit api 'mkstemp'

https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/8436/steps/12/logs/warnings

stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
/usr/lib/openssh/ptest/regress/unittests/hostkeys/test_hostkeys uses 32-bit api 
'mkstemp'


On 12/01/2024 16:14:02+0100, Ola x Nilsson wrote:
> Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check
> for functions redirected only based on _FILE_OFFSET_BITS and
> __USE_FILE_OFFSET64.
> 
> Signed-off-by: Ola x Nilsson 
> ---
>  meta/classes-global/insane.bbclass | 31 ++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/meta/classes-global/insane.bbclass 
> b/meta/classes-global/insane.bbclass
> index 69741a6a79..1ff6a319c4 100644
> --- a/meta/classes-global/insane.bbclass
> +++ b/meta/classes-global/insane.bbclass
> @@ -598,6 +598,37 @@ def check_32bit_symbols(path, packagename, d, elf, 
> messages):
>  "fts_set",
>  # /usr/include/netdb.h
>  "gai_suspend",
> +
> +# Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64,
> +# also check for functions redirected only based on _FILE_OFFSET_BITS
> +# and __USE_FILE_OFFSET64
> +# /usr/include/bits/fcntl-linux.h
> +"fallocate",
> +# /usr/include/bits/resource.h
> +"prlimit",
> +# /usr/include/sys/statfs.h
> +"statfs", "fstatfs", "statvfs", "fstatvfs",
> +# /usr/include/sys/sendfile.h
> +"sendfile",
> +# /usr/include/sys/resource.h
> +"getrlimit", "setrlimit",
> +# /usr/include/sys/uio.h
> +"preadv", "pwritev", "preadv2", "pwritev2",
> +# /usr/include/sys/mman.h
> +"mmap",
> +# /usr/include/stdlib.h
> +"mkstemp", "mkstemps", "mkostemp", "mkostemps",
> +# /usr/include/stdio.h
> +"fopen", "tmpfile", "freopen", "fseeko", "ftello", "fgetpos",
> +"fsetpos",
> +# /usr/include/dirent.h
> +"readdir",
> +"readdir_r", "scandir", "scandirat", "alphasort", "getdirentries",
> +"versionsort",
> +# /usr/include/unistd.h
> +"lseek", "pread", "pwrite", "truncate", "ftruncate", "lockf",
> +# /usr/include/fcntl.h
> +"open", "openat", "creat", "posix_fadvise", "posix_fallocate",
>  }
>  
>  ptrn = re.compile(
> -- 
> 2.39.2
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193689): 
https://lists.openembedded.org/g/openembedded-core/message/193689
Mute This Topic: https://lists.openembedded.org/mt/103684364/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-12 Thread Ola x Nilsson
Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check
for functions redirected only based on _FILE_OFFSET_BITS and
__USE_FILE_OFFSET64.

Signed-off-by: Ola x Nilsson 
---
 meta/classes-global/insane.bbclass | 31 ++
 1 file changed, 31 insertions(+)

diff --git a/meta/classes-global/insane.bbclass 
b/meta/classes-global/insane.bbclass
index 69741a6a79..1ff6a319c4 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -598,6 +598,37 @@ def check_32bit_symbols(path, packagename, d, elf, 
messages):
 "fts_set",
 # /usr/include/netdb.h
 "gai_suspend",
+
+# Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64,
+# also check for functions redirected only based on _FILE_OFFSET_BITS
+# and __USE_FILE_OFFSET64
+# /usr/include/bits/fcntl-linux.h
+"fallocate",
+# /usr/include/bits/resource.h
+"prlimit",
+# /usr/include/sys/statfs.h
+"statfs", "fstatfs", "statvfs", "fstatvfs",
+# /usr/include/sys/sendfile.h
+"sendfile",
+# /usr/include/sys/resource.h
+"getrlimit", "setrlimit",
+# /usr/include/sys/uio.h
+"preadv", "pwritev", "preadv2", "pwritev2",
+# /usr/include/sys/mman.h
+"mmap",
+# /usr/include/stdlib.h
+"mkstemp", "mkstemps", "mkostemp", "mkostemps",
+# /usr/include/stdio.h
+"fopen", "tmpfile", "freopen", "fseeko", "ftello", "fgetpos",
+"fsetpos",
+# /usr/include/dirent.h
+"readdir",
+"readdir_r", "scandir", "scandirat", "alphasort", "getdirentries",
+"versionsort",
+# /usr/include/unistd.h
+"lseek", "pread", "pwrite", "truncate", "ftruncate", "lockf",
+# /usr/include/fcntl.h
+"open", "openat", "creat", "posix_fadvise", "posix_fallocate",
 }
 
 ptrn = re.compile(
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193589): 
https://lists.openembedded.org/g/openembedded-core/message/193589
Mute This Topic: https://lists.openembedded.org/mt/103684364/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-