Re: [OE-core] [PATCH v2 7/8] oeqa qemurunner.py: kill qemu if it hangs

2023-02-09 Thread Alexander Kanavin
On Thu, 9 Feb 2023 at 10:56, Mikko Rapeli wrote: > It doesn't currently. Should the sigterm_handler() also use SIGKILL if > it has to? Yes please. Let's not duplicate functionality. And please do try to avoid adding hard sleep(), there are usually ways to do things synchronously. Alex

Re: [OE-core] [PATCH v2 7/8] oeqa qemurunner.py: kill qemu if it hangs

2023-02-09 Thread Mikko Rapeli
Hi, On Thu, Feb 09, 2023 at 10:45:36AM +0100, Alexander Kanavin wrote: > Isn't the code waiting 5 seconds and then sending SIGKILL, regardless > of whether SIGTERM was successful or not here? Yes. Not nice but better than leaking the process completely. > I would actually remove this function

Re: [OE-core] [PATCH v2 7/8] oeqa qemurunner.py: kill qemu if it hangs

2023-02-09 Thread Alexander Kanavin
Isn't the code waiting 5 seconds and then sending SIGKILL, regardless of whether SIGTERM was successful or not here? I would actually remove this function altogether. qemu process is started by runqemu and it's the job of that to clean up the actual qemu process properly. Alex On Thu, 9 Feb

[OE-core] [PATCH v2 7/8] oeqa qemurunner.py: kill qemu if it hangs

2023-02-09 Thread Mikko Rapeli
qemu doesn't always behave well and can hang too. kill it with force if was still alive. Signed-off-by: Mikko Rapeli --- meta/lib/oeqa/utils/qemurunner.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py index