On Tue, Jun 11, 2019 at 03:57:23PM +0100, Burton, Ross wrote:
> On Tue, 11 Jun 2019 at 15:56, Quentin Schulz
> wrote:
> > Also, I factored out everything into a function that shouldn't be run as
> > a test but when doing:
> > oe-selftest --run-tests incompatible_lic.IncompatibleLicenseTests
> > it
On Tue, 11 Jun 2019 at 15:55, Burton, Ross wrote:
> Either is fine. Note that in the broken case - where the recipe isn't
> skipped - the test goes ahead and compiles stuff. Can you also try
> using --dry-run to see if that results in the same test behaviour, but
> without attempting compilation
On Tue, 11 Jun 2019 at 15:56, Quentin Schulz
wrote:
> Also, I factored out everything into a function that shouldn't be run as
> a test but when doing:
> oe-selftest --run-tests incompatible_lic.IncompatibleLicenseTests
> it tries to run the function and thus fails the test. Is that okay? if
> not
On Tue, 11 Jun 2019 at 15:52, Quentin Schulz
wrote:
> Sorry for the noise, apparently forgot to pull master and didn't even
> see my patch was already there *sigh*.
>
> I'll remove the import and test on master with and without the patch you
> already merged.
>
> Do you want me to send a v5 or a s
On Tue, Jun 11, 2019 at 04:52:16PM +0200, Quentin Schulz wrote:
> Hi Ross,
>
> On Tue, Jun 11, 2019 at 03:49:31PM +0100, Burton, Ross wrote:
> > On Tue, 11 Jun 2019 at 15:27, Quentin Schulz
> > wrote:
> > > +from oeqa.core.decorator.oeid import OETestID
> >
> > This was removed a while ago, can
Hi Ross,
On Tue, Jun 11, 2019 at 03:49:31PM +0100, Burton, Ross wrote:
> On Tue, 11 Jun 2019 at 15:27, Quentin Schulz
> wrote:
> > +from oeqa.core.decorator.oeid import OETestID
>
> This was removed a while ago, can you rebase the patches on top of
> master please?
>
> In this case you can just
On Tue, 11 Jun 2019 at 15:27, Quentin Schulz
wrote:
> +from oeqa.core.decorator.oeid import OETestID
This was removed a while ago, can you rebase the patches on top of
master please?
In this case you can just remove the import, but please verify the
behaviour with master.
Ross
--
_
One bug went unnoticed without these selftests: an INCOMPATIBLE_LICENSE
with a non-SPDX license for a package with that non-SPDX license wasn't
enforcing the denial of build for said package.
While adding a test for that particular case, let's add a few more so
that we cover a handful more use cas
