Re: [OE-core] [RFC PATCH 14/15] node-red: Add version 2.1.3

2021-11-24 Thread Alexander Kanavin
On Wed, 24 Nov 2021 at 17:53, Stefan Herbrechtsmeier <
stefan.herbrechtsmeier-...@weidmueller.com> wrote:

> I will add tests after we agree on the fetcher and the structure of the
> npm classes. At the moment there are too much possible solution and too
> little feedback.
>

I think it's better to start by thinking how you want to test end-to-end
what you're implementing, and write the tests together with the initial
submission, as they also serve as examples of typical use cases. This also
allows reviewers to experiment with the code and not just passively read
it, as it's otherwise not entirely clear how to actually try it out.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#158727): 
https://lists.openembedded.org/g/openembedded-core/message/158727
Mute This Topic: https://lists.openembedded.org/mt/87282289/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC PATCH 14/15] node-red: Add version 2.1.3

2021-11-24 Thread Stefan Herbrechtsmeier

Am 24.11.2021 um 16:36 schrieb Alexander Kanavin:
I do not think adding the recipe to oe-core like this is quite right, 
and the same holds for patch 15. It's not buildable (as oe-core lacks 
nodejs), it doesn't seem to meet the criteria for core inclusion, and 
generally before we add generated recipes to core, we need to add tests 
that ensure that generation works correctly (e.g. via oe-selftest, where 
a generated recipe would be compared against a reference, and then 
built). So the options are:


This are example recipes to discuess the output of the create_npm.py and 
the structure of a npm recipe.



- move nodejs to oe-core, add the tests
- move all npm/angular/etc classes to meta-oe where nodejs recipe is, 
but add the tests there too - we can figure out when and how to execute 
them, perhaps via meta-oe job on the AB, but first they have to exist.


I will add tests after we agree on the fetcher and the structure of the 
npm classes. At the moment there are too much possible solution and too 
little feedback.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#158725): 
https://lists.openembedded.org/g/openembedded-core/message/158725
Mute This Topic: https://lists.openembedded.org/mt/87282289/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC PATCH 14/15] node-red: Add version 2.1.3

2021-11-24 Thread Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier 

Created via recipetool:
  devtool add --npm-dev node-red 
https://registry.npmjs.org/node-red/-/node-red-2.1.3.tgz

Signed-off-by: Stefan Herbrechtsmeier 
---

 .../node-red/node-red_2.1.3.bb| 908 ++
 1 file changed, 908 insertions(+)
 create mode 100644 meta/recipes-devtools/node-red/node-red_2.1.3.bb

diff --git a/meta/recipes-devtools/node-red/node-red_2.1.3.bb 
b/meta/recipes-devtools/node-red/node-red_2.1.3.bb
new file mode 100644
index 00..b6d9400f98
--- /dev/null
+++ b/meta/recipes-devtools/node-red/node-red_2.1.3.bb
@@ -0,0 +1,908 @@
+# Recipe created by recipetool
+# This is the basis of a recipe and may need further editing in order to be 
fully functional.
+# (Feel free to remove these comments when editing.)
+
+SUMMARY = "Low-code programming for event-driven applications"
+HOMEPAGE = "http://nodered.org";
+# WARNING: the following LICENSE and LIC_FILES_CHKSUM values are best guesses 
- it is
+# your responsibility to verify that the values are complete and correct.
+#
+# NOTE: multiple licenses have been detected; they have been separated with &
+# in the LICENSE value for now since it is a reasonable assumption that all
+# of the licenses apply. If instead there is a choice between the multiple
+# licenses then you should change the value to separate the licenses with |
+# instead of &. If there is any doubt, check the accompanying documentation
+# to determine which situation is applicable.
+LICENSE = "Apache-2.0 & MIT & ISC & ISC & MIT & BSD-3-Clause &  MIT & 
BSD-2-Clause & BSD-0-Clause & ISC & CC-BY-SA-4.0 & BSD-3-Clause & MIT & 
BSD-3-Clause & MPL-2.0 & ISC | MIT"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=d6f37569f5013072e9490d2194d10ae6 \
+
file://node_modules/range-parser/LICENSE;md5=d4246fb961a4f121eef5ffca47f0b010 \
+
file://node_modules/json-buffer/LICENSE;md5=f26ea3f2a31273ebd199d933804f5e8b \
+
file://node_modules/split2/LICENSE;md5=a3b84061387696c9678867c878a6bbc3 \
+
file://node_modules/minimist/LICENSE;md5=aea1cde69645f4b99be4ff7ca9abcce1 \
+
file://node_modules/leven/license;md5=a12ebca0510a773644101a99a867d210 \
+
file://node_modules/normalize-url/license;md5=915042b5df33c31a6db2b37eadaa00e3 \
+
file://node_modules/mute-stream/LICENSE;md5=82703a69f6d7411dde679954c2fd9dca \
+
file://node_modules/content-disposition/LICENSE;md5=13babc4f212ce635d68da544339c962b
 \
+
file://node_modules/oauth2orize/LICENSE;md5=6392ca87973f3c4bfd78b7cd812e289a \
+
file://node_modules/resolve-alpn/LICENSE;md5=f3d086f7c83cdc609b9f5d6057d7c1e4 \
+
file://node_modules/are-we-there-yet/LICENSE.md;md5=1750b360daee1aa920366e344c1b0c57
 \
+
file://node_modules/reinterval/LICENSE;md5=c65ef22a386436c433298ca42418c200 \
+
file://node_modules/passport/LICENSE;md5=a632f82c0eeb821949115ede725c2326 \
+
file://node_modules/path-is-absolute/license;md5=a12ebca0510a773644101a99a867d210
 \
+
file://node_modules/decompress-response/license;md5=d5f2a6dd0192dcc7c833e50bb9017337
 \
+
file://node_modules/decompress-response/node_modules/mimic-response/license;md5=d5f2a6dd0192dcc7c833e50bb9017337
 \
+
file://node_modules/got/license;md5=915042b5df33c31a6db2b37eadaa00e3 \
+
file://node_modules/ipaddr.js/LICENSE;md5=88f60a4b6e44cb849b5d907a7664c0ef \
+
file://node_modules/bl/LICENSE.md;md5=455bc3781a009cf9a615e8622138814c \
+
file://node_modules/bl/node_modules/inherits/LICENSE;md5=5b2ef2247af6d355ae9d9f988092d470
 \
+
file://node_modules/make-dir/license;md5=915042b5df33c31a6db2b37eadaa00e3 \
+
file://node_modules/make-dir/node_modules/semver/LICENSE;md5=82703a69f6d7411dde679954c2fd9dca
 \
+
file://node_modules/sax/LICENSE;md5=326d5674181c4bb210e424772c60fa80 \
+
file://node_modules/acorn-walk/LICENSE;md5=33e8b86a084578431a31c72608f226b8 \
+
file://node_modules/busboy/LICENSE;md5=df3ad145c2acbfc4f246fa834a6675c7 \
+
file://node_modules/busboy/node_modules/string_decoder/LICENSE;md5=fcf5cfdc777e49f11402422c72a86f43
 \
+
file://node_modules/busboy/node_modules/readable-stream/LICENSE;md5=d7351a4fc8e956f1a68413490d5e655e
 \
+
file://node_modules/parse5/LICENSE;md5=179850e04995d6fceaf64f2dd2a851b0 \
+
file://node_modules/type-is/LICENSE;md5=0afd201e48c7d095454eed4ac1184e40 \
+
file://node_modules/type-is/node_modules/media-typer/LICENSE;md5=c6e0ce1e688c5ff16db06b7259e9cd20
 \
+
file://node_modules/memorystore/LICENSE;md5=3c97a7f1928df131f083f488a42c41