Re: [OE-core] [bitbake-devel] [PATCH 2/2] fetch2: Fix race condition in latest_revision

2021-11-10 Thread Jasper Orschulko
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 I believe the behaviour we observed was actually caused by a bug in one of our earlier patch sets. I spent a couple hours today trying to recreate the issue, without any luck. I'd therefore skip this particular patch. - -- With best regards

Re: [OE-core] [bitbake-devel] [PATCH 2/2] fetch2: Fix race condition in latest_revision

2021-11-08 Thread Alexander Kanavin
It helps if you can provide a specific example/test case for this. Alex On Mon, 8 Nov 2021 at 11:26, Martin Koppehel wrote: > -- snip > > I'm afraid I don't understand why this is a race condition? Where is the > timeout > > that stops one being set? > > The commit message is misleading here,

Re: [OE-core] [bitbake-devel] [PATCH 2/2] fetch2: Fix race condition in latest_revision

2021-11-07 Thread Richard Purdie
On Fri, 2021-11-05 at 14:30 +0100, Jasper Orschulko via lists.openembedded.org wrote: > From: Martin Koppehel > > Setting latest_revision contained a race condition, where it would be > set to an empty string, if the hash calculation function would take to > long. > > Signed-off-by: Jasper