Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-26 Thread Burton, Ross
On 26 November 2015 at 03:17, Jagadeesh Krishnanjanappa < jkrishnanjana...@mvista.com> wrote: > The intention of using os.getuid() is to avoid writing hardcoded value > "0", since os.getuid() return "0" under fakeroot env; if root user is > having UID as 0.That's the advantage I can think of. >

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-26 Thread Jagadeesh Krishnanjanappa
> > > The intention of using os.getuid() is to avoid writing hardcoded value >> "0", since os.getuid() return "0" under fakeroot env; if root user is >> having UID as 0.That's the advantage I can think of. >> > > root is *always* UID 0, and packaging always runs as root. > Can you send a tested

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Jagadeesh Krishnanjanappa
Hi Ross, > > Yes, since copy_license_files() function is executed within the pseudo >> environement (fakeroot), both os.getuid() and os.getgid() return 0, >> which resembles to uid and gid of root user. Also, os.chown accepts integer >> values for 2nd and 3rd arguments. >> > > So is there any

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Burton, Ross
On 25 November 2015 at 14:58, Jagadeesh Krishnanjanappa < jkrishnanjana...@mvista.com> wrote: > Yes, since copy_license_files() function is executed within the pseudo > environement (fakeroot), both os.getuid() and os.getgid() return 0, which > resembles to uid and gid of root user. Also,

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Jagadeesh Krishnanjanappa
> > > is os.getuid() and os.getgid() the correct value you want to use? I > would expect root:root. > > Yes, since copy_license_files() function is executed within the pseudo environement (fakeroot), both os.getuid() and os.getgid() return 0, which resembles to uid and gid of root user. Also,

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Martin Jansa
On Wed, Nov 25, 2015 at 04:42:57PM +0800, Robert Yang wrote: > > Hi Jagadeesh, > > Thanks, usually, patch should go into master branch before go into stable > branch such as jethro. IMHO, jethro branch may not take this fix even if > master merges it. The problem is that oe-core doesn't create

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Robert Yang
Hi Jagadeesh, Thanks, usually, patch should go into master branch before go into stable branch such as jethro. IMHO, jethro branch may not take this fix even if master merges it. The problem is that oe-core doesn't create package for ${PN}-lic atm, this patch is treated as part of the

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Martin Jansa
On Wed, Nov 25, 2015 at 04:25:56PM +0530, Jagadeesh Krishnanjanappa wrote: > Hi Robert, > > I understand. Though LICENSE_CREATE_PACKAGE is disabled by default in > OE-core, if some users want to create ${PN}-lic package for each recipe > via LICENSE_CREATE_PACKAGE = "1", then they are going to

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Jagadeesh Krishnanjanappa
Hi Robert, I understand. Though LICENSE_CREATE_PACKAGE is disabled by default in OE-core, if some users want to create ${PN}-lic package for each recipe via LICENSE_CREATE_PACKAGE = "1", then they are going to have host contamination warnings for each recipe. The above commit indicated by

Re: [OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-25 Thread Robert Yang
On 11/25/2015 06:55 PM, Jagadeesh Krishnanjanappa wrote: Hi Robert, I understand. Though LICENSE_CREATE_PACKAGE is disabled by default in OE-core, if some users want to create ${PN}-lic package for each recipe via LICENSE_CREATE_PACKAGE = "1", then they are going to have host contamination

[OE-core] [jethro][PATCH] license.bbclass: fix host contamination warnings for license files

2015-11-24 Thread Jagadeesh Krishnanjanappa
We get below host contamination warnings of license files for each recipe, when we try to create a separate ${PN}-lic package (which contains license files), by setting LICENSE_CREATE_PACKAGE equal to "1" in local.conf. -- snip -- WARNING: QA Issue: libcgroup: