Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-27 Thread Phil Blundell
On Thu, 2011-05-26 at 10:46 -0700, Darren Hart wrote: Right, it just starts to look rather ugly in the recipe, especially for BSPs supporting more than just a couple of machines. I also think that having to use machine overrides is an indicator that the mechanism is not working for the purpose

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-27 Thread Darren Hart
On 05/27/2011 07:04 AM, Phil Blundell wrote: On Thu, 2011-05-26 at 10:46 -0700, Darren Hart wrote: Right, it just starts to look rather ugly in the recipe, especially for BSPs supporting more than just a couple of machines. I also think that having to use machine overrides is an indicator

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-27 Thread Phil Blundell
On Fri, 2011-05-27 at 08:06 -0700, Darren Hart wrote: In fact... why are the parens used at all? No good reason. I would guess that we started off with something like COMPATIBLE_MACHINE = pdp11/(23|34) in a recipe, and that got somehow generalised to wrapping all the alternatives in parens

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-26 Thread Jason Kridner
I think this is a good change. One comment below... On May 26, 2011, at 12:02 AM, Darren Hart dvh...@linux.intel.com wrote: oe-core does not define any machines, so it does not make sense to add machine specific information in the oe-core u-boot recipe and infrastructure. Also note that

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-26 Thread Darren Hart
On 05/26/2011 12:47 AM, Jason Kridner wrote: I think this is a good change. One comment below... On May 26, 2011, at 12:02 AM, Darren Hart dvh...@linux.intel.com wrote: oe-core does not define any machines, so it does not make sense to add machine specific information in the oe-core

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-26 Thread Chris Larson
On Thu, May 26, 2011 at 6:50 AM, Darren Hart dvh...@linux.intel.com wrote: -UBOOT_MACHINE ?= ${MACHINE}_config +python () { +    if not bb.data.getVar('UBOOT_MACHINE', d, 1): +        bb.debug(To build %s, see u-boot_git.bb for instructions on \ If this file was renamed, don't you also want

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-26 Thread Richard Purdie
On Thu, 2011-05-26 at 11:50 +0100, Phil Blundell wrote: On Wed, 2011-05-25 at 22:02 -0700, Darren Hart wrote: COMPATIBLE_MACHINES is not easily extended due to its regex syntax: (machine_a|machine_b), making it difficult to extend the u-boot recipe in bbappend files without resorting to

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-26 Thread Phil Blundell
On Thu, 2011-05-26 at 15:37 +0100, Richard Purdie wrote: u-boot in OE-Core would need something like COMPATIBLE_MACHINE = which makes this harder. Yes, true. I don't think that's a major problem, though, you just need a regex that won't match anything. Something like: COMPATIBLE_MACHINE =

Re: [OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-26 Thread Darren Hart
On 05/26/2011 09:18 AM, Phil Blundell wrote: On Thu, 2011-05-26 at 15:37 +0100, Richard Purdie wrote: u-boot in OE-Core would need something like COMPATIBLE_MACHINE = which makes this harder. Yes, true. I don't think that's a major problem, though, you just need a regex that won't match

[OE-core] [pull-oe-uboot 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

2011-05-25 Thread Darren Hart
oe-core does not define any machines, so it does not make sense to add machine specific information in the oe-core u-boot recipe and infrastructure. Also note that COMPATIBLE_MACHINES is not easily extended due to its regex syntax: (machine_a|machine_b), making it difficult to extend the u-boot