Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Trevor Gamblin
On 2024-01-16 05:05, Vyacheslav Yurkov wrote: I also have the same opinion. What else am I supposed to write in the body if it were merely a refactoring (function moved, renamed, etc), and it's already described in the hearer? It shouldn't be considered a strict requirement, as it's going to

Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Vyacheslav Yurkov
I also have the same opinion. What else am I supposed to write in the body if it were merely a refactoring (function moved, renamed, etc), and it's already described in the hearer? Slava On 16.01.2024 10:32, Alexander Kanavin wrote: Because making it strict would only result in useless noise

Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Alexander Kanavin
Because making it strict would only result in useless noise in the commit logs. It's entirely valid to have changes that can fully be described with a commit header. I see it as a notice to consider if the commit message should be added, at the discretion of both submitter and committer. Alex On

Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Alexandre Belloni via lists.openembedded.org
On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote: > No. Why not? > > Alex > > On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov wrote: > > > > Is that a strict requirement now even for trivial patches? > > > > Slava > > > > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: >

Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Alexander Kanavin
No. Alex On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov wrote: > > Is that a strict requirement now even for trivial patches? > > Slava > > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: > > Thank you for your submission. Patchtest identified one > > or more issues with the

Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Vyacheslav Yurkov
Is that a strict requirement now even for trivial patches? Slava On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote: Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch

[OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch FAIL: test commit message presence: