Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Tomasz Dziendzielski
>Try checking if the "task" flag is set for "do_patch" Good idea, thanks! It's working correctly. I can see both 'noexec' and 'task' flags can be set separately, so to make it more general (and make it work for similar recipes without sources) I will check both 'noexec' and 'task' flags. I will

Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Richard Purdie
On Tue, 2021-01-19 at 19:05 +0100, Tomasz Dziendzielski wrote: > > > diff --git a/meta/recipes-devtools/gcc/gcc-shared-source.inc > > > b/meta/recipes-devtools/gcc/gcc-shared-source.inc > > > index aac4b49313..9ef80f2074 100644 > > > --- a/meta/recipes-devtools/gcc/gcc-shared-source.inc > > > +++

Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Tomasz Dziendzielski
>> diff --git a/meta/recipes-devtools/gcc/gcc-shared-source.inc b/meta/recipes-devtools/gcc/gcc-shared-source.inc >> index aac4b49313..9ef80f2074 100644 >> --- a/meta/recipes-devtools/gcc/gcc-shared-source.inc >> +++ b/meta/recipes-devtools/gcc/gcc-shared-source.inc >> @@ -2,6 +2,7 @@ do_fetch() {

Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Richard Purdie
On Tue, 2021-01-19 at 16:53 +0100, Tomasz Dziendzielski wrote: > If do_patch task is disabled then prepare do_configure dependencies to > fetch external sources and create symlink to ${S} in devtool workspace. > > [YOCTO #13036] > > Signed-off-by: Tomasz Dziendzielski > --- >  

Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Tomasz Dziendzielski
>Have you tested whether the archiver class is still working after this >change? If not it'd be helpful to run `oe-selftest -r archiver` to >check. Hi Paul, I have just run that script and it passed with no errors: oe-selftest - OK - All required tests passed (successes=13, skipped=0, failures=0,

Re: [OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Paul Barker
On Tue, 19 Jan 2021 at 15:51, Tomasz Dziendzielski wrote: > > If do_patch task is disabled then prepare do_configure dependencies to > fetch external sources and create symlink to ${S} in devtool workspace. > > [YOCTO #13036] > > Signed-off-by: Tomasz Dziendzielski > --- >

[OE-core] [PATCH] devtool: Fix source extraction for gcc shared source

2021-01-19 Thread Tomasz Dziendzielski
If do_patch task is disabled then prepare do_configure dependencies to fetch external sources and create symlink to ${S} in devtool workspace. [YOCTO #13036] Signed-off-by: Tomasz Dziendzielski --- .../gcc/gcc-shared-source.inc | 1 + scripts/lib/devtool/standard.py