Re: [OE-core] [PATCH] gmp: Disable assembly for MIPS R6

2016-10-16 Thread Khem Raj 

> On Oct 12, 2016, at 12:03 PM, Andre McCurdy  wrote:
> 
> On Wed, Oct 12, 2016 at 5:52 AM, Zubair Lutfullah Kakakhel
>  wrote:
>> gmplib has some assembly routines. These have not been optimized
>> for MIPS R6 yet. Add --disable-assembly so that the C implementation
>> is used.
>> 
>> Signed-off-by: Zubair Lutfullah Kakakhel 
>> ---
>> meta/recipes-support/gmp/gmp_6.1.1.bb | 4 
>> 1 file changed, 4 insertions(+)
>> 
>> diff --git a/meta/recipes-support/gmp/gmp_6.1.1.bb 
>> b/meta/recipes-support/gmp/gmp_6.1.1.bb
>> index 303c3ef..430ce93 100644
>> --- a/meta/recipes-support/gmp/gmp_6.1.1.bb
>> +++ b/meta/recipes-support/gmp/gmp_6.1.1.bb
>> @@ -21,6 +21,10 @@ SRC_URI[sha256sum] = 
>> "a8109865f2893f1373b0a8ed5ff7429de8db696fc451b1036bd7bdf95b
>> acpaths = ""
>> 
>> EXTRA_OECONF += " --enable-cxx=detect"
>> +EXTRA_OECONF_mipsisa32r6el += " --disable-assembly"
>> +EXTRA_OECONF_mipsisa32r6   += " --disable-assembly"
>> +EXTRA_OECONF_mipsisa64r6el += " --disable-assembly"
>> +EXTRA_OECONF_mipsisa64r6   += " --disable-assembly"
> 
> These over-rides will cause --disable-assembly to completely replace
> the original value of EXTRA_OECONF, rather than being appended to it.
> 
> A typical solution is to use an intermediate variable, something like:
> 
> DISABLE_ASSEMBLY ?= ""
> DISABLE_ASSEMBLY_mipsisa32r6 = "--disable-assembly"
> DISABLE_ASSEMBLY_mipsisa32r6el = "--disable-assembly"
> DISABLE_ASSEMBLY_mipsisa64r6 = "--disable-assembly"
> DISABLE_ASSEMBLY_mipsisa64r6el = "--disable-assembly"
> 
> EXTRA_OECONF += "${DISABLE_ASSEMBLY}”

Or use _append instead of += in original patch.

> 
> 
>> 
>> PACKAGES =+ "libgmpxx"
>> FILES_libgmpxx = "${libdir}/libgmpxx${SOLIBS}"
>> --
>> 1.9.1
>> 
>> --
>> ___
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH] gmp: Disable assembly for MIPS R6

2016-10-12 Thread Andre McCurdy 
On Wed, Oct 12, 2016 at 5:52 AM, Zubair Lutfullah Kakakhel
 wrote:
> gmplib has some assembly routines. These have not been optimized
> for MIPS R6 yet. Add --disable-assembly so that the C implementation
> is used.
>
> Signed-off-by: Zubair Lutfullah Kakakhel 
> ---
>  meta/recipes-support/gmp/gmp_6.1.1.bb | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-support/gmp/gmp_6.1.1.bb 
> b/meta/recipes-support/gmp/gmp_6.1.1.bb
> index 303c3ef..430ce93 100644
> --- a/meta/recipes-support/gmp/gmp_6.1.1.bb
> +++ b/meta/recipes-support/gmp/gmp_6.1.1.bb
> @@ -21,6 +21,10 @@ SRC_URI[sha256sum] = 
> "a8109865f2893f1373b0a8ed5ff7429de8db696fc451b1036bd7bdf95b
>  acpaths = ""
>
>  EXTRA_OECONF += " --enable-cxx=detect"
> +EXTRA_OECONF_mipsisa32r6el += " --disable-assembly"
> +EXTRA_OECONF_mipsisa32r6   += " --disable-assembly"
> +EXTRA_OECONF_mipsisa64r6el += " --disable-assembly"
> +EXTRA_OECONF_mipsisa64r6   += " --disable-assembly"

These over-rides will cause --disable-assembly to completely replace
the original value of EXTRA_OECONF, rather than being appended to it.

A typical solution is to use an intermediate variable, something like:

DISABLE_ASSEMBLY ?= ""
DISABLE_ASSEMBLY_mipsisa32r6 = "--disable-assembly"
DISABLE_ASSEMBLY_mipsisa32r6el = "--disable-assembly"
DISABLE_ASSEMBLY_mipsisa64r6 = "--disable-assembly"
DISABLE_ASSEMBLY_mipsisa64r6el = "--disable-assembly"

EXTRA_OECONF += "${DISABLE_ASSEMBLY}"


>
>  PACKAGES =+ "libgmpxx"
>  FILES_libgmpxx = "${libdir}/libgmpxx${SOLIBS}"
> --
> 1.9.1
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH] gmp: Disable assembly for MIPS R6

2016-10-12 Thread Zubair Lutfullah Kakakhel 
gmplib has some assembly routines. These have not been optimized
for MIPS R6 yet. Add --disable-assembly so that the C implementation
is used.

Signed-off-by: Zubair Lutfullah Kakakhel 
---
 meta/recipes-support/gmp/gmp_6.1.1.bb | 4 
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-support/gmp/gmp_6.1.1.bb 
b/meta/recipes-support/gmp/gmp_6.1.1.bb
index 303c3ef..430ce93 100644
--- a/meta/recipes-support/gmp/gmp_6.1.1.bb
+++ b/meta/recipes-support/gmp/gmp_6.1.1.bb
@@ -21,6 +21,10 @@ SRC_URI[sha256sum] = 
"a8109865f2893f1373b0a8ed5ff7429de8db696fc451b1036bd7bdf95b
 acpaths = ""
 
 EXTRA_OECONF += " --enable-cxx=detect"
+EXTRA_OECONF_mipsisa32r6el += " --disable-assembly"
+EXTRA_OECONF_mipsisa32r6   += " --disable-assembly"
+EXTRA_OECONF_mipsisa64r6el += " --disable-assembly"
+EXTRA_OECONF_mipsisa64r6   += " --disable-assembly"
 
 PACKAGES =+ "libgmpxx"
 FILES_libgmpxx = "${libdir}/libgmpxx${SOLIBS}"
-- 
1.9.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core