Re: [OE-core] [PATCH 12/27] kmod: define bashcompletiondir
On 21 February 2018 at 09:13, Maxin B. John wrote: > On Wed, Feb 21, 2018 at 12:09:36AM +, Burton, Ross wrote: > > >>On 19 February 2018 at 08:37, Maxin B. John > wrote: > >> > >> After moving to pkgconf, kmod package qa test fails without it. > > > >Is this failing because pkgconf returns a full path > (/path/to/my/build/usr/share/bash-completion) instead of the path in the > pc (/usr/share/bash-completion)? In the context of a target path in a > makefile, the latter is correct and the former is very wrong. > > Due to this line in configure.ac: > with_bashcompletiondir=$($PKG_CONFIG --variable=completionsdir > bash-completion) > > combined with this: > $(INSTALL_DATA) $$files "$(DESTDIR)$(bashcompletiondir)" > Which you have to admit seems like the right thing to do... I'd argue that pkgconf is doing the wrong thing here. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 12/27] kmod: define bashcompletiondir
Hi Ross, On Wed, Feb 21, 2018 at 12:09:36AM +, Burton, Ross wrote: >>On 19 February 2018 at 08:37, Maxin B. John wrote: >> >> After moving to pkgconf, kmod package qa test fails without it. > >Is this failing because pkgconf returns a full path >(/path/to/my/build/usr/share/bash-completion) instead of the path in the pc >(/usr/share/bash-completion)? In the context of a target path in a makefile, >the latter is correct and the former is very wrong. Due to this line in configure.ac: with_bashcompletiondir=$($PKG_CONFIG --variable=completionsdir bash-completion) combined with this: $(INSTALL_DATA) $$files "$(DESTDIR)$(bashcompletiondir)" >I really do think that the pkgconfig and pkgconf maintainers need to be locked >in a room and argue this out. It's not a drop-in replacement if the behaviour >changes... Good suggestion :) While ageeing that these changes doesn't look good, I will try to find other reasonable fixes, if any. >Ross Best Regards, Maxin -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 12/27] kmod: define bashcompletiondir
On 19 February 2018 at 08:37, Maxin B. John wrote: > After moving to pkgconf, kmod package qa test fails without it. > Is this failing because pkgconf returns a full path (/path/to/my/build/usr/share/bash-completion) instead of the path in the pc (/usr/share/bash-completion)? In the context of a target path in a makefile, the latter is correct and the former is very wrong. I really do think that the pkgconfig and pkgconf maintainers need to be locked in a room and argue this out. It's not a drop-in replacement if the behaviour changes... Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 12/27] kmod: define bashcompletiondir
After moving to pkgconf, kmod package qa test fails without it.
Signed-off-by: Maxin B. John
---
meta/recipes-kernel/kmod/kmod_git.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-kernel/kmod/kmod_git.bb
b/meta/recipes-kernel/kmod/kmod_git.bb
index 69185b2..251681f 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -17,6 +17,8 @@ bindir = "${base_bindir}"
sbindir = "${base_sbindir}"
# libdir = "${base_libdir}"
+EXTRA_OECONF = "--with-bashcompletiondir='${datadir}/bash-completion/'"
+
do_install_append () {
install -dm755 ${D}${base_bindir}
install -dm755 ${D}${base_sbindir}
--
2.4.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
