Re: [OE-core] [PATCH 3/3] busybox-inittab: minor formatting tweaks

2019-09-13 Thread Denys Dmytriyenko
On Thu, Sep 12, 2019 at 03:56:24PM -0700, Andre McCurdy wrote:
> Add an empty line to inittab before the line(s) which start getty.
> 
> Also cleanup indent in recipe do_install().
> 
> Signed-off-by: Andre McCurdy 

Reviewed-by: Denys Dmytriyenko 


> ---
>  .../busybox/busybox-inittab_1.31.0.bb | 19 ++-
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb 
> b/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
> index c347daf501..61fb8cbad1 100644
> --- a/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
> +++ b/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
> @@ -13,15 +13,16 @@ do_compile() {
>  }
>  
>  do_install() {
> -install -d ${D}${sysconfdir}
> -install -D -m 0644 ${WORKDIR}/inittab ${D}${sysconfdir}/inittab
> -tmp="${SERIAL_CONSOLES}"
> -for i in $tmp
> -do
> -j=`echo ${i} | sed s/\;/\ /g`
> -id=`echo ${i} | sed -e 's/^.*;//' -e 's/;.*//'`
> -echo "$id::respawn:${base_sbindir}/getty ${j}" >> 
> ${D}${sysconfdir}/inittab
> -done
> + install -d ${D}${sysconfdir}
> + install -D -m 0644 ${WORKDIR}/inittab ${D}${sysconfdir}/inittab
> + tmp="${SERIAL_CONSOLES}"
> + [ -n "$tmp" ] && echo >> ${D}${sysconfdir}/inittab
> + for i in $tmp
> + do
> + j=`echo ${i} | sed s/\;/\ /g`
> + id=`echo ${i} | sed -e 's/^.*;//' -e 's/;.*//'`
> + echo "$id::respawn:${base_sbindir}/getty ${j}" >> 
> ${D}${sysconfdir}/inittab
> + done
>  }
>  
>  # SERIAL_CONSOLES is generally defined by the MACHINE .conf.
> -- 
> 2.23.0
> 
> -- 
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 3/3] busybox-inittab: minor formatting tweaks

2019-09-12 Thread Andre McCurdy
Add an empty line to inittab before the line(s) which start getty.

Also cleanup indent in recipe do_install().

Signed-off-by: Andre McCurdy 
---
 .../busybox/busybox-inittab_1.31.0.bb | 19 ++-
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb 
b/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
index c347daf501..61fb8cbad1 100644
--- a/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
+++ b/meta/recipes-core/busybox/busybox-inittab_1.31.0.bb
@@ -13,15 +13,16 @@ do_compile() {
 }
 
 do_install() {
-install -d ${D}${sysconfdir}
-install -D -m 0644 ${WORKDIR}/inittab ${D}${sysconfdir}/inittab
-tmp="${SERIAL_CONSOLES}"
-for i in $tmp
-do
-j=`echo ${i} | sed s/\;/\ /g`
-id=`echo ${i} | sed -e 's/^.*;//' -e 's/;.*//'`
-echo "$id::respawn:${base_sbindir}/getty ${j}" >> 
${D}${sysconfdir}/inittab
-done
+   install -d ${D}${sysconfdir}
+   install -D -m 0644 ${WORKDIR}/inittab ${D}${sysconfdir}/inittab
+   tmp="${SERIAL_CONSOLES}"
+   [ -n "$tmp" ] && echo >> ${D}${sysconfdir}/inittab
+   for i in $tmp
+   do
+   j=`echo ${i} | sed s/\;/\ /g`
+   id=`echo ${i} | sed -e 's/^.*;//' -e 's/;.*//'`
+   echo "$id::respawn:${base_sbindir}/getty ${j}" >> 
${D}${sysconfdir}/inittab
+   done
 }
 
 # SERIAL_CONSOLES is generally defined by the MACHINE .conf.
-- 
2.23.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core