Re: [OE-core] [PATCH 3/7] gptfdisk: update to 1.0.0

2015-08-09 Thread Richard Purdie 
On Sat, 2015-08-08 at 12:48 -0700, Khem Raj wrote:
> > On Aug 7, 2015, at 7:28 AM, Alexander Kanavin 
> >  wrote:
> > 
> > Also, use tarballs instead of git for fetching source code.
> > git repository does not have version tags, so upstream version check
> > cannot be performed.
> > 
> > Signed-off-by: Alexander Kanavin 
> > ---
> > .../recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} | 8 
> > +++-
> > 1 file changed, 3 insertions(+), 5 deletions(-)
> > rename meta/recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} 
> > (75%)
> > 
> > diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb 
> > b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> > similarity index 75%
> > rename from meta/recipes-devtools/fdisk/gptfdisk_git.bb
> > rename to meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> > index 477c1d9..f4b0e32 100644
> > --- a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
> > +++ b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> > @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = 
> > "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
> > 
> > DEPENDS = "util-linux popt ncurses"
> > 
> > -PV = "0.8.10+git${SRCPV}”
> 
> its always preferable to have PV contain SRCPV for recipes using SCM based 
> fetch mechanism. Don’t drop it

There has been discussion about this in other threads and the conclusion
reached is that where there is a specific version being selected, having
PV of that specific version is a good thing. With "1.0.0+gitXXX" its
unclear if its really 1.0.0 or not.

Cheers,

Richard



-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 3/7] gptfdisk: update to 1.0.0

2015-08-08 Thread Khem Raj 

> On Aug 7, 2015, at 7:28 AM, Alexander Kanavin 
>  wrote:
> 
> Also, use tarballs instead of git for fetching source code.
> git repository does not have version tags, so upstream version check
> cannot be performed.
> 
> Signed-off-by: Alexander Kanavin 
> ---
> .../recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
> rename meta/recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} 
> (75%)
> 
> diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb 
> b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> similarity index 75%
> rename from meta/recipes-devtools/fdisk/gptfdisk_git.bb
> rename to meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> index 477c1d9..f4b0e32 100644
> --- a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
> +++ b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
> @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = 
> "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
> 
> DEPENDS = "util-linux popt ncurses"
> 
> -PV = "0.8.10+git${SRCPV}”

its always preferable to have PV contain SRCPV for recipes using SCM based 
fetch mechanism. Don’t drop it

> -SRCREV = "a920398fa393f9d6301b32b191bc01e086ab8bc8"
> -SRC_URI = "git://git.code.sf.net/p/gptfdisk/code"
> -
> -S = "${WORKDIR}/git"
> +SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${PV}/${BP}.tar.gz"
> +SRC_URI[md5sum] = "2061f917af084215898d4fea04d8388f"
> +SRC_URI[sha256sum] = 
> "5b66956743a799fc0471cdb032665c1391e82f9c5b3f1d7d726d29fe2ba01d6c"
> 
> do_install() {
> install -d ${D}${sbindir}
> --
> 2.1.4
> 
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 3/7] gptfdisk: update to 1.0.0

2015-08-07 Thread Alexander Kanavin 
Also, use tarballs instead of git for fetching source code.
git repository does not have version tags, so upstream version check
cannot be performed.

Signed-off-by: Alexander Kanavin 
---
 .../recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)
 rename meta/recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} (75%)

diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb 
b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
similarity index 75%
rename from meta/recipes-devtools/fdisk/gptfdisk_git.bb
rename to meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
index 477c1d9..f4b0e32 100644
--- a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
+++ b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
@@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
 
 DEPENDS = "util-linux popt ncurses"
 
-PV = "0.8.10+git${SRCPV}"
-SRCREV = "a920398fa393f9d6301b32b191bc01e086ab8bc8"
-SRC_URI = "git://git.code.sf.net/p/gptfdisk/code"
-
-S = "${WORKDIR}/git"
+SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${PV}/${BP}.tar.gz"
+SRC_URI[md5sum] = "2061f917af084215898d4fea04d8388f"
+SRC_URI[sha256sum] = 
"5b66956743a799fc0471cdb032665c1391e82f9c5b3f1d7d726d29fe2ba01d6c"
 
 do_install() {
 install -d ${D}${sbindir}
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 3/7] gptfdisk: update to 1.0.0

2015-08-03 Thread Alexander Kanavin 
Also, use tarballs instead of git for fetching source code.
git repository does not have version tags, so upstream version check
cannot be performed.

Signed-off-by: Alexander Kanavin 
---
 .../recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)
 rename meta/recipes-devtools/fdisk/{gptfdisk_git.bb => gptfdisk_1.0.0.bb} (75%)

diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb 
b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
similarity index 75%
rename from meta/recipes-devtools/fdisk/gptfdisk_git.bb
rename to meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
index 477c1d9..f4b0e32 100644
--- a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
+++ b/meta/recipes-devtools/fdisk/gptfdisk_1.0.0.bb
@@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
 
 DEPENDS = "util-linux popt ncurses"
 
-PV = "0.8.10+git${SRCPV}"
-SRCREV = "a920398fa393f9d6301b32b191bc01e086ab8bc8"
-SRC_URI = "git://git.code.sf.net/p/gptfdisk/code"
-
-S = "${WORKDIR}/git"
+SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${PV}/${BP}.tar.gz"
+SRC_URI[md5sum] = "2061f917af084215898d4fea04d8388f"
+SRC_URI[sha256sum] = 
"5b66956743a799fc0471cdb032665c1391e82f9c5b3f1d7d726d29fe2ba01d6c"
 
 do_install() {
 install -d ${D}${sbindir}
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core