Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-05-05 Thread Khem Raj
On Thu, May 5, 2011 at 2:41 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Wed, 2011-05-04 at 18:07 -0700, Khem Raj wrote: a build from scratch revealed few more issues with this patch too. 1. We have to only remove gettext from dependencies if its a target package for all

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-05-04 Thread Khem Raj
On Tue, May 3, 2011 at 3:39 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Tue, 2011-05-03 at 11:04 -0700, Khem Raj wrote: This has the same problem It empties out DEPENDS_GETTEXT after they have have already been added to DEPENDS via virtclass e.g. when you build

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-05-04 Thread Khem Raj
On (04/05/11 18:07), Khem Raj wrote: On Tue, May 3, 2011 at 3:39 PM, Richard Purdie richard.pur...@linuxfoundation.org wrote: On Tue, 2011-05-03 at 11:04 -0700, Khem Raj wrote: This has the same problem It empties out DEPENDS_GETTEXT after they have have already been added to DEPENDS via

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-05-03 Thread Richard Purdie
On Fri, 2011-04-29 at 09:11 -0700, Khem Raj wrote: On Thu, Apr 28, 2011 at 2:01 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: We can make this simpler. We should just setVar(DEPENDS_GETTEXT, ) in the INHIBIT_DEFAULT_DEPS case. If anything is expanding the variables

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-05-03 Thread Khem Raj
On (03/05/11 13:14), Richard Purdie wrote: On Fri, 2011-04-29 at 09:11 -0700, Khem Raj wrote: On Thu, Apr 28, 2011 at 2:01 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: We can make this simpler. We should just setVar(DEPENDS_GETTEXT, ) in the INHIBIT_DEFAULT_DEPS case. If

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-05-03 Thread Richard Purdie
On Tue, 2011-05-03 at 11:04 -0700, Khem Raj wrote: This has the same problem It empties out DEPENDS_GETTEXT after they have have already been added to DEPENDS via virtclass e.g. when you build gcc-runtime-nativesdk it will report a dep loop since now it depends on virtual/gettext-nativesdk

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-04-29 Thread Khem Raj
On Thu, Apr 28, 2011 at 2:01 AM, Richard Purdie richard.pur...@linuxfoundation.org wrote: We can make this simpler. We should just setVar(DEPENDS_GETTEXT, ) in the INHIBIT_DEFAULT_DEPS case. If anything is expanding the variables somewhere, we should fix that. Infact the virtclass stuff

Re: [OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-04-28 Thread Richard Purdie
On Wed, 2011-04-27 at 00:29 -0700, Saul Wold wrote: From: Khem Raj raj.k...@gmail.com Ensure gettext and gettext-native are removed from DEPENDS when not using NLS Use append instead of += to get gettext dependecies processed correctly in all cases Dont remove gettext-native for native

[OE-core] [PATCH 36/52] gettext.bbclass: Use _append instead of =+

2011-04-27 Thread Saul Wold
From: Khem Raj raj.k...@gmail.com Ensure gettext and gettext-native are removed from DEPENDS when not using NLS Use append instead of += to get gettext dependecies processed correctly in all cases Dont remove gettext-native for native recipes as ENABLE_NLS is only for target and not for native