Re: [OE-core] [PATCH 4/9] selftest: skip some devtool tests when distro is poky-tiny due to missing libx11

[Joshua Lock]

On Mon, 2016-10-17 at 10:19 -0500, Leonardo Sandoval wrote:
> 
> 
> 
> 
> 
> 
> On 10/17/2016 06:42 AM, Burton, Ross
>   wrote:
> 
> 
> 
> >   
> > 
> > 
> > > >   On 14 October 2016 at 17:40, 
> > wrote:
> > 
> > >      
> > >  def test_devtool_add_fetch_git(self):
> > > 
> > > -        # Fetch source
> > > 
> > > +        if self.distro == 'poky-tiny':
> > > 
> > > +            self.skipTest('libmatchbox2 is not
> > > > > > buildable with poky-tiny because it requires a
libx11
> > > provider')
> > > 
> > > > > >          tempdir =
tempfile.mkdtemp(prefix='devtoolqa')
> > > 
> > >          self.track_for_cleanup(tempdir)
> > > 
> > > > > >          url =
'git://git.yoctoproject.org/libmatchbox'
> > > 
> > > 
> >   
> > 
> >   
> > 
> >   Changing the test to use a recipe that doesn't require a
> > > >   distro feature that many distros disable seems like a
more
> >   sustainable fix.
> > 
> > 
> > 
> > 
> > 
> >   
> > 
> Which recipe do you think would be more generic?

Something in the minimal image which doesn't rely on DISTRO_FEATURES
which aren't in the default distro.

Thanks,

Joshua
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/9] selftest: skip some devtool tests when distro is poky-tiny due to missing libx11

[Leonardo Sandoval]

On 10/17/2016 06:42 AM, Burton, Ross wrote:


On 14 October 2016 at 17:40, 
> wrote:


 def test_devtool_add_fetch_git(self):
-# Fetch source
+if self.distro == 'poky-tiny':
+self.skipTest('libmatchbox2 is not buildable with
poky-tiny because it requires a libx11 provider')
 tempdir = tempfile.mkdtemp(prefix='devtoolqa')
 self.track_for_cleanup(tempdir)
 url = 'git://git.yoctoproject.org/libmatchbox
'


Changing the test to use a recipe that doesn't require a distro 
feature that many distros disable seems like a more sustainable fix.



Which recipe do you think would be more generic?

Ross


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 4/9] selftest: skip some devtool tests when distro is poky-tiny due to missing libx11

[Burton, Ross]

On 14 October 2016 at 17:40, 
wrote:

>  def test_devtool_add_fetch_git(self):
> -# Fetch source
> +if self.distro == 'poky-tiny':
> +self.skipTest('libmatchbox2 is not buildable with poky-tiny
> because it requires a libx11 provider')
>  tempdir = tempfile.mkdtemp(prefix='devtoolqa')
>  self.track_for_cleanup(tempdir)
>  url = 'git://git.yoctoproject.org/libmatchbox'
>

Changing the test to use a recipe that doesn't require a distro feature
that many distros disable seems like a more sustainable fix.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 4/9] selftest: skip some devtool tests when distro is poky-tiny due to missing libx11

[leonardo . sandoval . gonzalez]

From: Leonardo Sandoval 

When distro is poky-tiny, there is no recipe providing libx11, thus skip 
relevant
tests.

[YOCTO #8525]

Signed-off-by: Leonardo Sandoval 
---
 meta/lib/oeqa/selftest/devtool.py | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/devtool.py 
b/meta/lib/oeqa/selftest/devtool.py
index e992dcf..aac5087 100644
--- a/meta/lib/oeqa/selftest/devtool.py
+++ b/meta/lib/oeqa/selftest/devtool.py
@@ -337,7 +337,8 @@ class DevtoolTests(DevtoolBase):
 
 @testcase(1161)
 def test_devtool_add_fetch_git(self):
-# Fetch source
+if self.distro == 'poky-tiny':
+self.skipTest('libmatchbox2 is not buildable with poky-tiny 
because it requires a libx11 provider')
 tempdir = tempfile.mkdtemp(prefix='devtoolqa')
 self.track_for_cleanup(tempdir)
 url = 'git://git.yoctoproject.org/libmatchbox'
@@ -577,6 +578,8 @@ class DevtoolTests(DevtoolBase):
 
 @testcase(1378)
 def test_devtool_modify_virtual(self):
+if self.distro == 'poky-tiny':
+self.skipTest('Test not possible with poky-tiny because it 
requires a libx11 provider')
 # Try modifying a virtual recipe
 virtrecipe = 'virtual/libx11'
 realrecipe = 'libx11'
@@ -941,6 +944,8 @@ class DevtoolTests(DevtoolBase):
 
 @testcase(1379)
 def test_devtool_extract_virtual(self):
+if self.distro == 'poky-tiny':
+self.skipTest('Test not possible with poky-tiny because it 
requires a libx11 provider')
 tempdir = tempfile.mkdtemp(prefix='devtoolqa')
 # Try devtool extract
 self.track_for_cleanup(tempdir)
-- 
2.1.4

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core