Re: [OE-core] [PATCH 6/6] nss: fix multilib file conflict

[Alexander Kanavin]

2018-08-10 11:03 GMT+02:00 Richard Purdie :
> Shouldn't those files be architecture independent given the files are
> in sysconfdir? Isn't this really a determinism problem and we should
> fix the builds to be deterministic instead?

Yes, absolutely. This 'multilib_script' facility should be used only
when there's a genuine reason for the files to be different for
different multilib configs. Otherwise it does look like someone took a
shortcut without looking at the problem properly.

Alex
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 6/6] nss: fix multilib file conflict

[Richard Purdie]

On Fri, 2018-08-10 at 00:31 -0700, Zhixiong Chi wrote:
> Signed-off-by: Zhixiong Chi 
> ---
>  meta/recipes-support/nss/nss_3.38.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/nss/nss_3.38.bb b/meta/recipes-
> support/nss/nss_3.38.bb
> index f3e5170a89..4f53b55f05 100644
> --- a/meta/recipes-support/nss/nss_3.38.bb
> +++ b/meta/recipes-support/nss/nss_3.38.bb
> @@ -33,7 +33,9 @@ SRC_URI[sha256sum] = 
> "2c643d3c08d6935f4d325f40743719b6990aa25a79ec2f8f712c99d086
>  UPSTREAM_CHECK_URI = 
> "https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_Releases;
>  UPSTREAM_CHECK_REGEX = "NSS_(?P.+)_release_notes"
>  
> -inherit siteinfo
> +inherit siteinfo multilib_script
> +
> +MULTILIB_SCRIPTS = "${PN}:${sysconfdir}/pki/nssdb/secmod.db 
> ${PN}:${sysconfdir}/pki/nssdb/key3.db"

Shouldn't those files be architecture independent given the files are
in sysconfdir? Isn't this really a determinism problem and we should
fix the builds to be deterministic instead?

Cheers,

Richard
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 6/6] nss: fix multilib file conflict

[Zhixiong Chi]

Signed-off-by: Zhixiong Chi 
---
 meta/recipes-support/nss/nss_3.38.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-support/nss/nss_3.38.bb 
b/meta/recipes-support/nss/nss_3.38.bb
index f3e5170a89..4f53b55f05 100644
--- a/meta/recipes-support/nss/nss_3.38.bb
+++ b/meta/recipes-support/nss/nss_3.38.bb
@@ -33,7 +33,9 @@ SRC_URI[sha256sum] = 
"2c643d3c08d6935f4d325f40743719b6990aa25a79ec2f8f712c99d086
 UPSTREAM_CHECK_URI = 
"https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_Releases;
 UPSTREAM_CHECK_REGEX = "NSS_(?P.+)_release_notes"
 
-inherit siteinfo
+inherit siteinfo multilib_script
+
+MULTILIB_SCRIPTS = "${PN}:${sysconfdir}/pki/nssdb/secmod.db 
${PN}:${sysconfdir}/pki/nssdb/key3.db"
 
 DEPENDS = "sqlite3 nspr zlib nss-native"
 DEPENDS_class-native = "sqlite3-native nspr-native zlib-native"
-- 
2.17.1

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core