Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-11 Thread Alex Kiernan
On Mon, Dec 11, 2023 at 10:52 AM Alex Kiernan via lists.openembedded.org wrote: > > On Mon, Dec 11, 2023 at 9:43 AM Alex Kiernan wrote: > > > > On Mon, Dec 11, 2023 at 9:28 AM Alexander Kanavin > > wrote: > > > > > > On Mon, 11 Dec 2023 at 10:09, Alex Kiernan wrote: > > > > In a single project

Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-11 Thread Alex Kiernan
On Mon, Dec 11, 2023 at 9:43 AM Alex Kiernan wrote: > > On Mon, Dec 11, 2023 at 9:28 AM Alexander Kanavin > wrote: > > > > On Mon, 11 Dec 2023 at 10:09, Alex Kiernan wrote: > > > In a single project there are (potentially) multiple Cargo.toml, but > > > just one Cargo.lock. If there's multiple

Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-11 Thread Alex Kiernan
On Mon, Dec 11, 2023 at 9:28 AM Alexander Kanavin wrote: > > On Mon, 11 Dec 2023 at 10:09, Alex Kiernan wrote: > > In a single project there are (potentially) multiple Cargo.toml, but > > just one Cargo.lock. If there's multiple Cargo.lock files in a repo, > > that implies multiple projects

Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-11 Thread Alexander Kanavin
On Mon, 11 Dec 2023 at 10:09, Alex Kiernan wrote: > In a single project there are (potentially) multiple Cargo.toml, but > just one Cargo.lock. If there's multiple Cargo.lock files in a repo, > that implies multiple projects which I don't think we've any way of > building from a single recipe.

Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-11 Thread Alex Kiernan
On Sun, Dec 10, 2023 at 8:35 PM Alexander Kanavin wrote: > > I have to say, I struggle to see this as an improvement, and I want > to object to it. > I have to admit I kinda thought this might be controversial. > Why set the path manually, if the code to find where Cargo.lock is > just works,

Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-10 Thread Frederic Martinsons
On Sun, 10 Dec 2023 at 21:35, Alexander Kanavin wrote: > I have to say, I struggle to see this as an improvement, and I want > to object to it. > > Why set the path manually, if the code to find where Cargo.lock is > just works, and handles the situations where upstreams move it around > in

Re: [OE-Core][PATCH 1/2] cargo-update-recipe-crates: Use CARGO_LOCK_PATH

2023-12-10 Thread Alexander Kanavin
I have to say, I struggle to see this as an improvement, and I want to object to it. Why set the path manually, if the code to find where Cargo.lock is just works, and handles the situations where upstreams move it around in source trees? Also, is the assumption that there's only one Cargo.lock