Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up
Just noticed your patches. Yes, this patch is not needed. Regards, Qi From: Peter Kjellerstedt Sent: Tuesday, September 26, 2023 9:10 PM To: Jose Quaresma ; Chen, Qi Cc: openembedded-core@lists.openembedded.org Subject: RE: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up NAK This is no longer needed since commit 6b7883533 (bitbake-getvar: Make --value imply –quiet) landed in bitbake. //Peter From: openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org> mailto:openembedded-core@lists.openembedded.org>> On Behalf Of Jose Quaresma Sent: den 26 september 2023 12:21 To: qi.c...@windriver.com<mailto:qi.c...@windriver.com> Cc: openembedded-core@lists.openembedded.org<mailto:openembedded-core@lists.openembedded.org> Subject: Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up Hi Chen, I have raised this when it lands https://lists.openembedded.org/g/openembedded-core/message/187378<https://urldefense.com/v3/__https:/lists.openembedded.org/g/openembedded-core/message/187378__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgINwfzZE$> Tested.by<https://urldefense.com/v3/__http:/Tested.by__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgVUqchqA$>: Jose Quaresma mailto:quaresma.j...@gmail.com>> Jose Chen Qi via lists.openembedded.org<https://urldefense.com/v3/__http:/lists.openembedded.org__;!!AjveYdw8EvQ!adHqVF0IzEspqiDUyqlT-QC4Rdy_B_YAK8youCQ60fa96rN8B3AxjRCZmJ2VY3fr0uDPRoNXqypFyOI9RkIgL6RxaeA$> mailto:windriver@lists.openembedded.org>> escreveu no dia terça, 26/09/2023 à(s) 11:15: From: Chen Qi mailto:qi.c...@windriver.com>> Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result. Signed-off-by: Chen Qi mailto:qi.c...@windriver.com>> --- scripts/oe-find-native-sysroot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/oe-find-native-sysroot b/scripts/oe-find-native-sysroot index 6228efcbee..541318b461 100755 --- a/scripts/oe-find-native-sysroot +++ b/scripts/oe-find-native-sysroot @@ -38,7 +38,7 @@ fi # Global vars set_oe_native_sysroot(){ echo "Getting sysroot..." -OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE) +OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE) } if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then -- 2.40.0 -- Best regards, José Quaresma -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#188254): https://lists.openembedded.org/g/openembedded-core/message/188254 Mute This Topic: https://lists.openembedded.org/mt/101592501/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up
NAK This is no longer needed since commit 6b7883533 (bitbake-getvar: Make --value imply –quiet) landed in bitbake. //Peter From: openembedded-core@lists.openembedded.org On Behalf Of Jose Quaresma Sent: den 26 september 2023 12:21 To: qi.c...@windriver.com Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up Hi Chen, I have raised this when it lands https://lists.openembedded.org/g/openembedded-core/message/187378 Tested.by: Jose Quaresma mailto:quaresma.j...@gmail.com>> Jose Chen Qi via lists.openembedded.org<http://lists.openembedded.org> mailto:windriver@lists.openembedded.org>> escreveu no dia terça, 26/09/2023 à(s) 11:15: From: Chen Qi mailto:qi.c...@windriver.com>> Add '-q' option to bitbake-getvar to avoid warning messages contaminating the actual result. Signed-off-by: Chen Qi mailto:qi.c...@windriver.com>> --- scripts/oe-find-native-sysroot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/oe-find-native-sysroot b/scripts/oe-find-native-sysroot index 6228efcbee..541318b461 100755 --- a/scripts/oe-find-native-sysroot +++ b/scripts/oe-find-native-sysroot @@ -38,7 +38,7 @@ fi # Global vars set_oe_native_sysroot(){ echo "Getting sysroot..." -OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value STAGING_DIR_NATIVE) +OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value STAGING_DIR_NATIVE) } if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then -- 2.40.0 -- Best regards, José Quaresma -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#188245): https://lists.openembedded.org/g/openembedded-core/message/188245 Mute This Topic: https://lists.openembedded.org/mt/101592501/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core][PATCH] oe-find-native-sysroot: avoid warning message messing things up
Hi Chen, I have raised this when it lands https://lists.openembedded.org/g/openembedded-core/message/187378 Tested.by: Jose Quaresma Jose Chen Qi via lists.openembedded.org escreveu no dia terça, 26/09/2023 à(s) 11:15: > From: Chen Qi > > Add '-q' option to bitbake-getvar to avoid warning messages contaminating > the actual result. > > Signed-off-by: Chen Qi > --- > scripts/oe-find-native-sysroot | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/oe-find-native-sysroot > b/scripts/oe-find-native-sysroot > index 6228efcbee..541318b461 100755 > --- a/scripts/oe-find-native-sysroot > +++ b/scripts/oe-find-native-sysroot > @@ -38,7 +38,7 @@ fi > # Global vars > set_oe_native_sysroot(){ > echo "Getting sysroot..." > -OECORE_NATIVE_SYSROOT=$(bitbake-getvar -r $1 --value > STAGING_DIR_NATIVE) > +OECORE_NATIVE_SYSROOT=$(bitbake-getvar -q -r $1 --value > STAGING_DIR_NATIVE) > } > > if [ "x$OECORE_NATIVE_SYSROOT" = "x" ]; then > -- > 2.40.0 > > > > > -- Best regards, José Quaresma -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#188243): https://lists.openembedded.org/g/openembedded-core/message/188243 Mute This Topic: https://lists.openembedded.org/mt/101592501/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-