Re: [OE-core][PATCH v9 5/7] oeqa/selftest: Add tests for source download enrichment

2026-03-13 Thread Tondo, Stefano via lists.openembedded.org
Hi Mathieu,

Yes, that's correct, the build-m4/build-tar naming depends on
Joshua's series which renames recipe-* to build-* in the SPDX
output. My series is intended to be applied on top of his.

Once his series lands, these tests should pass.

Thanks,
Stefano

From: Mathieu Dubois-Briand 
Sent: Friday, March 13, 2026 07:14
To: [email protected] ; 
[email protected] 

Cc: [email protected] ; Tondo, Stefano (ext) (SI B PRO 
AUT PD ZUG SW 2) 
Subject: Re: [OE-core][PATCH v9 5/7] oeqa/selftest: Add tests for source 
download enrichment

On Thu Mar 12, 2026 at 4:38 PM CET, Stefano Tondo via lists.openembedded.org 
wrote:
> From: Stefano Tondo 
>
> Add two new SPDX 3.0 selftest cases:
>
> test_download_location_defensive_handling:
>   Verifies SPDX generation succeeds for recipes with tarball sources
>   and that external references are properly structured (ExternalRef
>   locator is a list of strings per SPDX 3.0 spec).
>
> test_version_extraction_patterns:
>   Verifies that version extraction works correctly and all source
>   packages have proper version strings containing digits.
>
> These tests validate the source download enrichment added in the
> previous commit.
>
> Signed-off-by: Stefano Tondo 
> ---

Hi Stefano,

Thanks for the new version. Builds look correct so far, except for
these 3 selftest errors:

2026-03-12 22:29:04,908 - oe-selftest - INFO - 
spdx.SPDX30Check.test_download_location_defensive_handling 
(subunit.RemotedTestCase)
2026-03-12 22:29:04,909 - oe-selftest - INFO -  ... FAIL
...
2026-03-12 22:29:04,910 - oe-selftest - INFO - 6: 39/53 444/679 (18.85s) (0 
failed) (spdx.SPDX30Check.test_download_location_defensive_handling)
2026-03-12 22:29:04,911 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 424, in test_download_location_defensive_handling
objset = self.check_recipe_spdx(
 ^^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 123, in check_recipe_spdx
return self.check_spdx_file(filename)
   ^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 81, in check_spdx_file
self.assertExists(filename)
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/case.py",
 line 249, in assertExists
raise self.failureException(msg)
AssertionError: 
'/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/build-st-3170645/tmp/deploy/spdx/3.0.1/cortexa57/recipes/build-m4.spdx.json'
 does not exist
...
2026-03-12 23:32:02,849 - oe-selftest - INFO - 
spdx.SPDX30Check.test_packageconfig_spdx (subunit.RemotedTestCase)
2026-03-12 23:32:02,849 - oe-selftest - INFO -  ... FAIL
...
2026-03-12 23:32:02,850 - oe-selftest - INFO - 6: 43/53 634/679 (70.33s) (2 
failed) (spdx.SPDX30Check.test_packageconfig_spdx)
2026-03-12 23:32:02,850 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 393, in test_packageconfig_spdx
objset = self.check_recipe_spdx(
 ^^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 123, in check_recipe_spdx
return self.check_spdx_file(filename)
   ^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 81, in check_spdx_file
self.assertExists(filename)
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/case.py",
 line 249, in assertExists
raise self.failureException(msg)
AssertionError: 
'/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/build-st-3170645/tmp/deploy/spdx/3.0.1/cortexa57/recipes/build-tar.spdx.json'
 does not exist
...
2026-03-12 23:32:16,627 - oe-selftest - INFO - 
spdx.SPDX30Check.test_version_extraction_patterns (subunit.RemotedTestCase)
2026-03-12 23:32:16,628 - oe-selftest - INFO -  ... FAIL
...
2026-03-12 23:32:16,628 - oe-selftest - INFO - 6: 44/53 635/679 (13.78s) (4 
failed) (spdx.SPDX30Check.test_version_extraction_patterns)
2026-03-12 23:32:16,628 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/srv/p

Re: [OE-core][PATCH v9 5/7] oeqa/selftest: Add tests for source download enrichment

2026-03-12 Thread Mathieu Dubois-Briand via lists.openembedded.org
On Thu Mar 12, 2026 at 4:38 PM CET, Stefano Tondo via lists.openembedded.org 
wrote:
> From: Stefano Tondo 
>
> Add two new SPDX 3.0 selftest cases:
>
> test_download_location_defensive_handling:
>   Verifies SPDX generation succeeds for recipes with tarball sources
>   and that external references are properly structured (ExternalRef
>   locator is a list of strings per SPDX 3.0 spec).
>
> test_version_extraction_patterns:
>   Verifies that version extraction works correctly and all source
>   packages have proper version strings containing digits.
>
> These tests validate the source download enrichment added in the
> previous commit.
>
> Signed-off-by: Stefano Tondo 
> ---

Hi Stefano,

Thanks for the new version. Builds look correct so far, except for
these 3 selftest errors:

2026-03-12 22:29:04,908 - oe-selftest - INFO - 
spdx.SPDX30Check.test_download_location_defensive_handling 
(subunit.RemotedTestCase)
2026-03-12 22:29:04,909 - oe-selftest - INFO -  ... FAIL
...
2026-03-12 22:29:04,910 - oe-selftest - INFO - 6: 39/53 444/679 (18.85s) (0 
failed) (spdx.SPDX30Check.test_download_location_defensive_handling)
2026-03-12 22:29:04,911 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 424, in test_download_location_defensive_handling
objset = self.check_recipe_spdx(
 ^^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 123, in check_recipe_spdx
return self.check_spdx_file(filename)
   ^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 81, in check_spdx_file
self.assertExists(filename)
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/case.py",
 line 249, in assertExists
raise self.failureException(msg)
AssertionError: 
'/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/build-st-3170645/tmp/deploy/spdx/3.0.1/cortexa57/recipes/build-m4.spdx.json'
 does not exist
...
2026-03-12 23:32:02,849 - oe-selftest - INFO - 
spdx.SPDX30Check.test_packageconfig_spdx (subunit.RemotedTestCase)
2026-03-12 23:32:02,849 - oe-selftest - INFO -  ... FAIL
...
2026-03-12 23:32:02,850 - oe-selftest - INFO - 6: 43/53 634/679 (70.33s) (2 
failed) (spdx.SPDX30Check.test_packageconfig_spdx)
2026-03-12 23:32:02,850 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 393, in test_packageconfig_spdx
objset = self.check_recipe_spdx(
 ^^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 123, in check_recipe_spdx
return self.check_spdx_file(filename)
   ^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 81, in check_spdx_file
self.assertExists(filename)
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/case.py",
 line 249, in assertExists
raise self.failureException(msg)
AssertionError: 
'/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/build-st-3170645/tmp/deploy/spdx/3.0.1/cortexa57/recipes/build-tar.spdx.json'
 does not exist
...
2026-03-12 23:32:16,627 - oe-selftest - INFO - 
spdx.SPDX30Check.test_version_extraction_patterns (subunit.RemotedTestCase)
2026-03-12 23:32:16,628 - oe-selftest - INFO -  ... FAIL
...
2026-03-12 23:32:16,628 - oe-selftest - INFO - 6: 44/53 635/679 (13.78s) (4 
failed) (spdx.SPDX30Check.test_version_extraction_patterns)
2026-03-12 23:32:16,628 - oe-selftest - INFO - 
testtools.testresult.real._StringException: Traceback (most recent call last):
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 452, in test_version_extraction_patterns
objset = self.check_recipe_spdx(
 ^^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 123, in check_recipe_spdx
return self.check_spdx_file(filename)
   ^^
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/spdx.py",
 line 81, in check_spdx_file
self.assertExists(filename)
  File 
"/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cas