Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-19 Thread Jagadeesh Krishnanjanappa
Hi Christopher, Thanks for applying the required changes under below commit, https://github.com/openembedded/openembedded-core/compare/master...kergoth:connman-systemd-nfs Are there any plans to submit it to OE-core? Regards, Jagadeesh On Thu, Oct 13, 2016 at 7:31 AM, Jagadeesh

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-12 Thread Jagadeesh Krishnanjanappa
On Wed, Oct 12, 2016 at 12:30 PM, Andreas Oberritter wrote: > Hi Jagadeesh, > > On 11.10.2016 14:11, Jagadeesh Krishnanjanappa wrote: > > Hi Andreas, > > > > Thanks for reviewing the patch. > > > > > > I think this is too fragile to land in OE-Core. What happens if a >

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-12 Thread Andreas Oberritter
On 12.10.2016 19:49, Christopher Larson wrote: > > On Wed, Oct 12, 2016 at 12:30 AM, Andreas Oberritter > > wrote: > > On 11.10.2016 21:34, Christopher Larson wrote: > > > > On Tue, Oct 11, 2016 at 12:03 PM, Jagadeesh

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-12 Thread Christopher Larson
On Wed, Oct 12, 2016 at 12:30 AM, Andreas Oberritter wrote: > On 11.10.2016 21:34, Christopher Larson wrote: > > > > On Tue, Oct 11, 2016 at 12:03 PM, Jagadeesh Krishnanjanappa > > > > wrote: > > > > On

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-12 Thread Andreas Oberritter
Hi Chistopher, On 11.10.2016 21:34, Christopher Larson wrote: > > On Tue, Oct 11, 2016 at 12:03 PM, Jagadeesh Krishnanjanappa > > wrote: > > On Tue, Oct 11, 2016 at 9:06 PM, Christopher Larson >

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-12 Thread Andreas Oberritter
Hi Jagadeesh, On 11.10.2016 14:11, Jagadeesh Krishnanjanappa wrote: > Hi Andreas, > > Thanks for reviewing the patch. > > > I think this is too fragile to land in OE-Core. What happens if a > network driver prints "device=eth0"? Or if other kernel messages make > the string

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-11 Thread Christopher Larson
On Tue, Oct 11, 2016 at 12:03 PM, Jagadeesh Krishnanjanappa < jkrishnanjana...@mvista.com> wrote: > On Tue, Oct 11, 2016 at 9:06 PM, Christopher Larson > wrote: > >> >> On Tue, Oct 11, 2016 at 5:11 AM, Jagadeesh Krishnanjanappa < >> jkrishnanjana...@mvista.com> wrote: >> >>>

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-11 Thread Jagadeesh Krishnanjanappa
On Tue, Oct 11, 2016 at 9:06 PM, Christopher Larson wrote: > > On Tue, Oct 11, 2016 at 5:11 AM, Jagadeesh Krishnanjanappa < > jkrishnanjana...@mvista.com> wrote: > >> Thanks for reviewing the patch. >> >> >>> I think this is too fragile to land in OE-Core. What happens if a

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-11 Thread Christopher Larson
On Tue, Oct 11, 2016 at 5:11 AM, Jagadeesh Krishnanjanappa < jkrishnanjana...@mvista.com> wrote: > Thanks for reviewing the patch. > > >> I think this is too fragile to land in OE-Core. What happens if a >> network driver prints "device=eth0"? Or if other kernel messages make >> the string

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-11 Thread Jagadeesh Krishnanjanappa
Hi Andreas, Thanks for reviewing the patch. > I think this is too fragile to land in OE-Core. What happens if a > network driver prints "device=eth0"? Or if other kernel messages make > the string disappear from dmesg and connman gets restarted later? > True. If device=eth0 gets

Re: [OE-core] [PATCH] connman: get the correct network interface name from dmesg during NFS booting

2016-10-11 Thread Andreas Oberritter
Dear Jagadeesh, On 10.10.2016 19:35, Jagadeesh Krishnanjanappa wrote: > Following are the drawbacks with the current logic: > 1. If ip=dhcp in the boot command line, then the > current code makes connman to ignore "eth0" network interface > from managing internet connections. This can cause NFS