Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Phil Blundell
On Fri, 2016-11-04 at 16:55 -0700, Khem Raj wrote: > > yes I meant <= v5, it should work usually, I am just thinking its a > untested > option, it may not be as bad as I think but some testing might be > useful Well, I admit I haven't looked at the actual code, but from the comments in the patch

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Khem Raj
Phil On 11/4/16 4:14 PM, Phil Blundell wrote: > On Fri, 2016-11-04 at 11:22 -0700, Khem Raj wrote: >> >> >> On 11/4/16 2:07 AM, Li Zhou wrote: >>> >>> The swpb in macro MUTEX_SET will cause "undefined instruction" >>> error >>> on the new arm arches which don't support this assembly instruction

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Phil Blundell
On Fri, 2016-11-04 at 11:22 -0700, Khem Raj wrote: > > > On 11/4/16 2:07 AM, Li Zhou wrote: > > > > The swpb in macro MUTEX_SET will cause "undefined instruction" > > error > > on the new arm arches which don't support this assembly instruction > > any more. If use ldrex/strex to replace swpb,

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Khem Raj
Not sure the atomics in newer compiler and libc has ever been tested in this version of db On Nov 4, 2016 1:29 PM, "Burton, Ross" wrote: On 4 November 2016 at 18:22, Khem Raj wrote: > it would be good to keep this for older < armv5 arches >

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Burton, Ross
On 4 November 2016 at 18:22, Khem Raj wrote: > it would be good to keep this for older < armv5 arches > Doesn't the C library support its own atomics for those? Ross -- ___ Openembedded-core mailing list

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Khem Raj
On 11/4/16 2:07 AM, Li Zhou wrote: > The swpb in macro MUTEX_SET will cause "undefined instruction" error > on the new arm arches which don't support this assembly instruction > any more. If use ldrex/strex to replace swpb, the old arm arches don't > support them. So to avoid this issue, just

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Mark Hatle
On 11/4/16 11:12 AM, Leonardo Sandoval wrote: > This patch cannot be applied because the modified file is not track by > oe-core. > The original submitted should have mentioned this patch is against Jethro. However the patch is directly applicable to master, morty and korgoth as well. Li,

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Leonardo Sandoval
This patch cannot be applied because the modified file is not track by oe-core. On 11/04/2016 03:07 AM, Li Zhou wrote: The swpb in macro MUTEX_SET will cause "undefined instruction" error on the new arm arches which don't support this assembly instruction any more. If use ldrex/strex to

Re: [OE-core] [PATCH] db: disable the ARM assembler mutex code

2016-11-04 Thread Zhou, Li
Some more explanations: Berkeley DB's assembly mutex code for arm is related with arm arch version. The old version DB code uses old arm instruction (such as swpb), which isn't supported by new arm arch (such as armv7). The new version DB (maybe from 6.1.29 or 6.1.26) uses new arm