Re: [OE-core] [PATCH 2/2] image-buildinfo.bbclass: Introduce IMAGE_BUILDINFO_GITDESCRIBE

2019-10-09 Thread Andrei Gherzan

On 09/10/2019 18:58, Richard Purdie wrote:

On Wed, 2019-10-09 at 18:05 +0100, Andrei Gherzan wrote:

This knob can switch in between having full revisions and having git
describe references in the build info file. By default it is set to 0
to
maintain the old behaviour.

Signed-off-by: Andrei Gherzan 
---
  meta/classes/image-buildinfo.bbclass | 14 --
  1 file changed, 12 insertions(+), 2 deletions(-)


I'm not sure we want to even encourage this. We probably do want to
print/store the full hashes as output from this class as they may be
used by CI or in bug reports. The could be unique at the time of
printing but clash later. The output is also dependent on the fetched
tree.


Wait. There is indeed an issue: it should fallback to full hashes when 
human readable tags are not available. I'll address. When tags are 
available, the describe will give you the hask as well including a delta 
integer. Is that what you were concerned about?


--
Andrei Gherzan
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH 2/2] image-buildinfo.bbclass: Introduce IMAGE_BUILDINFO_GITDESCRIBE

2019-10-09 Thread Richard Purdie
On Wed, 2019-10-09 at 18:05 +0100, Andrei Gherzan wrote:
> This knob can switch in between having full revisions and having git
> describe references in the build info file. By default it is set to 0
> to
> maintain the old behaviour.
> 
> Signed-off-by: Andrei Gherzan 
> ---
>  meta/classes/image-buildinfo.bbclass | 14 --
>  1 file changed, 12 insertions(+), 2 deletions(-)

I'm not sure we want to even encourage this. We probably do want to
print/store the full hashes as output from this class as they may be
used by CI or in bug reports. The could be unique at the time of
printing but clash later. The output is also dependent on the fetched
tree.

Cheers,

Richard

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core