Re: [OE-core] [PATCH 2/2] package_ipk/rpm/deb: remove unneeded dir settings

2016-10-12 Thread Robert Yang 



On 10/12/2016 05:37 PM, Burton, Ross wrote:


On 12 October 2016 at 10:19, Robert Yang mailto:liezhi.y...@windriver.com>> wrote:

There is a do_package_write_foo[cleandirs], so the
do_package_write_foo[dirs] is not needed.


[dirs] changes the cwd whereas [cleandirs] doesn't, so assuming that you've
verified this isn't a problem the message should explain that the tasks chdir()
themselves.


Thanks, I've verified that it works well after remove the [dirs], but since it
does make sense (change the cwd), so I think that we'd better not remove them
and drop this patch ?

// Robert



Ross

--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] package_ipk/rpm/deb: remove unneeded dir settings

2016-10-12 Thread Burton, Ross 
On 12 October 2016 at 10:19, Robert Yang  wrote:

> There is a do_package_write_foo[cleandirs], so the
> do_package_write_foo[dirs] is not needed.
>

[dirs] changes the cwd whereas [cleandirs] doesn't, so assuming that you've
verified this isn't a problem the message should explain that the tasks
chdir() themselves.

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core