Re: [OE-core] [PATCH 2/2] pseudo: Add fastop reply fix

2017-09-22 Thread Otavio Salvador 
Richard,

On Fri, Sep 22, 2017 at 2:12 PM, Alexander Kanavin
 wrote:
> On 09/22/2017 07:52 PM, Seebs wrote:
>>>
>>> This changes the pseudo FASTOP functionality so that a reply to the
>>> operation is required. This means we then cannot lose data if a
>>> connection is closed. This in turn stops corruption if we run out of
>>> file handles and have to close connections.
>>>
>>> This tweaks the connection closure patch to update the comment there
>>> which is now outdated.
>>>
>>> Signed-off-by: Richard Purdie 
>>
>>
>> This looks reasonable to me. I did some testing with a very similar
>> patch and concluded that, while it slowed performance slightly, it
>> didn't slow it nearly as much as the pre-fastop behavior did.
>
> Also, the issue this patch is fixing is not theoretical. Setting max fd
> limit to a low value (192) is causing errors on my machine:
>
> dpkg-deb: error: maintainer script 'postinst' has bad permissions 644 (must
> be >=0555 and <=0775)
>
> and with the patch they seem to go away.

When queueing it, please make sure to add the proper patch headers.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] pseudo: Add fastop reply fix

2017-09-22 Thread Alexander Kanavin 

On 09/22/2017 07:52 PM, Seebs wrote:

This changes the pseudo FASTOP functionality so that a reply to the
operation is required. This means we then cannot lose data if a
connection is closed. This in turn stops corruption if we run out of
file handles and have to close connections.

This tweaks the connection closure patch to update the comment there
which is now outdated.

Signed-off-by: Richard Purdie 


This looks reasonable to me. I did some testing with a very similar
patch and concluded that, while it slowed performance slightly, it
didn't slow it nearly as much as the pre-fastop behavior did.


Also, the issue this patch is fixing is not theoretical. Setting max fd 
limit to a low value (192) is causing errors on my machine:


dpkg-deb: error: maintainer script 'postinst' has bad permissions 644 
(must be >=0555 and <=0775)


and with the patch they seem to go away.

Alex
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2] pseudo: Add fastop reply fix

2017-09-22 Thread Seebs 
On Fri, 22 Sep 2017 17:41:17 +0100
Richard Purdie  wrote:

> This changes the pseudo FASTOP functionality so that a reply to the
> operation is required. This means we then cannot lose data if a
> connection is closed. This in turn stops corruption if we run out of
> file handles and have to close connections.
> 
> This tweaks the connection closure patch to update the comment there
> which is now outdated.
> 
> Signed-off-by: Richard Purdie 

This looks reasonable to me. I did some testing with a very similar
patch and concluded that, while it slowed performance slightly, it
didn't slow it nearly as much as the pre-fastop behavior did.

-s
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core