Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232

2016-12-02 Thread Peter Kjellerstedt 
> -Original Message-
> From: Khem Raj [mailto:raj.k...@gmail.com]
> Sent: den 1 december 2016 17:50
> To: Peter Kjellerstedt
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232
> 
> On Thu, Dec 1, 2016 at 1:28 AM, Peter Kjellerstedt
>  wrote:
> >> -Original Message-
> >> From: openembedded-core-boun...@lists.openembedded.org
> >> [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf
> Of
> >> Khem Raj
> >> Sent: den 28 november 2016 22:26
> >> To: openembedded-core@lists.openembedded.org
> >> Subject: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232
> >>
> >> * Drop support for rcS.d SysV init scripts.
> >>   These are prone to cause dependency loops, and almost all packages
> >> with
> >>   rcS scripts now ship a native systemd service.
> >>
> >> * Drop mount propagation patch, it only happens with libseccomp, OE
> >> doesnt
> >>   enable it
> >>
> >> * kdbus option has disappeared from configure
> >>
> >> * Ignore dev-so for PN now since systemd introduced private .so see
> >>   https://github.com/systemd/systemd/issues/3810
> >
> > Rather than adding:
> >
> > INSANE_SKIP_${PN} += "dev-so"
> >
> > would it not be more appropriate to add
> > ${systemd_unitdir}/libsystemd-shared.so to FILES_${PN}-dev, i.e.:
> >
> > -FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> 1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
> > +FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> 1/interfaces/ ${sysconfdir}/rpm/macros.systemd
> ${systemd_unitdir}/libsystemd-shared.so"
> >
> > The binaries are linked with libsystemd-shared-232.so which ends up
> > in ${PN} as usual.
> 
> As mentioned this is not a typical .so which is a symlink and can be
> shoved into -dev package if we do that, then we have to include -dev 
> package into every image containing systemd.

Actually, I think it _is_ working like a typical .so. It _is_ a symlink 
and the applications are linked with libsystemd-shared-232.so, not 
libsystemd-shared.so, just like other libraries in /lib and /usr/lib. 
So AFAICT, it works just like all the other .so files that end up in 
-dev.

I have verified that building with ${systemd_unitdir}/libsystemd-shared.so 
added to FILES_${PN}-dev works as expected, without adding any 
dependencies on systemd-dev that should not be there.

The only difference compared to other libraries in /lib and /usr/lib is 
that libsystemd-shared-232.so remains packaged in the systemd package 
rather than in a separate lib package, which I believe is the way we 
want it to be since it is a systemd internal library.

> >> * Add libnss* to PACKAGES_DYNAMIC for libnss-resolve to work
> correctly
> >>
> >> * Forward port systemd-boot patches to systemd-232
> >>
> >> Signed-off-by: Khem Raj 
> >
> > //Peter

//Peter


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232

2016-12-01 Thread Khem Raj 
sent a v4

On Thu, Dec 1, 2016 at 12:22 PM, Burton, Ross  wrote:
>
> On 28 November 2016 at 21:26, Khem Raj  wrote:
>>
>> -PV = "230+git${SRCPV}"
>
>
> packages/corei7-64-intel-common-poky-linux/systemd-boot/systemd-boot-dev:
> PKGV changed from 230+git0+3a74d4fc90 to 1.0 [default]
>
> I'm starting to wonder if systemd and systemd-boot sharing a .inc is a good
> idea!
>
> Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232

2016-12-01 Thread Khem Raj 
On Thu, Dec 1, 2016 at 12:22 PM, Burton, Ross  wrote:
>
> On 28 November 2016 at 21:26, Khem Raj  wrote:
>>
>> -PV = "230+git${SRCPV}"
>
>
> packages/corei7-64-intel-common-poky-linux/systemd-boot/systemd-boot-dev:
> PKGV changed from 230+git0+3a74d4fc90 to 1.0 [default]
>
> I'm starting to wonder if systemd and systemd-boot sharing a .inc is a good
> idea!

I think its fine. We should consolidate all systemd related recipes in
one place may
be under

recipes-systemd/
or recipes-core/systemd

currently we have

./recipes-devtools/systemd-bootchart/systemd-bootchart_230.bb
./recipes-bsp/systemd-boot/systemd-boot.bb
./recipes-core/systemd/systemd_232.bb
./recipes-core/systemd/systemd-serialgetty.bb
./recipes-core/systemd/systemd.inc
./recipes-core/systemd/systemd-compat-units.bb
./recipes-core/systemd/systemd-systemctl-native.bb



>
> Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232

2016-12-01 Thread Burton, Ross 
On 28 November 2016 at 21:26, Khem Raj  wrote:

> -PV = "230+git${SRCPV}"
>

packages/corei7-64-intel-common-poky-linux/systemd-boot/systemd-boot-dev:
PKGV changed from 230+git0+3a74d4fc90 to 1.0 [default]

I'm starting to wonder if systemd and systemd-boot sharing a .inc is a good
idea!

Ross
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232

2016-12-01 Thread Khem Raj 
On Thu, Dec 1, 2016 at 1:28 AM, Peter Kjellerstedt
 wrote:
>> -Original Message-
>> From: openembedded-core-boun...@lists.openembedded.org
>> [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of
>> Khem Raj
>> Sent: den 28 november 2016 22:26
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232
>>
>> * Drop support for rcS.d SysV init scripts.
>>   These are prone to cause dependency loops, and almost all packages
>> with
>>   rcS scripts now ship a native systemd service.
>>
>> * Drop mount propagation patch, it only happens with libseccomp, OE
>> doesnt
>>   enable it
>>
>> * kdbus option has disappeared from configure
>>
>> * Ignore dev-so for PN now since systemd introduced private .so see
>>   https://github.com/systemd/systemd/issues/3810
>
> Rather than adding:
>
> INSANE_SKIP_${PN} += "dev-so"
>
> would it not be more appropriate to add
> ${systemd_unitdir}/libsystemd-shared.so to FILES_${PN}-dev, i.e.:
>
> -FILES_${PN}-dev += "${base_libdir}/security/*.la 
> ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
> +FILES_${PN}-dev += "${base_libdir}/security/*.la 
> ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd 
> ${systemd_unitdir}/libsystemd-shared.so"
>
> The binaries are linked with libsystemd-shared-232.so which ends up in
> ${PN} as usual.

As mentioned this is not a typical .so which is a symlink and can be
shoved into -dev package
if we do that, then we have to include -dev package into every image
containing systemd.

>
>> * Add libnss* to PACKAGES_DYNAMIC for libnss-resolve to work correctly
>>
>> * Forward port systemd-boot patches to systemd-232
>>
>> Signed-off-by: Khem Raj 
>
> //Peter
>
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232

2016-12-01 Thread Peter Kjellerstedt 
> -Original Message-
> From: openembedded-core-boun...@lists.openembedded.org
> [mailto:openembedded-core-boun...@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: den 28 november 2016 22:26
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 2/2 V5] systemd: Upgrade to 232
> 
> * Drop support for rcS.d SysV init scripts.
>   These are prone to cause dependency loops, and almost all packages
> with
>   rcS scripts now ship a native systemd service.
> 
> * Drop mount propagation patch, it only happens with libseccomp, OE
> doesnt
>   enable it
> 
> * kdbus option has disappeared from configure
> 
> * Ignore dev-so for PN now since systemd introduced private .so see
>   https://github.com/systemd/systemd/issues/3810

Rather than adding:

INSANE_SKIP_${PN} += "dev-so"

would it not be more appropriate to add 
${systemd_unitdir}/libsystemd-shared.so to FILES_${PN}-dev, i.e.:

-FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ 
${sysconfdir}/rpm/macros.systemd"
+FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ 
${sysconfdir}/rpm/macros.systemd ${systemd_unitdir}/libsystemd-shared.so"

The binaries are linked with libsystemd-shared-232.so which ends up in 
${PN} as usual.

> * Add libnss* to PACKAGES_DYNAMIC for libnss-resolve to work correctly
> 
> * Forward port systemd-boot patches to systemd-232
> 
> Signed-off-by: Khem Raj 

//Peter

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core