Re: [OE-core] [PATCH 7/9] selftest: skip runtime-test's test_testimage_install on poky-tiny distro

2016-10-18 Thread Joshua Lock 
On Mon, 2016-10-17 at 11:02 -0500, Leonardo Sandoval wrote:
> 
> On 10/17/2016 02:09 AM, Joshua Lock wrote:
> > 
> > On Fri, 2016-10-14 at 11:40 -0500,
> > leonardo.sandoval.gonza...@linux.intel.com wrote:
> > > 
> > > From: Leonardo Sandoval  > > om>
> > > 
> > > Distro poky-tiny cannot build the core-image-full-cmdline image,
> > > so
> > > skip the
> > > test if this is the case.
> > > 
> > > [YOCTO #8525]
> > Wouldn't it be better to use a different image, most likely with
> > extra
> > packages installed, and maybe a different list of TEST_SUITES for
> > poky-
> > tiny so that we're still testing this functionality on poky-tiny?
> 
> Yes, that is a good idea. Which image and the accompanied tests do
> you 
> suggest?

I'd be inclined to suggest core-image-minimal with extra packages
installed to enable the same TEST_SUITES, but I can't recall exactly
what's being tested here. Would that combination make sense?

Thanks,

Joshua

> 
> > 
> > Thanks,
> > 
> > Joshua
> > 
> > > 
> > > Signed-off-by: Leonardo Sandoval  > > x.in
> > > tel.com>
> > > ---
> > >   meta/lib/oeqa/selftest/runtime-test.py | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/meta/lib/oeqa/selftest/runtime-test.py
> > > b/meta/lib/oeqa/selftest/runtime-test.py
> > > index c2d5b45..e17c261 100644
> > > --- a/meta/lib/oeqa/selftest/runtime-test.py
> > > +++ b/meta/lib/oeqa/selftest/runtime-test.py
> > > @@ -94,6 +94,8 @@ class TestImage(oeSelfTest):
> > >   Product: oe-core
> > >   Author: Mariano Lopez 
> > >   """
> > > +if self.distro == 'poky-tiny':
> > > +self.skipTest('core-image-full-cmdline not buildable
> > > for
> > > poky-tiny')
> > >   
> > >   features = 'INHERIT += "testimage"\n'
> > >   features += 'TEST_SUITES = "ping ssh selftest"\n'
> > > -- 
> > > 2.1.4
> > > 
> 
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 7/9] selftest: skip runtime-test's test_testimage_install on poky-tiny distro

2016-10-17 Thread Leonardo Sandoval 



On 10/17/2016 02:09 AM, Joshua Lock wrote:

On Fri, 2016-10-14 at 11:40 -0500,
leonardo.sandoval.gonza...@linux.intel.com wrote:

From: Leonardo Sandoval 

Distro poky-tiny cannot build the core-image-full-cmdline image, so
skip the
test if this is the case.

[YOCTO #8525]

Wouldn't it be better to use a different image, most likely with extra
packages installed, and maybe a different list of TEST_SUITES for poky-
tiny so that we're still testing this functionality on poky-tiny?


Yes, that is a good idea. Which image and the accompanied tests do you 
suggest?




Thanks,

Joshua


Signed-off-by: Leonardo Sandoval 
---
  meta/lib/oeqa/selftest/runtime-test.py | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/meta/lib/oeqa/selftest/runtime-test.py
b/meta/lib/oeqa/selftest/runtime-test.py
index c2d5b45..e17c261 100644
--- a/meta/lib/oeqa/selftest/runtime-test.py
+++ b/meta/lib/oeqa/selftest/runtime-test.py
@@ -94,6 +94,8 @@ class TestImage(oeSelfTest):
  Product: oe-core
  Author: Mariano Lopez 
  """
+if self.distro == 'poky-tiny':
+self.skipTest('core-image-full-cmdline not buildable for
poky-tiny')
  
  features = 'INHERIT += "testimage"\n'

  features += 'TEST_SUITES = "ping ssh selftest"\n'
--
2.1.4



--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 7/9] selftest: skip runtime-test's test_testimage_install on poky-tiny distro

2016-10-17 Thread Joshua Lock 
On Fri, 2016-10-14 at 11:40 -0500,
leonardo.sandoval.gonza...@linux.intel.com wrote:
> From: Leonardo Sandoval 
> 
> Distro poky-tiny cannot build the core-image-full-cmdline image, so
> skip the
> test if this is the case.
> 
> [YOCTO #8525]

Wouldn't it be better to use a different image, most likely with extra
packages installed, and maybe a different list of TEST_SUITES for poky-
tiny so that we're still testing this functionality on poky-tiny?

Thanks,

Joshua

> 
> Signed-off-by: Leonardo Sandoval  tel.com>
> ---
>  meta/lib/oeqa/selftest/runtime-test.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/runtime-test.py
> b/meta/lib/oeqa/selftest/runtime-test.py
> index c2d5b45..e17c261 100644
> --- a/meta/lib/oeqa/selftest/runtime-test.py
> +++ b/meta/lib/oeqa/selftest/runtime-test.py
> @@ -94,6 +94,8 @@ class TestImage(oeSelfTest):
>  Product: oe-core
>  Author: Mariano Lopez 
>  """
> +if self.distro == 'poky-tiny':
> +self.skipTest('core-image-full-cmdline not buildable for
> poky-tiny')
>  
>  features = 'INHERIT += "testimage"\n'
>  features += 'TEST_SUITES = "ping ssh selftest"\n'
> -- 
> 2.1.4
> 
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core