Re: [OE-core] [PATCH v2] make-mod-scripts: change how some kernel module tools are built

2018-02-20 Thread Bruce Ashfield

On 02/19/2018 06:45 PM, Richard Purdie wrote:

On Mon, 2018-02-19 at 10:37 -0500, Bruce Ashfield wrote:

From: Joe Slater 

Remove do_make_scripts() from module-base.bbclass and put
functionality in a recipe.  This will build the scripts only
once instead of each time an external module is built.

[YOCTO #12228]

Signed-off-by: Joe Slater 
Signed-off-by: Bruce Ashfield 
---

v2: added the LIC_FILES_CHECKSUM



Sadly this doesn't pass all our tests:

https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/827/steps/Running%20oe-selftest/logs/stdio

oe-selftest -r sstatetests.SStateTests.test_sstate_sametune_samesigs

should reproduce.

I suspect that the recipe may need:

PACKAGE_ARCH = "${MACHINE_ARCH}"


v3 has been sent for the two patches in this series. With the
kernel-devsrc and other scripts/prepare work in progress, I'm sure
there will be more changes coming. But the dependencies and and
build steps are definitely easier to express in the separate recipe
versus being buried in the various bbclasses.

Cheers,

Bruce



Cheers,

Richard



--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v2] make-mod-scripts: change how some kernel module tools are built

2018-02-20 Thread Bruce Ashfield

On 02/19/2018 06:45 PM, Richard Purdie wrote:

On Mon, 2018-02-19 at 10:37 -0500, Bruce Ashfield wrote:

From: Joe Slater 

Remove do_make_scripts() from module-base.bbclass and put
functionality in a recipe.  This will build the scripts only
once instead of each time an external module is built.

[YOCTO #12228]

Signed-off-by: Joe Slater 
Signed-off-by: Bruce Ashfield 
---

v2: added the LIC_FILES_CHECKSUM



Sadly this doesn't pass all our tests:

https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/827/steps/Running%20oe-selftest/logs/stdio

oe-selftest -r sstatetests.SStateTests.test_sstate_sametune_samesigs

should reproduce.

I suspect that the recipe may need:

PACKAGE_ARCH = "${MACHINE_ARCH}"


Once I finally got my layers correct, this does fix the problem.
Assuming I ran the test properly ;) Will send a v3 shortly.


:~/poky/build$ oe-selftest -r 
sstatetests.SStateTests.test_sstate_sametune_samesigs

2018-02-20 10:36:21,167 - oe-selftest - INFO - Adding layer libraries:
2018-02-20 10:36:21,167 - oe-selftest - INFO -  /home/bruce/poky/meta/lib
2018-02-20 10:36:21,167 - oe-selftest - INFO - 
/home/bruce/poky/meta-yocto-bsp/lib
2018-02-20 10:36:21,167 - oe-selftest - INFO - 
/home/bruce/poky/meta-selftest/lib

2018-02-20 10:36:21,169 - oe-selftest - INFO - Running bitbake -p
2018-02-20 10:36:31,724 - oe-selftest - INFO - Adding: "include 
selftest.inc" in /home/bruce/poky/build/conf/local.conf
2018-02-20 10:36:31,724 - oe-selftest - INFO - Adding: "include 
bblayers.inc" in bblayers.conf
2018-02-20 10:36:31,724 - oe-selftest - INFO - 
test_sstate_sametune_samesigs (sstatetests.SStateTests)

2018-02-20 10:40:14,496 - oe-selftest - INFO -  ... ok
2018-02-20 10:40:14,496 - oe-selftest - INFO - 
--

2018-02-20 10:40:14,497 - oe-selftest - INFO - Ran 1 test in 222.773s
2018-02-20 10:40:14,497 - oe-selftest - INFO - OK
2018-02-20 10:40:14,497 - oe-selftest - INFO - RESULTS:
2018-02-20 10:40:14,497 - oe-selftest - INFO - RESULTS - 
sstatetests.SStateTests.test_sstate_sametune_samesigs - Testcase 1369: 
PASSED

2018-02-20 10:40:14,497 - oe-selftest - INFO - SUMMARY:
2018-02-20 10:40:14,497 - oe-selftest - INFO - oe-selftest () - Ran 1 
test in 222.774s
2018-02-20 10:40:14,497 - oe-selftest - INFO - oe-selftest - OK - All 
required tests passed


Bruce



Cheers,

Richard



--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v2] make-mod-scripts: change how some kernel module tools are built

2018-02-19 Thread Bruce Ashfield
On Mon, Feb 19, 2018 at 6:45 PM, Richard Purdie
 wrote:
> On Mon, 2018-02-19 at 10:37 -0500, Bruce Ashfield wrote:
>> From: Joe Slater 
>>
>> Remove do_make_scripts() from module-base.bbclass and put
>> functionality in a recipe.  This will build the scripts only
>> once instead of each time an external module is built.
>>
>> [YOCTO #12228]
>>
>> Signed-off-by: Joe Slater 
>> Signed-off-by: Bruce Ashfield 
>> ---
>>
>> v2: added the LIC_FILES_CHECKSUM
>>
>
> Sadly this doesn't pass all our tests:
>
> https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/827/steps/Running%20oe-selftest/logs/stdio
>
> oe-selftest -r sstatetests.SStateTests.test_sstate_sametune_samesigs
>
> should reproduce.
>
> I suspect that the recipe may need:
>
> PACKAGE_ARCH = "${MACHINE_ARCH}"

I'll see what I can do. I don't hold a lot of in-depth knowledge on
this topic, but I made that change locally and am starting a build.

Bruce

>
> Cheers,
>
> Richard
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v2] make-mod-scripts: change how some kernel module tools are built

2018-02-19 Thread Richard Purdie
On Mon, 2018-02-19 at 10:37 -0500, Bruce Ashfield wrote:
> From: Joe Slater 
> 
> Remove do_make_scripts() from module-base.bbclass and put
> functionality in a recipe.  This will build the scripts only
> once instead of each time an external module is built.
> 
> [YOCTO #12228]
> 
> Signed-off-by: Joe Slater 
> Signed-off-by: Bruce Ashfield 
> ---
> 
> v2: added the LIC_FILES_CHECKSUM
> 

Sadly this doesn't pass all our tests:

https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/827/steps/Running%20oe-selftest/logs/stdio

oe-selftest -r sstatetests.SStateTests.test_sstate_sametune_samesigs

should reproduce.

I suspect that the recipe may need:

PACKAGE_ARCH = "${MACHINE_ARCH}"

Cheers,

Richard
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core